Re: [PATCH v3] input: MXC: add mxc-keypad driver to support the Keypad Port present in the mxc application processors family.

["Lothar Waßmann" <LW@KARO-electronics.de>]

Hi,

Alberto Panizzo writes:
> On mer, 2010-01-27 at 13:18 +0100, Lothar Waßmann wrote:
> > Hi,
> > 
> > Alberto Panizzo writes:
> > > > > +	irq = platform_get_irq(pdev, 0);
> > > > > +	if (irq < 0) {
> > > > > +		dev_err(&pdev->dev, "failed to get keypad irq\n");
> > > > > +		return -ENXIO;
> > > > > +	}
> > > > >
> > > > This should be -ENODEV.
> > > > 
> > > Lot of reference keyboard driver use -ENXIO..
> > > May should be better: return irq ?
> > > 
> > Yes, of course. If a function returns an error code that should be
> > promoted to the caller instead of inventing a new error code.
> > 
> > 
> > Lothar Waßmann
> 
> But, errno.h say:
> #define ENXIO           6                // Device not configured
> #define ENODEV          19               // Operation not supported by device
> 
What errno.h file is that?
I have:
./include/asm-generic/errno-base.h:#define      ENXIO            6      /* No such device or address */
./include/asm-generic/errno-base.h:#define      ENODEV          19      /* No such device */

AFAIK ENXIO is used when actual I/O has been attempted. But in this
case the driver is still being configured and did not do any I/O yet.


Lothar Waßmann
-- 
___________________________________________________________

Ka-Ro electronics GmbH | Pascalstraße 22 | D - 52076 Aachen
Phone: +49 2408 1402-0 | Fax: +49 2408 1402-10
Geschäftsführer: Matthias Kaussen
Handelsregistereintrag: Amtsgericht Aachen, HRB 4996

www.karo-electronics.de | info@karo-electronics.de
___________________________________________________________