From: "justin busby" <jb.kernel@fastmail.com>
To: "Dmitry Torokhov" <dmitry.torokhov@gmail.com>,
linux-input@vger.kernel.org
Subject: [PATCH] Fix two finger scroll which stops working on synaptics touchpad after resume
Date: Tue, 22 Dec 2020 18:19:48 +0000 [thread overview]
Message-ID: <1e2e981b-05af-43a7-bdfe-424d8783d28f@www.fastmail.com> (raw)
Hello,
Bug reported here: https://bugzilla.kernel.org/show_bug.cgi?id=196719
Reliably reproduceable on my Lenovo T540p.
It looks like the this was introduced between the fast reconnect and smbus companion work in 0ab3fa57425023f42e8822a293d9b87a3ad4e2b3 ( Input: psmouse - implement fast reconnect option) and 8eb92e5c91338eb19f86ffb2232258337ebf905b (Input: psmouse - add support for SMBus companions) respectively meaning that fast_reconnect is called psmouse-smbus.c rather reconnect in synaptics.c. This is because synaptics.c doesn't set up fast_reconnect in the struct so it's left as the one added by the smbus companion code.
Set the fast_reconnect function pointer to the reconnect function in synaptics.c.
Kind Regards,
Justin.
--- /home/justin/development/linux/drivers/input/mouse/synaptics.c.orig 2020-12-22 17:35:47.194989017 +0000
+++ /home/justin/development/linux/drivers/input/mouse/synaptics.c 2020-12-22 17:36:09.863354144 +0000
@@ -1619,6 +1619,7 @@ static int synaptics_init_ps2(struct psm
psmouse->set_rate = synaptics_set_rate;
psmouse->disconnect = synaptics_disconnect;
psmouse->reconnect = synaptics_reconnect;
+ psmouse->fast_reconnect = synaptics_reconnect;
psmouse->cleanup = synaptics_reset;
/* Synaptics can usually stay in sync without extra help */
psmouse->resync_time = 0;
Signed-off-by: Justin Busby <jb.kernel@fastmail.com>
reply other threads:[~2020-12-22 18:20 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1e2e981b-05af-43a7-bdfe-424d8783d28f@www.fastmail.com \
--to=jb.kernel@fastmail.com \
--cc=dmitry.torokhov@gmail.com \
--cc=linux-input@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).