From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mika Westerberg Subject: Re: [PATCH v3 0/1] Input: gpio-keys: support for disabling GPIOs Date: Thu, 3 Dec 2009 10:09:01 +0200 Message-ID: <20091203080901.GB5626@gw.healthdatacare.com> References: <20091203061912.GA5626@gw.healthdatacare.com> <20091203062641.GH9121@core.coreip.homeip.net> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from mail-bw0-f227.google.com ([209.85.218.227]:44065 "EHLO mail-bw0-f227.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751581AbZLCII7 (ORCPT ); Thu, 3 Dec 2009 03:08:59 -0500 Received: by bwz27 with SMTP id 27so867170bwz.21 for ; Thu, 03 Dec 2009 00:09:04 -0800 (PST) Content-Disposition: inline In-Reply-To: <20091203062641.GH9121@core.coreip.homeip.net> Sender: linux-input-owner@vger.kernel.org List-Id: linux-input@vger.kernel.org To: Dmitry Torokhov Cc: linux-input@vger.kernel.org On Wed, Dec 02, 2009 at 10:26:41PM -0800, Dmitry Torokhov wrote: > On Thu, Dec 03, 2009 at 08:19:12AM +0200, Mika Westerberg wrote: > > On Tue, Dec 01, 2009 at 03:53:45PM +0200, Mika Westerberg wrote: > > > > > > This is third version of the series. Purpose of this patch is to allow > > > userland to disable GPIO buttons interrupting the CPU. There is now sysfs > > > interface that can be used to control the buttons by key code or by switch > > > code. > > > > > > I merged those previous 2 patches as one. This is because it made little > > > sense of having separate patch for adding the 'can_disable' field. > > > > > > Changes in v3: > > > - merged previous 2 patches into one > > > - buttons have 'can_disable' field instead of irqflags field > > > > > > Tested with RX-51. > > > > Hi Dmitry, > > > > Any comments on this? Is it OK to be applied or do I need to change > > something. > > > > Hi Mika, > > SOrry, I am still pondering how to go about it. I am sure that the sysfs > interface is proper, so at this point it is just implementation details > that I am not quite sure yet... Ok, thanks. Please let me know if there is need to change something. We would really like this to be merged with .33. Thanks for your time, MW