From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Matthew Garrett <mjg59@srcf.ucam.org>
Cc: linux-input@vger.kernel.org, linux-acpi@vger.kernel.org, lenb@kernel.org
Subject: Re: [PATCH 1/2] input: Allow filtering of i8042 events
Date: Wed, 9 Dec 2009 12:39:39 -0800 [thread overview]
Message-ID: <20091209203939.GC10138@core.coreip.homeip.net> (raw)
In-Reply-To: <20091209201620.GA25133@srcf.ucam.org>
On Wed, Dec 09, 2009 at 08:16:20PM +0000, Matthew Garrett wrote:
> On Wed, Dec 09, 2009 at 12:06:15PM -0800, Dmitry Torokhov wrote:
>
> > This is certainly going in the direction I wanted but it looks like
> > it is more complex than it needs to be. Why don't you just allow
> > installing global filter for entire i8042 (pass the status register
> > there along with data byte)? The data you are interested in goes kind of
> > "ouside" KBD/AUX port abstraction anyway... Plus currently you are not
> > handling MUX case properly.
>
> Wouldn't that require me to be able to process any conceivable mouse
> protocol as well?
No, just have your filter function check STR to make sure the byte you got
is not coming from AUX. Or we could say that filter only works for data
pretending to be coming from KBD (because in reality the data we are
trying to filter out comes only this way) and move the check into i8042
itself.
--
Dmitry
next prev parent reply other threads:[~2009-12-09 20:39 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-12-09 18:33 [PATCH 1/2] input: Allow filtering of i8042 events Matthew Garrett
2009-12-09 18:33 ` [PATCH 2/2] dell-laptop: Update rfkill state on kill switch Matthew Garrett
2009-12-09 20:07 ` Dmitry Torokhov
2009-12-09 20:06 ` [PATCH 1/2] input: Allow filtering of i8042 events Dmitry Torokhov
2009-12-09 20:16 ` Matthew Garrett
2009-12-09 20:39 ` Dmitry Torokhov [this message]
2009-12-10 23:25 ` Matthew Garrett
2009-12-10 23:25 ` [PATCH 2/2] dell-laptop: Update rfkill state on kill switch Matthew Garrett
2009-12-29 10:01 ` Dmitry Torokhov
2009-12-11 7:59 ` [PATCH 1/2] input: Allow filtering of i8042 events Dmitry Torokhov
2009-12-11 12:46 ` Matthew Garrett
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091209203939.GC10138@core.coreip.homeip.net \
--to=dmitry.torokhov@gmail.com \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=mjg59@srcf.ucam.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).