linux-input.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Daniel Mack <daniel@caiaq.de>
Cc: linux-input@vger.kernel.org,
	Jani Nikula <ext-jani.1.nikula@nokia.com>,
	Mike Rapoport <mike@compulab.co.il>
Subject: Re: [PATCH] input_ gpio_keys: scan gpio state at probe time
Date: Sun, 13 Dec 2009 20:31:17 -0800	[thread overview]
Message-ID: <20091214043117.GC16760@core.coreip.homeip.net> (raw)
In-Reply-To: <20091214031054.GX28375@buzzloop.caiaq.de>

On Mon, Dec 14, 2009 at 11:10:55AM +0800, Daniel Mack wrote:
> On Wed, Nov 25, 2009 at 07:46:13PM -0800, Dmitry Torokhov wrote:
> > On Wed, Nov 25, 2009 at 11:53:36AM +0100, Daniel Mack wrote:
> > > gpio_keys.c registers interrupts at both edges of all given gpio lines
> > > and updates the input device when they change. However, the driver fails
> > > to check the current line state at probe time.
> > > 
> > 
> > Should not matter for keys really, but is important for swicthes. I
> > guess we need to also do this at resume. Does the following still work?
> 
> Sorry for the long delay on this. I could finally test this patch and it
> works fine, key states are reported correctly after resume.
> 

Thanks Daniel.

-- 
Dmitry

  reply	other threads:[~2009-12-14  4:39 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-11-25 10:53 [PATCH] input_ gpio_keys: scan gpio state at probe time Daniel Mack
2009-11-26  3:46 ` Dmitry Torokhov
2009-12-14  3:10   ` Daniel Mack
2009-12-14  4:31     ` Dmitry Torokhov [this message]
2009-12-17  1:05       ` Daniel Mack
2009-12-17  1:16         ` Dmitry Torokhov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20091214043117.GC16760@core.coreip.homeip.net \
    --to=dmitry.torokhov@gmail.com \
    --cc=daniel@caiaq.de \
    --cc=ext-jani.1.nikula@nokia.com \
    --cc=linux-input@vger.kernel.org \
    --cc=mike@compulab.co.il \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).