Linux Input Archive on
 help / color / Atom feed
From: Greg KH <>
To: "Rick L. Vinyard, Jr." <>
Cc: Linux <>,
	Linux Input <>,
	Linux USB <>
Subject: Re: [PATCH] Logitech G13 driver against torvalds/linux-2.6.git
Date: Mon, 14 Dec 2009 11:48:40 -0800
Message-ID: <> (raw)
In-Reply-To: <>

Great first cut, but please:
	- your patch was linewrapped, please fix your email client to
	  not do that.
	- You did not provide a signed-off-by: line as required by the
	  file Documentation/SubmittingPatches
	- You did not provide a good changelog entry in the body of the
	  email explaining what this patch is, and what it does.
	- you did not cc: the HID maintainer, who is the proper person
	  to apply this patch.  Try using the script,
	  scripts/ to figure out who to send patches
	- Can you run your patch through the scripts/
	  script and fix the errors and warnings it reports?  It would
	  have caught many of the above mentioned things.

Care to try again?


greg k-h

      reply index

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-12-14 19:40 Rick L. Vinyard, Jr.
2009-12-14 19:48 ` Greg KH [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Linux Input Archive on

Archives are clonable:
	git clone --mirror linux-input/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-input linux-input/ \
	public-inbox-index linux-input

Example config snippet for mirrors

Newsgroup available over NNTP:

AGPL code for this site: git clone