From: Greg KH <greg@kroah.com>
To: "Rick L. Vinyard, Jr." <rvinyard@cs.nmsu.edu>
Cc: Linux <linux-kernel@vger.kernel.org>,
Linux Input <linux-input@vger.kernel.org>,
Linux USB <linux-usb@vger.kernel.org>
Subject: Re: [PATCH] Logitech G13 driver against torvalds/linux-2.6.git
Date: Mon, 14 Dec 2009 11:48:40 -0800 [thread overview]
Message-ID: <20091214194840.GA7033@kroah.com> (raw)
In-Reply-To: <376bcd26469b6af1d9dda57fd9a1de19.squirrel@intranet.cs.nmsu.edu>
Great first cut, but please:
- your patch was linewrapped, please fix your email client to
not do that.
- You did not provide a signed-off-by: line as required by the
file Documentation/SubmittingPatches
- You did not provide a good changelog entry in the body of the
email explaining what this patch is, and what it does.
- you did not cc: the HID maintainer, who is the proper person
to apply this patch. Try using the script,
scripts/get_maintainer.pl to figure out who to send patches
to.
- Can you run your patch through the scripts/checkpatch.pl
script and fix the errors and warnings it reports? It would
have caught many of the above mentioned things.
Care to try again?
thanks,
greg k-h
prev parent reply other threads:[~2009-12-14 19:48 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-12-14 19:40 [PATCH] Logitech G13 driver against torvalds/linux-2.6.git Rick L. Vinyard, Jr.
2009-12-14 19:48 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091214194840.GA7033@kroah.com \
--to=greg@kroah.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=rvinyard@cs.nmsu.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).