From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dmitry Torokhov Subject: Re: 32-rc1 aka 32-rc2: warning at manage.c:361 (set_irq_wake), matrix-keypad related? Date: Sat, 2 Jan 2010 23:57:33 -0800 Message-ID: <20100103075733.GA1358@core.coreip.homeip.net> References: <20090930200746.GA1384@ucw.cz> <20091006050649.GH27881@core.coreip.homeip.net> <20091006075816.GA1362@ucw.cz> <20091007043603.GC10204@core.coreip.homeip.net> <20091007163327.GA12053@core.coreip.homeip.net> <20091007211225.GB17805@elf.ucw.cz> <20091203031709.GE9121@core.coreip.homeip.net> <20100102135608.GA5872@ucw.cz> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from mail-yx0-f188.google.com ([209.85.210.188]:47605 "EHLO mail-yx0-f188.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751038Ab0ACH5j (ORCPT ); Sun, 3 Jan 2010 02:57:39 -0500 Content-Disposition: inline In-Reply-To: <20100102135608.GA5872@ucw.cz> Sender: linux-input-owner@vger.kernel.org List-Id: linux-input@vger.kernel.org To: Pavel Machek Cc: Eric Miao , rpurdie@rpsys.net, lenz@cs.wisc.edu, kernel list , Dirk@opfer-online.de, arminlitzel@web.de, Cyril Hrubis , thommycheck@gmail.com, linux-arm-kernel , dbaryshkov@gmail.com, omegamoon@gmail.com, utx@penguin.cz, linux-input@vger.kernel.org, "Rafael J. Wysocki" On Sat, Jan 02, 2010 at 02:56:09PM +0100, Pavel Machek wrote: > Hi! > > > > > We ignore the failure right now in the mainline but that causes stack > > > > traces on resume as we trying to disable not enabled wakeup GPIOs. That > > > > was original Pavel's complaint. > > > > > > Yep... > > > > > > I'd say that BUG() simply should not trigger if wakeup can not be > > > enabled/disabled for particular source...? > > > > Pavel, > > > > Could you please try the patch below and let me know if it fixes the > > problem for you? > > (sorry for long delay). > > With 33-rc1+your patch, warnings are no longer there. > Thank you for testing. > I still have one on irq191, but that's gpio button driver. > > But please, hold the patch for few more days. I may have cleaner/nicer > solution. It seems that zaurus is doing something very stupid in low layers. Sorry, it is already upstream. However I do think that the change is needed. As long as set_irq_wake() may return an error the driver should handle such error. Especially matrix_keypad that operates with large number of GPIOs but has only one knob for enabling wakeup. -- Dmitry