From mboxrd@z Thu Jan 1 00:00:00 1970 From: Bastian Blank Subject: [PATCH 7/7] Input: wacom - Fail on missing features Date: Thu, 7 Jan 2010 19:30:09 +0100 Message-ID: <20100107183009.GA13036@wavehammer.waldi.eu.org> References: <20100107182553.GA11236@wavehammer.waldi.eu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Return-path: Received: from wavehammer.waldi.eu.org ([82.139.201.20]:56845 "EHLO wavehammer.waldi.eu.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751681Ab0AGSkv (ORCPT ); Thu, 7 Jan 2010 13:40:51 -0500 Content-Disposition: inline In-Reply-To: <20100107182553.GA11236@wavehammer.waldi.eu.org> Sender: linux-input-owner@vger.kernel.org List-Id: linux-input@vger.kernel.org To: linux-input@vger.kernel.org, linux-kernel@vger.kernel.org, Ping Cheng The driver needs a correct setup feature list, fail if it is not correctly set. Signed-off-by: Bastian Blank --- drivers/input/tablet/wacom_sys.c | 3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) diff --git a/drivers/input/tablet/wacom_sys.c b/drivers/input/tablet/wacom_sys.c index 41a631b..c44b9f0 100644 --- a/drivers/input/tablet/wacom_sys.c +++ b/drivers/input/tablet/wacom_sys.c @@ -534,6 +534,9 @@ static int wacom_probe(struct usb_interface *intf, const struct usb_device_id *i struct input_dev *input_dev; int error = -ENOMEM; + if (!features) + return -EIO; + wacom = kzalloc(sizeof(struct wacom), GFP_KERNEL); wacom_wac = kzalloc(sizeof(struct wacom_wac), GFP_KERNEL); input_dev = input_allocate_device(); -- 1.6.5.7 -- Well, Jim, I'm not much of an actor either.