From: Bastian Blank <waldi@debian.org>
To: Ping Cheng <pingc@wacom.com>
Cc: linux-input@vger.kernel.org, linux-kernel@vger.kernel.org,
Dmitry Torokhov <dmitry.torokhov@gmail.com>,
Jason Childs <oblivian@users.sourceforge.net>
Subject: Re: [PATCH 5/7] Input: wacom - Convert remaining ids, part two
Date: Mon, 11 Jan 2010 23:24:48 +0100 [thread overview]
Message-ID: <20100111222448.GA7959@wavehammer.waldi.eu.org> (raw)
In-Reply-To: <6753EB6004AFF34FAA275742C104F952016A1329@wacom-nt10.wacom.com>
Please fix your MUA, it should break lines to below 80 characters.
On Mon, Jan 11, 2010 at 01:22:31PM -0800, Ping Cheng wrote:
> Can we only move the struct wacom_features definition to wacom_sys.c
> and leave the device specific wacom_features in wacom_wac.c?
The driver is so small. I don't see any reason to split that at all.
> Also
> leave the actual wacom_ids [] in wacom_wac.c as well since they are
> wacom specific stuff.
No, this are USB id mappings, Linux specific ones.
> We'd like to keep wacom specific stuff in
> wacom_wac.c/h, which hopefully can be shared among kernel releases.
The two parts are not properly seperated, none of them can stand on its
own. How exactly do you want to do that?
> BTW, the testing, led by Jason, got very positive feedbacks. There is
> no crash reported with your patch applied.
Why should there be any crashs? It is a simple restructuring.
While we are at it, why does this driver need this amount of hardcoding
of the values in the kernel anyway?
Bastian
--
Schshschshchsch.
-- The Gorn, "Arena", stardate 3046.2
next prev parent reply other threads:[~2010-01-11 22:24 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-07 18:25 [PATCH 0/7] Input: wacom - Setup features via driver info Bastian Blank
2010-01-07 18:29 ` [PATCH 1/7] Input: wacom - Move device ids to the initialisation Bastian Blank
2010-01-07 18:29 ` [PATCH 2/7] Input: wacom - Get features from driver info Bastian Blank
2010-01-07 19:06 ` Dmitry Torokhov
2010-01-07 19:21 ` Bastian Blank
2010-01-07 19:39 ` Dmitry Torokhov
2010-01-07 18:29 ` [PATCH 3/7] Input: wacom - Set driver info for Wacom Penpartner Bastian Blank
2010-01-07 18:29 ` [PATCH 4/7] Input: wacom - Convert remaining ids, part one Bastian Blank
2010-01-07 18:29 ` [PATCH 5/7] Input: wacom - Convert remaining ids, part two Bastian Blank
2010-01-11 21:22 ` Ping Cheng
2010-01-11 22:24 ` Bastian Blank [this message]
2010-02-03 8:47 ` Dmitry Torokhov
[not found] ` <bc07448c1002030634m2c8492a4h9dc1c1ad005bc98f@mail.gmail.com>
2010-02-03 17:28 ` Dmitry Torokhov
2010-01-07 18:30 ` [PATCH 6/7] Imput: wacom - Remove old feature struct setup Bastian Blank
2010-01-07 18:30 ` [PATCH 7/7] Input: wacom - Fail on missing features Bastian Blank
2010-01-07 19:08 ` Dmitry Torokhov
2010-01-07 19:21 ` Bastian Blank
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100111222448.GA7959@wavehammer.waldi.eu.org \
--to=waldi@debian.org \
--cc=dmitry.torokhov@gmail.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=oblivian@users.sourceforge.net \
--cc=pingc@wacom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).