From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: "Hiremath, Vaibhav" <hvaibhav@ti.com>
Cc: "linux-input@vger.kernel.org" <linux-input@vger.kernel.org>,
"linux-omap@vger.kernel.org" <linux-omap@vger.kernel.org>
Subject: Re: [PATCH 2/3] Input:TouchScreen: Introduce TSC2004 driver support
Date: Tue, 12 Jan 2010 00:37:02 -0800 [thread overview]
Message-ID: <20100112083702.GB3252@core.coreip.homeip.net> (raw)
In-Reply-To: <19F8576C6E063C45BE387C64729E7394044A3982AE@dbde02.ent.ti.com>
On Mon, Jan 11, 2010 at 11:54:05AM +0530, Hiremath, Vaibhav wrote:
>
> > -----Original Message-----
> > From: Hiremath, Vaibhav
> > Sent: Thursday, November 19, 2009 8:17 PM
> > To: linux-input@vger.kernel.org
> > Cc: linux-omap@vger.kernel.org; Hiremath, Vaibhav
> > Subject: [PATCH 2/3] Input:TouchScreen: Introduce TSC2004 driver
> > support
> >
> > From: Vaibhav Hiremath <hvaibhav@ti.com>
> >
> > Signed-off-by: Vaibhav Hiremath <hvaibhav@ti.com>
> > ---
> > drivers/input/touchscreen/Kconfig | 11 +
> > drivers/input/touchscreen/Makefile | 1 +
> > drivers/input/touchscreen/tsc2004.c | 525
> > +++++++++++++++++++++++++++++++++++
> > include/linux/i2c/tsc2004.h | 17 ++
> > 4 files changed, 554 insertions(+), 0 deletions(-)
> > create mode 100644 drivers/input/touchscreen/tsc2004.c
> > create mode 100644 include/linux/i2c/tsc2004.h
> >
> [Hiremath, Vaibhav] Dmitry,
>
> Any update on this? This driver support is important for AM3517EVM, can we merge this patch?
>
Hi Hiremath,
I looked over the 2 drivers again and I still think that they are too
much alike to warrant splitting them into 2. The only thing that you
need is provide tsc2004-specific variant of tsc2007_read_values and
add tsc2007-specific variant of tsc2004_prepare_for_reading.
Once the drivers start really diverging we may revisit this issue.
Thanks.
--
Dmitry
next prev parent reply other threads:[~2010-01-12 8:37 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-19 14:46 [PATCH 2/3] Input:TouchScreen: Introduce TSC2004 driver support hvaibhav
2009-11-20 17:02 ` Dmitry Torokhov
2009-11-23 10:15 ` Hiremath, Vaibhav
2010-01-11 6:24 ` Hiremath, Vaibhav
2010-01-12 8:37 ` Dmitry Torokhov [this message]
2010-01-30 10:58 ` Hiremath, Vaibhav
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100112083702.GB3252@core.coreip.homeip.net \
--to=dmitry.torokhov@gmail.com \
--cc=hvaibhav@ti.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).