From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dmitry Torokhov Subject: Re: [PATCH] input: remove BKL from uinput open function Date: Fri, 29 Jan 2010 23:22:05 -0800 Message-ID: <20100130072205.GA30378@core.coreip.homeip.net> References: <1264800197-29523-1-git-send-email-cascardo@holoscopio.com> <201001300741.20954.arnd@arndb.de> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from mail-px0-f182.google.com ([209.85.216.182]:52461 "EHLO mail-px0-f182.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752036Ab0A3HWK (ORCPT ); Sat, 30 Jan 2010 02:22:10 -0500 Content-Disposition: inline In-Reply-To: <201001300741.20954.arnd@arndb.de> Sender: linux-input-owner@vger.kernel.org List-Id: linux-input@vger.kernel.org To: Arnd Bergmann Cc: Thadeu Lima de Souza Cascardo , linux-input@vger.kernel.org, linux-kernel@vger.kernel.org On Sat, Jan 30, 2010 at 07:41:20AM +0100, Arnd Bergmann wrote: > On Friday 29 January 2010, Thadeu Lima de Souza Cascardo wrote: > > Commit 8702965848ed4bee27486a3e3d2ae34ebba6dd83 has push down the BKL > > into uinput open function. However, there's nothing that needs locking > > in there. > > > > Signed-off-by: Thadeu Lima de Souza Cascardo > > The change looks good, but the same driver also uses the BKL in the > default_llseek function. It would be nice to get rid of that in the > same patch, e.g. by adding a ".llseek = generic_file_llseek," line > in the file_operations, or making it call nonseekable_open() if the > driver does not require seek to do anything. > I am afraid you mixed up the drivers, I don't see uinput implementing seek... Thanks. -- Dmitry