From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Alan Jenkins <alan-jenkins@tuffmail.co.uk>
Cc: linux-input@vger.kernel.org, linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] Input: serio - re-add thaw (and add freeze)
Date: Wed, 3 Feb 2010 11:11:12 -0800 [thread overview]
Message-ID: <20100203191112.GC30600@core.coreip.homeip.net> (raw)
In-Reply-To: <4B69C7AA.7000904@tuffmail.co.uk>
On Wed, Feb 03, 2010 at 06:59:54PM +0000, Alan Jenkins wrote:
> 633aae2 "Input: i8042 - switch to using dev_pm_ops"
> removed handling for PMSG_THAW, causing obscure breakage.
>
> It can break if you press keys during hibernation,
> which causes subsequent keypresses to be lost -
> so you can't cancel s2disk by pressing backspace -
> and then just before system poweroff you get
> "psmouse.c: Failed to deactivate mouse".
>
> So let's add the thaw handler back.
>
> Also set the freeze handler. It looks like PMSG_FREEZE
> didn't do anything in the past, but I think that must
> have been an oversight.
We do not need to do anything special at freeze time that is why there
wasn't freeze handler. And so thaw should be pretty much noop as well.
What supports canceling s2disk by backspace? I need more data to figure
out what is going on. At the moment input should be fully-functional
until poweroff.
--
Dmitry
next prev parent reply other threads:[~2010-02-03 19:11 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-03 18:59 [PATCH] Input: serio - re-add thaw (and add freeze) Alan Jenkins
2010-02-03 19:11 ` Dmitry Torokhov [this message]
2010-02-04 10:22 ` Alan Jenkins
2010-02-16 16:48 ` Alan Jenkins
2010-02-16 17:22 ` Dmitry Torokhov
2010-02-25 7:03 ` Pavel Machek
2010-02-25 7:38 ` Dmitry Torokhov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100203191112.GC30600@core.coreip.homeip.net \
--to=dmitry.torokhov@gmail.com \
--cc=alan-jenkins@tuffmail.co.uk \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).