From mboxrd@z Thu Jan 1 00:00:00 1970 From: Pavel Machek Subject: Re: [PATCH] input: mark {corgi,spitz,tosa}kbd driver deprecated Date: Mon, 8 Feb 2010 19:05:08 +0100 Message-ID: <20100208180507.GA1469@ucw.cz> References: Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from atrey.karlin.mff.cuni.cz ([195.113.26.193]:46852 "EHLO atrey.karlin.mff.cuni.cz" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751651Ab0BHSFT (ORCPT ); Mon, 8 Feb 2010 13:05:19 -0500 Content-Disposition: inline In-Reply-To: Sender: linux-input-owner@vger.kernel.org List-Id: linux-input@vger.kernel.org To: Eric Miao Cc: linux-arm-kernel , linux-input@vger.kernel.org, Dmitry Eremin-Solenikov , Richard Purdie Hi! > input: mark {corgi,spitz,tosa}kbd driver deprecated > > Provided that now keyboards on these devices are now fully supported > by generic GPIO based matrix keypad driver, mark these hardcoded, and > difficult to maintain drivers deprecated in favour of this. > > Cc: Richard Purdie > Cc: Dmitry Eremin-Solenikov > Signed-off-by: Eric Miao ACK, but.. > @@ -329,13 +332,16 @@ config KEYBOARD_PXA930_ROTARY > module will be called pxa930_rotary. > > config KEYBOARD_SPITZ > - tristate "Spitz keyboard" > + tristate "Spitz keyboard (deprecated)" > depends on PXA_SHARPSL > default y Default should be N, and config option probably should be removed altogether -- with recent mach_spitz, keyboard_spitz will not be bound to the hw, anyway... right? -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html