From mboxrd@z Thu Jan 1 00:00:00 1970 From: Pavel Machek Subject: Re: sharp c-3000 aka spitz: fix warn_on introduced in 2.6.32-rc1 Date: Fri, 5 Mar 2010 10:23:38 +0100 Message-ID: <20100305092338.GA32433@atrey.karlin.mff.cuni.cz> References: <20100106071026.GD1382@ucw.cz> <20100107065230.GA1303@ucw.cz> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from ksp.mff.cuni.cz ([195.113.26.206]:50606 "EHLO atrey.karlin.mff.cuni.cz" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751924Ab0CEJXj (ORCPT ); Fri, 5 Mar 2010 04:23:39 -0500 Content-Disposition: inline In-Reply-To: Sender: linux-input-owner@vger.kernel.org List-Id: linux-input@vger.kernel.org To: Eric Miao Cc: dtor@mail.ru, linux-input@vger.kernel.org, rpurdie@rpsys.net, lenz@cs.wisc.edu, kernel list , Dirk@opfer-online.de, arminlitzel@web.de, Cyril Hrubis , thommycheck@gmail.com, linux-arm-kernel , dbaryshkov@gmail.com, omegamoon@gmail.com, utx@penguin.cz, zaurus-devel@lists.linuxtogo.org, "Rafael J. Wysocki" , Andrew Morton Hi! > >> > Sharp-SL code uses strange, complex grouping of gpios for wakeups > >> > toggling. Fortunately, it is unneeded in recent kernels (and actually > >> > provokes WARN_ONs during resume). Remove it. > >> > > >> > Signed-off-by: Pavel Machek > >> > >> Pavel, > >> > >> The code to be removed below is used to support pxa27x_keypad > >> to be able to resume from sleep. What's the exact reason to remove > >> this on spitz? > > > > Well, otherwise I get this during resume: (2.6.32 regression) > > > > (and similar for matrix-keypad, but dmitry worked around that > > already). > > > > Problem is that gpio-keys and matrix-keypad want to set_wake for each > > gpio individually, hw can do that, but pxa27x.c breaks it. > > > > I don't get it; what is pxa27x_keypad used on? It looks like > > matrix-keypad subset. > > pxa27x has its own specific keypad controller. And since we now > use enable_irq_wake, and the keypad controller has only one > such IRQ_KEYPAD, will have to setup the keypad GPIO wakeup > as a whole. But pxa27x keypad controlled is not used on spitz, right? So why do we break spitz by tying GPIO wakeup settings together? Pavel -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html