linux-input.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Janusz Krzysztofik <jkrzyszt@tis.icnet.pl>
To: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: "linux-input@vger.kernel.org" <linux-input@vger.kernel.org>,
	"linux-omap@vger.kernel.org" <linux-omap@vger.kernel.org>
Subject: Re: [RFC][PATCH 4/5] input: serio: add support for Amstrad Delta serial keyboard port
Date: Mon, 22 Mar 2010 22:07:47 +0100	[thread overview]
Message-ID: <201003222207.48707.jkrzyszt@tis.icnet.pl> (raw)
In-Reply-To: <200912140111.36458.jkrzyszt@tis.icnet.pl>

(dropping Tony and e3-hacking for now)

Monday 14 December 2009 01:11:34 Janusz Krzysztofik wrote:
> Hi Dmitry,
>
> Sunday 13 December 2009 00:20:03 Dmitry Torokhov napisał(a):
> > atkbd is supposed to support PS/2 devices speaking AT keyboard protocol.
> > We also do support such devices behind dumb controllers that do not
> > allow querying the device but we expect those to at least produce the
> > standard scancodes.
>
> As far as I can understand, using the atkbd driver is not a good idea in
> this case because of the keyboard not producing standard scancodes,
> correct?
>
> Isn't the hpps2atkbd.h provided keycode table an already supported way of
> introducing exceptions to this standard scancodes requirement? Why couldn't
> this method be reused here?
>
> What I am afraid of is if the driver supposed to be created instead
> wouldn't require reiplementing most of the atkbd code.
>
> > I would need to know a bit more about the gamepad, but so far I still
> > think that current attempot of creating intermediate serio module which
> > allows to use atkbd driver is not the proper solution.
>
> I modified the serio driver to send exactly what it gets from the buffer
> and examined its output with serio_raw. The gamepad (can be connected
> simultaneously) appeared to send exactly the same scancodes as the keyboard
> did. I couldn't see how those might be destinguished whether coming from
> the keybord or from the gamepad. Thus, handling them both together as a
> single device would probably be the only option here.
>
> With both devices connected and keys pressed simultaneously, errors occure
> at the lowest level: parity check failed, invalid stop bit, etc. I don't
> think it would be possible to do anything about this. But this also means
> that trying to query them in order to get a sensible response would
> probably be not reliable.
>
> Any thoughts?
>
> Thanks,
> Janusz

Hi Dmitry,

You probably missed my last message.

Meanwhile, I've connected the Amstrad Delta keyboard to a PC. I can confirm it 
speaks PS/2 protocol and is automatically detected by atkbd/i8042 drivers. 
The initial handshake sequence actually looks exactly the same as that of a 
standard AT keyboard. The problem persists about different scancodes, giving 
wrong keystrokes.

OTOH, the Amstrad Delta gamepad seems simplified. Connected alone to a PC, 
works as well but only when i8042.dumbkbd is set. However, when both devices 
are connected in parallel, initial keyboard handshake allows for both being 
used (not simultaneously) in default 2-way i8042 mode.

Resuming, if there were a boot/module option to atkbd allowing for non-default 
scancode table, or another similiar possibility, both devices would work with 
a PC using exsisting drivers.

Even if the chance of anyone using this tiny keyboard with a PC is rather low, 
do you still suggest that creating a new, standalone keyboard driver for it 
is a good idea?

Thanks,
Janusz
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

  parent reply	other threads:[~2010-03-22 21:08 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-12-11  2:36 [RFC][PATCH 4/5] input: serio: add support for Amstrad Delta serial keyboard port Dmitry Torokhov
2009-12-11  3:09 ` Janusz Krzysztofik
2009-12-11  8:01   ` Dmitry Torokhov
2009-12-12 20:34     ` Janusz Krzysztofik
2009-12-12 23:20       ` Dmitry Torokhov
2009-12-14  0:11         ` Janusz Krzysztofik
2009-12-17 15:36           ` [RFC][PATCH 4/5] input: serio: add support forAmstrad " witek mark
2009-12-17 16:37             ` [RFC][PATCH 4/5] input: serio: add supportforAmstrad " witek mark
2010-03-22 21:07           ` Janusz Krzysztofik [this message]
2010-03-24 16:16             ` [RFC][PATCH 4/5] input: serio: add support for Amstrad " Dmitry Torokhov
2010-03-24 21:21               ` Janusz Krzysztofik
2010-03-24 21:29                 ` Dmitry Torokhov
2010-03-25 13:58                   ` Janusz Krzysztofik
  -- strict thread matches above, loose matches on Subject: below --
2009-12-10 19:58 [RFC][PATCH 0/5] omap1: Amstrad Delta: add support for external keyboard Janusz Krzysztofik
2009-12-10 20:07 ` [RFC][PATCH 4/5] input: serio: add support for Amstrad Delta serial keyboard port Janusz Krzysztofik

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201003222207.48707.jkrzyszt@tis.icnet.pl \
    --to=jkrzyszt@tis.icnet.pl \
    --cc=dmitry.torokhov@gmail.com \
    --cc=linux-input@vger.kernel.org \
    --cc=linux-omap@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).