From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: David Herrmann <dh.herrmann@gmail.com>
Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com>,
"open list:HID CORE LAYER" <linux-input@vger.kernel.org>,
"Pierre-Loup A. Griffais" <pgriffais@valvesoftware.com>
Subject: Re: [PATCH 2/7] Input: xpad: set the LEDs properly on XBox Wireless controllers
Date: Mon, 3 Feb 2014 20:48:59 +0100 [thread overview]
Message-ID: <20140203194859.GD3625@kroah.com> (raw)
In-Reply-To: <CANq1E4QS9QVhXOAfogmWt0iQ54n7=HVvjkdE_6a=P2E+wcxD1g@mail.gmail.com>
On Mon, Feb 03, 2014 at 06:31:29PM +0100, David Herrmann wrote:
> Hi
>
> On Fri, Jan 31, 2014 at 2:03 PM, Greg Kroah-Hartman
> <gregkh@linuxfoundation.org> wrote:
> > From: "Pierre-Loup A. Griffais" <pgriffais@valvesoftware.com>
> >
> > Add the logic to set the LEDs on XBox Wireless controllers. Command
> > sequence found by sniffing the Windows data stream when plugging the
> > device in.
> >
> > Signed-off-by: "Pierre-Loup A. Griffais" <pgriffais@valvesoftware.com>
> > Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> > ---
> > drivers/input/joystick/xpad.c | 32 +++++++++++++++++++++++++++-----
> > 1 file changed, 27 insertions(+), 5 deletions(-)
> >
> > diff --git a/drivers/input/joystick/xpad.c b/drivers/input/joystick/xpad.c
> > index 517829f6a58b..aabff9140aaa 100644
> > --- a/drivers/input/joystick/xpad.c
> > +++ b/drivers/input/joystick/xpad.c
> > @@ -715,15 +715,37 @@ struct xpad_led {
> >
> > static void xpad_send_led_command(struct usb_xpad *xpad, int command)
> > {
> > - if (command >= 0 && command < 14) {
> > - mutex_lock(&xpad->odata_mutex);
> > + if (command > 15)
> > + return;
>
> That's really weird. The "command" argument is used to control which
> of the LEDs are enabled, but the underlying led_classdev passes the
> brightness value here. Shouldn't we have one led_classdev device for
> each LED and make "max_brightness"==1 so it's a boolean value?
> I do that for wiimotes so you end up with 4 sysfs entries, one for each LED.
That would make more sense, but would require a userspace daemon to be
setting the LED values. Is there such a thing out there?
I agree the "write a value of 4 and it turns on led 4" does not match
well with the "brightness" file description at all, I don't think that's
good.
> Anyhow, you change "command < 14" to "command > 15" here, is this
> intentional also for the XTYPE_XBOX360 path?
I don't know, Pierre-Loup?
> > +
> > + mutex_lock(&xpad->odata_mutex);
> > +
> > + switch (xpad->xtype) {
> > + case XTYPE_XBOX360:
> > xpad->odata[0] = 0x01;
> > xpad->odata[1] = 0x03;
> > xpad->odata[2] = command;
> > xpad->irq_out->transfer_buffer_length = 3;
> > - usb_submit_urb(xpad->irq_out, GFP_KERNEL);
> > - mutex_unlock(&xpad->odata_mutex);
> > + break;
> > + case XTYPE_XBOX360W:
> > + xpad->odata[0] = 0x00;
> > + xpad->odata[1] = 0x00;
> > + xpad->odata[2] = 0x08;
> > + xpad->odata[3] = 0x40 + (command % 0x0e);
>
> This basically makes /sys/..../led/brightness a "circular" value here.
> Seems weird, but acceptable. But if you bail-out early above with
> "command > 15", this here is equivalent to "command & 0x0e", right?
>
> How about removing the "if (command > 15)" above and make both paths
> use "(command % 0x0e)"? Anyhow, besides changing the XTYPE_XBOX360
> path, patch looks good.
That sounds good, will do.
Many thanks for the review,
greg k-h
next prev parent reply other threads:[~2014-02-03 19:47 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-31 13:03 [PATCH 0/7] Input: xpad: Fix wireless controller connection and leds Greg Kroah-Hartman
2014-01-31 13:03 ` [PATCH 1/7] Input: xpad: use proper endpoint type Greg Kroah-Hartman
2014-01-31 13:03 ` [PATCH 2/7] Input: xpad: set the LEDs properly on XBox Wireless controllers Greg Kroah-Hartman
2014-02-03 17:31 ` David Herrmann
2014-02-03 19:48 ` Greg Kroah-Hartman [this message]
2014-02-03 22:35 ` Pierre-Loup A. Griffais
2014-01-31 13:03 ` [PATCH 3/7] Input: xpad: move the input device creation to a new function Greg Kroah-Hartman
2014-01-31 13:03 ` [PATCH 4/7] Input: xpad: Set the correct LED number Greg Kroah-Hartman
2014-02-03 8:22 ` Greg Kroah-Hartman
2014-01-31 13:03 ` [PATCH 5/7] Input: xpad: disconnect all Wireless controllers at init Greg Kroah-Hartman
2014-02-03 22:22 ` Pierre-Loup A. Griffais
2014-01-31 13:03 ` [PATCH 6/7] Input: xpad: handle "present" and "gone" correctly Greg Kroah-Hartman
2014-02-03 17:37 ` David Herrmann
2014-02-03 19:47 ` Greg Kroah-Hartman
2014-01-31 13:03 ` [PATCH 7/7] Input: xpad: properly name the LED class devices Greg Kroah-Hartman
2014-02-03 17:39 ` David Herrmann
2014-02-03 19:46 ` Greg Kroah-Hartman
2014-02-06 3:11 ` [PATCH 0/7] Input: xpad: Fix wireless controller connection and leds Zachary Lund
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140203194859.GD3625@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=dh.herrmann@gmail.com \
--cc=dmitry.torokhov@gmail.com \
--cc=linux-input@vger.kernel.org \
--cc=pgriffais@valvesoftware.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).