From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D188AC43331 for ; Mon, 11 Nov 2019 19:23:54 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id A6195204EC for ; Mon, 11 Nov 2019 19:23:54 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="nSt1U5kR" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727068AbfKKTXy (ORCPT ); Mon, 11 Nov 2019 14:23:54 -0500 Received: from mail-pl1-f195.google.com ([209.85.214.195]:44832 "EHLO mail-pl1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726927AbfKKTXx (ORCPT ); Mon, 11 Nov 2019 14:23:53 -0500 Received: by mail-pl1-f195.google.com with SMTP id az9so7352766plb.11; Mon, 11 Nov 2019 11:23:53 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=hMyiPGiqfzCIbwdoJWpKshm10Xf96sxNnAB97j+N96w=; b=nSt1U5kR6w9pKa5jHSRtw90WvjxFIDPIzb/lhes4TFCAkccJu00BgrQirXd1mUy3O7 jAhyt61k0QzOa2Tv3tGYXR9ZyQGFQZGU4UFgXFWm2Rga+xKonnl7AUgU93mBAMrLmH4K WNqa7NgudMyPoc3NlG7DMtmM+rIkxzIAd0l1NSGx0o2wlWNR8nJ0heQ4Z7JesD04Rz0q G8kbYpRWvJ66g3Pv7BFBqy2y6s36fevFFN4Rc4XsY+5CFrKdq88/EFPswoGuE8EYyXIy yVOFSe6tQ/t/kQHW5/DsYYbbOWV96eTGBSvqRp/iWYeRGAdcoEfOwqU6W7/6czg8hZm/ eKlg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=hMyiPGiqfzCIbwdoJWpKshm10Xf96sxNnAB97j+N96w=; b=W4uM0JxGnkcf6ZwXnThtWJ6nhYmRvOCFldtTopzW3jUKm+EZ1OKrtldGx9w5v+zEJS B5EGvXqihEP7NefiDKngR1owOI0VRtpsL1sXnTw5xhAZbYsYL5h2Lm70J7fCr4qzwC3K ZE/jONe/Kz9unyTDNAfO7T9kbhQxiIX9wQX/voUfiTONvgWtLKro2oXh7EKkLQ2pCnrK NoTpvDgCrvGbyuuaNKWIbZoZ2BrTNeRCw3nGmbrPsuf39rRozS1x+Mjzvd1XuQYzv+jZ hjQV8Szqt3OJ7z0Gx42OOBFiL8t/as1ntB1I/u4R9Tf5ndiRMrXyv/ML5QqjVQ1oRfLI 3EUA== X-Gm-Message-State: APjAAAXZ930n2NGMru9FBG+SjEQJbkqwRil+kaGCLXeWu3H7vB4AFRER 7lkLdZavFkauyeVFGb+O+lM= X-Google-Smtp-Source: APXvYqyTtZCpDJHF6XZZezNIh/nLSfeRoWevB1Pki8/AGEXRF1ibb539in1lpk6oEvtSpa3opKJdSQ== X-Received: by 2002:a17:902:d88a:: with SMTP id b10mr13822365plz.302.1573500232652; Mon, 11 Nov 2019 11:23:52 -0800 (PST) Received: from dtor-ws ([2620:15c:202:201:3adc:b08c:7acc:b325]) by smtp.gmail.com with ESMTPSA id k9sm17227891pfk.72.2019.11.11.11.23.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 11 Nov 2019 11:23:52 -0800 (PST) Date: Mon, 11 Nov 2019 11:23:49 -0800 From: Dmitry Torokhov To: Enric Balletbo i Serra Cc: Gwendal Grignou , briannorris@chromium.org, jic23@kernel.org, knaack.h@gmx.de, lars@metafoo.de, pmeerw@pmeerw.net, lee.jones@linaro.org, bleung@chromium.org, dianders@chromium.org, groeck@chromium.org, fabien.lahoudere@collabora.com, linux-kernel@vger.kernel.org, linux-iio@vger.kernel.org, linux-input@vger.kernel.org, Dmitry Torokhov Subject: Re: [PATCH v4 08/17] Revert "Input: cros_ec_keyb: mask out extra flags in event_type" Message-ID: <20191111192349.GE57214@dtor-ws> References: <20191105222652.70226-1-gwendal@chromium.org> <20191105222652.70226-9-gwendal@chromium.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-input-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-input@vger.kernel.org On Mon, Nov 11, 2019 at 10:20:41AM +0100, Enric Balletbo i Serra wrote: > Hi, > > cc'in Dmitry and linux-input list which is missing Acked-by: Dmitry Torokhov > > On 5/11/19 23:26, Gwendal Grignou wrote: > > This reverts commit d096aa3eb6045a6a475a0239f3471c59eedf3d61. > > > > This patch is not needed anymore since we clear EC_MKBP_HAS_MORE_EVENTS > > flag before calling the notifiers in patch > > "9d9518f5b52a (platform: chrome: cros_ec: handle MKBP more events flag)" > > > > Signed-off-by: Gwendal Grignou > > --- > > No changes in v4, v3. > > New to v2. > > > > drivers/input/keyboard/cros_ec_keyb.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/input/keyboard/cros_ec_keyb.c b/drivers/input/keyboard/cros_ec_keyb.c > > index a29e81fdf186..2b71c5a51f90 100644 > > --- a/drivers/input/keyboard/cros_ec_keyb.c > > +++ b/drivers/input/keyboard/cros_ec_keyb.c > > @@ -237,7 +237,7 @@ static int cros_ec_keyb_work(struct notifier_block *nb, > > if (queued_during_suspend && !device_may_wakeup(ckdev->dev)) > > return NOTIFY_OK; > > > > - switch (ckdev->ec->event_data.event_type & EC_MKBP_EVENT_TYPE_MASK) { > > + switch (ckdev->ec->event_data.event_type) { > > case EC_MKBP_EVENT_KEY_MATRIX: > > pm_wakeup_event(ckdev->dev, 0); > > > > -- Dmitry