From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.9 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3B535C43215 for ; Fri, 15 Nov 2019 09:51:38 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 11EDF20723 for ; Fri, 15 Nov 2019 09:51:38 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="g+iOhcZr" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727404AbfKOJu3 (ORCPT ); Fri, 15 Nov 2019 04:50:29 -0500 Received: from mail-pg1-f196.google.com ([209.85.215.196]:44630 "EHLO mail-pg1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727349AbfKOJu2 (ORCPT ); Fri, 15 Nov 2019 04:50:28 -0500 Received: by mail-pg1-f196.google.com with SMTP id f19so5713514pgk.11 for ; Fri, 15 Nov 2019 01:50:27 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=00TE3UjkilRir+eBZdBUQADWxjiLoIj6o72iA3B1Sak=; b=g+iOhcZrs7UHvseKUzS7H3Gpvuf+nZBEoWW8rYkkCFWMInk9W59sz0xitzhao5Txsi WrUHfnBCjiQRmDJ3EAACFoIQ78JL3NwHz6QWOXGmrjik1Fex0wwvpOo4JlBeAboBLH5Z O89w7p63Hp9pEwQ3GHEpduv0T3LhEn0JEmdsY= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=00TE3UjkilRir+eBZdBUQADWxjiLoIj6o72iA3B1Sak=; b=ZWUaCGwnm4GxVflxc7HJvBMNdJxtwqxIAJUAAFLtdNYJWvbQx5MMPbWvbHswuPJnxb wJu5bNythTgFbSF79tlABtJBPkwvyyOgaYV/cRA+AZfK9+757bM7Rgfigb0f6m73BZIU 4Y5Tu/2vY9rWZnzZVByUvkI7ICE5TaNWhz+7Dt2+amAL2sDY2HC9fNCa0MyEpyIIv5V/ xJrwemjc57KqiXCWDQjgT+LTy4yOGSr9t3IlC8ZriMZm76NuZLiHILos782Yjw2Tjw15 SRh3WU5rCUkWYIrTPJGPMXfvwoxcubeJMgrwMw8zBjt+vxP3zROfhmdUnFOUid6Ci2yE MrAQ== X-Gm-Message-State: APjAAAX/6P+teVB6JcX8vBoMROIj9o/grRT9JzVG4tm2ZF6rUK3tdYk9 ZQSN17vbZ7KU/vFNPDyfbhgu+w== X-Google-Smtp-Source: APXvYqwSf7X2rW+Bxb5/bsjJWmQV2TgPWw6OX5rnxCqpAbf3+Ggth6PILQOMBFyXwlyMU5+ZUMuJjA== X-Received: by 2002:a63:1f08:: with SMTP id f8mr14240497pgf.145.1573811426996; Fri, 15 Nov 2019 01:50:26 -0800 (PST) Received: from localhost ([2620:15c:202:1:3c8f:512b:3522:dfaf]) by smtp.gmail.com with ESMTPSA id y14sm9792409pff.69.2019.11.15.01.50.26 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 15 Nov 2019 01:50:26 -0800 (PST) From: Gwendal Grignou To: dmitry.torokhov@gmail.com, groeck@chromium.org, briannorris@chromium.org, jic23@kernel.org, knaack.h@gmx.de, lars@metafoo.de, pmeerw@pmeerw.net, lee.jones@linaro.org, bleung@chromium.org, enric.balletbo@collabora.com, dianders@chromium.org, fabien.lahoudere@collabora.com Cc: linux-kernel@vger.kernel.org, linux-iio@vger.kernel.org, linux-input@vger.kernel.org, Gwendal Grignou , Enrico Granata , Jonathan Cameron Subject: [PATCH v5 05/18] platform: chrome: cros_ec: Do not attempt to register a non-positive IRQ number Date: Fri, 15 Nov 2019 01:33:59 -0800 Message-Id: <20191115093412.144922-6-gwendal@chromium.org> X-Mailer: git-send-email 2.24.0.432.g9d3f5f5b63-goog In-Reply-To: <20191115093412.144922-1-gwendal@chromium.org> References: <20191115093412.144922-1-gwendal@chromium.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-input-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-input@vger.kernel.org Add a layer of sanity checking to cros_ec_register against attempting to register IRQ values that are not strictly greater than 0. Signed-off-by: Enrico Granata Signed-off-by: Gwendal Grignou Acked-by: Jonathan Cameron Acked-by: Enric Balletbo i Serra Acked-by: Lee Jones --- No changes in v5, v4, v3. Changes in v2: Remove dual Enrico's signature. drivers/platform/chrome/cros_ec.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/platform/chrome/cros_ec.c b/drivers/platform/chrome/cros_ec.c index 925f84dbf621..d3dfa27171e6 100644 --- a/drivers/platform/chrome/cros_ec.c +++ b/drivers/platform/chrome/cros_ec.c @@ -149,7 +149,7 @@ int cros_ec_register(struct cros_ec_device *ec_dev) return err; } - if (ec_dev->irq) { + if (ec_dev->irq > 0) { err = devm_request_threaded_irq(dev, ec_dev->irq, ec_irq_handler, ec_irq_thread, -- 2.24.0.432.g9d3f5f5b63-goog