linux-input.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Hans Verkuil <hverkuil-cisco@xs4all.nl>
To: linux-media@vger.kernel.org
Cc: linux-input@vger.kernel.org,
	Dmitry Torokhov <dmitry.torokhov@gmail.com>,
	Philipp Zabel <p.zabel@pengutronix.de>,
	Nick Dyer <nick@shmanahar.org>,
	Lucas Stach <l.stach@pengutronix.de>,
	Christopher Heiny <cheiny@synaptics.com>,
	Vandana BN <bnvandana@gmail.com>
Subject: [PATCH 0/5] input: rmi4/synaptics fixes
Date: Tue, 19 Nov 2019 11:51:13 +0100	[thread overview]
Message-ID: <20191119105118.54285-1-hverkuil-cisco@xs4all.nl> (raw)

These are five patches that fix various issues I found when testing
the F54 support of my Lenovo X1 Carbon Gen 6 laptop.

The first three are pretty straightforward. The third patch is a
media documentation fix and, once Acked, it can go in either through
the media subsystem or the input subsystem, whatever is easiest.

The last two patches are more of an RFC quality:

I noticed that irq_find_mapping() could return 0, which causes
a kernel crash. I suspect that this patch just fixes the symptom
and not necessarily the actual cause. I can do more testing to see
if I can find the real cause. Hints of where to look would be
welcome.

The last patch is basically trial-and-error. When testing F54 I noticed
that only the first 32 bytes of the capture image were valid, everything
else was garbage. By deleting the line that increments rmiaddr it suddenly
started working, but I only found an old RMI4 spec and I have no idea
why this fix works.

I can't imagine that it failed when this F54 driver was first added,
so did something else break? Or is my Lenovo special in some way?

I can help with testing, but the https://github.com/ndyer/heatmap/commits/heatmap-v4l
is easy enough to use.

Regards,

	Hans

Hans Verkuil (5):
  input/mouse/synaptics: add LEN0091 support
  input/rmi4/rmi_f54: fix various V4L2 compliance problems
  pixfmt-tch-td16/tu16.rst: document that this is little endian
  input/rmi4/rmi_driver: check if irq_find_mapping returns 0
  input/rmi4/rmi_smbus.c: don't increment rmiaddr in
    rmi_smb_read_block()

 .../media/uapi/v4l/pixfmt-tch-td16.rst        | 34 +++++++++----------
 .../media/uapi/v4l/pixfmt-tch-tu16.rst        | 34 +++++++++----------
 drivers/input/mouse/synaptics.c               |  1 +
 drivers/input/rmi4/rmi_driver.c               |  8 +++--
 drivers/input/rmi4/rmi_f54.c                  | 15 +++++++-
 drivers/input/rmi4/rmi_smbus.c                |  1 -
 6 files changed, 55 insertions(+), 38 deletions(-)

-- 
2.23.0


             reply	other threads:[~2019-11-19 10:51 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-11-19 10:51 Hans Verkuil [this message]
2019-11-19 10:51 ` [PATCH 1/5] input/mouse/synaptics: add LEN0091 support Hans Verkuil
2019-11-23  0:17   ` Dmitry Torokhov
2019-11-19 10:51 ` [PATCH 2/5] input/rmi4/rmi_f54: fix various V4L2 compliance problems Hans Verkuil
2019-11-19 11:42   ` Lucas Stach
2019-11-23  0:19     ` Dmitry Torokhov
2019-11-19 10:51 ` [PATCH 3/5] pixfmt-tch-td16/tu16.rst: document that this is little endian Hans Verkuil
2019-11-23 16:12   ` Hans Verkuil
2019-11-25 18:51     ` Dmitry Torokhov
2019-11-19 10:51 ` [PATCH 4/5] input/rmi4/rmi_driver: check if irq_find_mapping returns 0 Hans Verkuil
2019-11-19 11:38   ` Lucas Stach
2019-11-19 11:43     ` Hans Verkuil
2019-11-23 13:53       ` Hans Verkuil
2019-11-19 10:51 ` [PATCH 5/5] input/rmi4/rmi_smbus.c: don't increment rmiaddr in rmi_smb_read_block() Hans Verkuil
2019-11-19 11:48   ` Lucas Stach
2019-11-19 12:19     ` Hans Verkuil
2019-11-23 16:27   ` [PATCHv2 5/5] input/rmi4/rmi_smbus.c: don't increment rmiaddr Hans Verkuil
2019-12-02 18:09     ` Dmitry Torokhov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191119105118.54285-1-hverkuil-cisco@xs4all.nl \
    --to=hverkuil-cisco@xs4all.nl \
    --cc=bnvandana@gmail.com \
    --cc=cheiny@synaptics.com \
    --cc=dmitry.torokhov@gmail.com \
    --cc=l.stach@pengutronix.de \
    --cc=linux-input@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=nick@shmanahar.org \
    --cc=p.zabel@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).