From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.4 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7F10EC432C0 for ; Thu, 21 Nov 2019 16:33:17 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 4F83B20692 for ; Thu, 21 Nov 2019 16:33:17 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=kroah.com header.i=@kroah.com header.b="b3374WAE"; dkim=pass (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b="rx8RIxy5" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726690AbfKUQdQ (ORCPT ); Thu, 21 Nov 2019 11:33:16 -0500 Received: from new4-smtp.messagingengine.com ([66.111.4.230]:35629 "EHLO new4-smtp.messagingengine.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726293AbfKUQdQ (ORCPT ); Thu, 21 Nov 2019 11:33:16 -0500 Received: from compute6.internal (compute6.nyi.internal [10.202.2.46]) by mailnew.nyi.internal (Postfix) with ESMTP id 8BD475306; Thu, 21 Nov 2019 11:33:14 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute6.internal (MEProxy); Thu, 21 Nov 2019 11:33:14 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kroah.com; h= date:from:to:cc:subject:message-id:references:mime-version :content-type:in-reply-to; s=fm2; bh=nHWHTDLVdOX1uKKYN8BXRNsJUsY isZ2RlAbvZf+iPwU=; b=b3374WAEob5A+fRL+rZ+069sr+JtdUKxgKB/ToCBPRL r3dZ5ayl7aXJWzmP3MUbfp0+sP87QtczbOMsyFzLSk+Yl5tLrnnBuxLzUINt0Wui T1n00awDYzQU5pWmeo9nIPXI3cbBMvKZNSwbtJYN/N6oIpWl5ZJXS7YZO2VzbLvY RtLlYFjEDtty+lEE/5ndz3j4bMfPOG0xAIRxQdAInTLYxHnH24MK++2jOiN2KnyE gcTfCp52z4mqkiXg9LC0FKO3Q/GXJLxa6DwtWBG+bHoZhM5K3uUs1m5nOT69nhtF SQXranVQ8oLWOU1RpbewPv3Hl3UD60YdhKdpwP2M8eQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=nHWHTD LVdOX1uKKYN8BXRNsJUsYisZ2RlAbvZf+iPwU=; b=rx8RIxy5FU8XfaUY3DEDwz wFN5FnToTX9OiZCMr1cSXv8uzPMZox+KlAk8KymZjv7a28nF+hnwGeBWl8g7sW4v uF0ylic0iT/Zv906gdK+ZDary5J1VHXiDt/lrOTgWtV1ZeDEqCUxG9WM6yyl1ZcF eIFKH0CPQ9AuOO404pMZ4cHclhV/6r/Tn1036KEkRV+zffdSICLVmAIOHvc3HH3p KKGHjHianpJBI6ornp+KIRpZ8kYrzhHQCu6mgXajr/kgQ4S1O1zZxeVkUG8PzlVn k8QdOvWg1h2/tsHIjZlbXCv08ZS7TIt5MqYc5tBWK+zngpgBwNNP3GHoWkcO2Tew == X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedufedrudehvddgledvucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucenucfjughrpeffhffvuffkfhggtggujggfsehttd ertddtredvnecuhfhrohhmpefirhgvghcumffjuceoghhrvghgsehkrhhorghhrdgtohhm qeenucfkphepvddujedrieekrdegledrjedvnecurfgrrhgrmhepmhgrihhlfhhrohhmpe hgrhgvgheskhhrohgrhhdrtghomhenucevlhhushhtvghrufhiiigvpedt X-ME-Proxy: Received: from localhost (unknown [217.68.49.72]) by mail.messagingengine.com (Postfix) with ESMTPA id 830958005C; Thu, 21 Nov 2019 11:33:12 -0500 (EST) Date: Thu, 21 Nov 2019 17:33:09 +0100 From: Greg KH To: "Enrico Weigelt, metux IT consult" Cc: linux-kernel@vger.kernel.org, jikos@kernel.org, benjamin.tissoires@redhat.com, dmitry.torokhov@gmail.com, Jes.Sorensen@gmail.com, kvalo@codeaurora.org, johan@kernel.org, linux-input@vger.kernel.org, linux-wireless@vger.kernel.org, netdev@vger.kernel.org, linux-usb@vger.kernel.org Subject: Re: [PATCH] drivers: usb: consolidate USB vendor IDs in one include file Message-ID: <20191121163309.GA651886@kroah.com> References: <20191121161742.31435-1-info@metux.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20191121161742.31435-1-info@metux.net> User-Agent: Mutt/1.12.2 (2019-09-21) Sender: linux-input-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-input@vger.kernel.org On Thu, Nov 21, 2019 at 05:17:42PM +0100, Enrico Weigelt, metux IT consult wrote: > Instead of redefining usb vendor IDs in several places, consolidate > into one include file: include/linux/usb/usb_ids.h No, please no. There's a specific reason we do not have this, unlike other operating systems. It's because merges are a pain, and touching the "big one file" ends up rebuilding too many things. Read the top of the pci-ids.h file for why I do not want to see us do this for any other type of id. It's best to leave them where they are used, right in the driver itself. thanks, greg k-h