From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: "Enrico Weigelt, metux IT consult" <info@metux.net>
Cc: linux-kernel@vger.kernel.org, linux-input@vger.kernel.org
Subject: Re: [PATCH] input: misc: Kconfig: use select instead of depends on KEYBOARD_GPIO
Date: Fri, 22 Nov 2019 11:58:10 -0800 [thread overview]
Message-ID: <20191122195810.GD248138@dtor-ws> (raw)
In-Reply-To: <20191121132046.11977-1-info@metux.net>
On Thu, Nov 21, 2019 at 02:20:46PM +0100, Enrico Weigelt, metux IT consult wrote:
> From: Enrico Weigelt <info@metux.net>
>
> Make selection of the driver a bit easier by replacing depends on
> KEYBOARD_GPIO by select, so we don't need to enable KEYBOARD_GPIO
> before being able to enable INPUT_SOC_BUTTON_ARRAY.
>
> Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
> ---
> drivers/input/misc/Kconfig | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/input/misc/Kconfig b/drivers/input/misc/Kconfig
> index 7d9ae394e597..99d263177d8d 100644
> --- a/drivers/input/misc/Kconfig
> +++ b/drivers/input/misc/Kconfig
> @@ -813,7 +813,8 @@ config INPUT_IDEAPAD_SLIDEBAR
>
> config INPUT_SOC_BUTTON_ARRAY
> tristate "Windows-compatible SoC Button Array"
> - depends on KEYBOARD_GPIO && ACPI
> + depends on ACPI
> + select KEYBOARD_GPIO
KEYBOARD_GPIO depends on GPIOLIB and "select" does not propagate
dependencies, so you may still end up with invalid configs...
Thanks.
--
Dmitry
next prev parent reply other threads:[~2019-11-22 19:58 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-21 13:20 [PATCH] input: misc: Kconfig: use select instead of depends on KEYBOARD_GPIO Enrico Weigelt, metux IT consult
2019-11-22 19:58 ` Dmitry Torokhov [this message]
2019-11-28 13:03 ` Enrico Weigelt, metux IT consult
2019-12-02 18:27 ` Dmitry Torokhov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191122195810.GD248138@dtor-ws \
--to=dmitry.torokhov@gmail.com \
--cc=info@metux.net \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).