From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Lyude Paul <lyude@redhat.com>
Cc: linux-input@vger.kernel.org, stable@vger.kernel.org,
"Benjamin Tissoires" <benjamin.tissoires@redhat.com>,
"Mantas Mikulėnas" <grawity@gmail.com>,
"Nick Black" <dankamongmen@gmail.com>,
"Yussuf Khalil" <dev@pp3345.net>,
"Christophe JAILLET" <christophe.jaillet@wanadoo.fr>,
"Alexander Mikhaylenko" <exalm7659@gmail.com>,
"Thomas Gleixner" <tglx@linutronix.de>,
"Joe Perches" <joe@perches.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Revert "Input: synaptics - enable RMI mode for X1 Extreme 2nd Generation"
Date: Mon, 25 Nov 2019 10:52:11 -0800 [thread overview]
Message-ID: <20191125185211.GJ248138@dtor-ws> (raw)
In-Reply-To: <20191119234534.10725-1-lyude@redhat.com>
On Tue, Nov 19, 2019 at 06:45:33PM -0500, Lyude Paul wrote:
> This reverts commit 68b9c5066e39af41d3448abfc887c77ce22dd64d.
>
> Ugh, I really dropped the ball on this one :\. So as it turns out RMI4
> works perfectly fine on the X1 Extreme Gen 2 except for one thing I
> didn't notice because I usually use the trackpoint: clicking with the
> touchpad. Somehow this is broken, in fact we don't even seem to indicate
> BTN_LEFT as a valid event type for the RMI4 touchpad. And, I don't even
> see any RMI4 events coming from the touchpad when I press down on it.
> This only seems to work for PS/2 mode.
>
> Since that means we have a regression, and PS/2 mode seems to work fine
> for the time being - revert this for now. We'll have to do a more
> thorough investigation on this.
>
> Signed-off-by: Lyude Paul <lyude@redhat.com>
> Cc: stable@vger.kernel.org
This has been applied, thank you.
--
Dmitry
prev parent reply other threads:[~2019-11-25 18:52 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-19 23:45 [PATCH] Revert "Input: synaptics - enable RMI mode for X1 Extreme 2nd Generation" Lyude Paul
2019-11-25 18:52 ` Dmitry Torokhov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191125185211.GJ248138@dtor-ws \
--to=dmitry.torokhov@gmail.com \
--cc=benjamin.tissoires@redhat.com \
--cc=christophe.jaillet@wanadoo.fr \
--cc=dankamongmen@gmail.com \
--cc=dev@pp3345.net \
--cc=exalm7659@gmail.com \
--cc=grawity@gmail.com \
--cc=joe@perches.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lyude@redhat.com \
--cc=stable@vger.kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).