Linux Input Archive on lore.kernel.org
 help / color / Atom feed
* [PATCH] Revert "Input: synaptics - enable RMI mode for X1 Extreme 2nd Generation"
@ 2019-11-19 23:45 Lyude Paul
  2019-11-25 18:52 ` Dmitry Torokhov
  0 siblings, 1 reply; 2+ messages in thread
From: Lyude Paul @ 2019-11-19 23:45 UTC (permalink / raw)
  To: linux-input
  Cc: stable, Dmitry Torokhov, Benjamin Tissoires,
	Mantas Mikulėnas, Nick Black, Yussuf Khalil,
	Christophe JAILLET, Alexander Mikhaylenko, Thomas Gleixner,
	Joe Perches, linux-kernel

This reverts commit 68b9c5066e39af41d3448abfc887c77ce22dd64d.

Ugh, I really dropped the ball on this one :\. So as it turns out RMI4
works perfectly fine on the X1 Extreme Gen 2 except for one thing I
didn't notice because I usually use the trackpoint: clicking with the
touchpad. Somehow this is broken, in fact we don't even seem to indicate
BTN_LEFT as a valid event type for the RMI4 touchpad. And, I don't even
see any RMI4 events coming from the touchpad when I press down on it.
This only seems to work for PS/2 mode.

Since that means we have a regression, and PS/2 mode seems to work fine
for the time being - revert this for now. We'll have to do a more
thorough investigation on this.

Signed-off-by: Lyude Paul <lyude@redhat.com>
Cc: stable@vger.kernel.org
---
 drivers/input/mouse/synaptics.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/input/mouse/synaptics.c b/drivers/input/mouse/synaptics.c
index 704558d449a2..56fae3472114 100644
--- a/drivers/input/mouse/synaptics.c
+++ b/drivers/input/mouse/synaptics.c
@@ -177,7 +177,6 @@ static const char * const smbus_pnp_ids[] = {
 	"LEN0096", /* X280 */
 	"LEN0097", /* X280 -> ALPS trackpoint */
 	"LEN009b", /* T580 */
-	"LEN0402", /* X1 Extreme 2nd Generation */
 	"LEN200f", /* T450s */
 	"LEN2054", /* E480 */
 	"LEN2055", /* E580 */
-- 
2.21.0


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] Revert "Input: synaptics - enable RMI mode for X1 Extreme 2nd Generation"
  2019-11-19 23:45 [PATCH] Revert "Input: synaptics - enable RMI mode for X1 Extreme 2nd Generation" Lyude Paul
@ 2019-11-25 18:52 ` Dmitry Torokhov
  0 siblings, 0 replies; 2+ messages in thread
From: Dmitry Torokhov @ 2019-11-25 18:52 UTC (permalink / raw)
  To: Lyude Paul
  Cc: linux-input, stable, Benjamin Tissoires, Mantas Mikulėnas,
	Nick Black, Yussuf Khalil, Christophe JAILLET,
	Alexander Mikhaylenko, Thomas Gleixner, Joe Perches,
	linux-kernel

On Tue, Nov 19, 2019 at 06:45:33PM -0500, Lyude Paul wrote:
> This reverts commit 68b9c5066e39af41d3448abfc887c77ce22dd64d.
> 
> Ugh, I really dropped the ball on this one :\. So as it turns out RMI4
> works perfectly fine on the X1 Extreme Gen 2 except for one thing I
> didn't notice because I usually use the trackpoint: clicking with the
> touchpad. Somehow this is broken, in fact we don't even seem to indicate
> BTN_LEFT as a valid event type for the RMI4 touchpad. And, I don't even
> see any RMI4 events coming from the touchpad when I press down on it.
> This only seems to work for PS/2 mode.
> 
> Since that means we have a regression, and PS/2 mode seems to work fine
> for the time being - revert this for now. We'll have to do a more
> thorough investigation on this.
> 
> Signed-off-by: Lyude Paul <lyude@redhat.com>
> Cc: stable@vger.kernel.org

This has been applied, thank you.

-- 
Dmitry

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, back to index

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-11-19 23:45 [PATCH] Revert "Input: synaptics - enable RMI mode for X1 Extreme 2nd Generation" Lyude Paul
2019-11-25 18:52 ` Dmitry Torokhov

Linux Input Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-input/0 linux-input/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-input linux-input/ https://lore.kernel.org/linux-input \
		linux-input@vger.kernel.org
	public-inbox-index linux-input

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-input


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git