Linux Input Archive on lore.kernel.org
 help / color / Atom feed
* [PATCH v2 00/14] video, drm, etc: constify fbops in struct fb_info
@ 2019-11-29 10:29 Jani Nikula
  2019-11-29 10:29 ` [PATCH v2 11/14] HID: picoLCD: constify fb ops Jani Nikula
  2019-11-29 15:40 ` [PATCH v2 00/14] video, drm, etc: constify fbops in struct fb_info Daniel Vetter
  0 siblings, 2 replies; 5+ messages in thread
From: Jani Nikula @ 2019-11-29 10:29 UTC (permalink / raw)
  To: dri-devel, linux-fbdev
  Cc: intel-gfx, jani.nikula, ville.syrjala, Andy Walls,
	Bernie Thompson, Bruno Prémont, Daniel Vetter, Hans Verkuil,
	Jaya Kumar, Kirti Wankhede, Miguel Ojeda Sandonis,
	Noralf Trønnes, Robin van der Gracht, Steve Glendinning,
	ivtv-devel, kvm, linux-input, linux-media, linux-omap

This is v2 of https://patchwork.freedesktop.org/series/70119/

I wanted to make our struct fb_ops const because we don't modify
it... and this is what I ended up with to fix it and a bunch of others.

I would appreciate acks to merge all this via the drm-misc tree. This is
especially important for patches 1-8 to reasonably get the job
done. Patches 9-14 are somewhat easier to merge at leisure afterwards,
but there really isn't much conflict potential IMO.

Daniel, please double-check me adding your Reviewed-by on the later
patches wasn't overzealous.

BR,
Jani.


Cc: Andy Walls <awalls@md.metrocast.net>
Cc: Bernie Thompson <bernie@plugable.com>
Cc: Bruno Prémont <bonbons@linux-vserver.org>
Cc: Daniel Vetter <daniel@ffwll.ch>
Cc: Hans Verkuil <hverkuil@xs4all.nl>
Cc: Jaya Kumar <jayalk@intworks.biz>
Cc: Kirti Wankhede <kwankhede@nvidia.com>
Cc: Miguel Ojeda Sandonis <miguel.ojeda.sandonis@gmail.com>
Cc: Noralf Trønnes <noralf@tronnes.org>
Cc: Robin van der Gracht <robin@protonic.nl>
Cc: Steve Glendinning <steve.glendinning@shawell.net>
Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
Cc: dri-devel@lists.freedesktop.org
Cc: ivtv-devel@ivtvdriver.org
Cc: kvm@vger.kernel.org
Cc: linux-fbdev@vger.kernel.org
Cc: linux-input@vger.kernel.org
Cc: linux-media@vger.kernel.org
Cc: linux-omap@vger.kernel.org


Jani Nikula (14):
  video: fb_defio: preserve user fb_ops
  drm/fb-helper: don't preserve fb_ops across deferred IO use
  video: smscufx: don't restore fb_mmap after deferred IO cleanup
  video: udlfb: don't restore fb_mmap after deferred IO cleanup
  video: fbdev: vesafb: modify the static fb_ops directly
  video: fbmem: use const pointer for fb_ops
  video: omapfb: use const pointer for fb_ops
  video: fbdev: make fbops member of struct fb_info a const pointer
  drm: constify fb ops across all drivers
  video: constify fb ops across all drivers
  HID: picoLCD: constify fb ops
  media: constify fb ops across all drivers
  samples: vfio-mdev: constify fb ops
  auxdisplay: constify fb ops

 drivers/auxdisplay/cfag12864bfb.c             |  2 +-
 drivers/auxdisplay/ht16k33.c                  |  2 +-
 drivers/gpu/drm/amd/amdgpu/amdgpu_fb.c        |  2 +-
 drivers/gpu/drm/armada/armada_fbdev.c         |  2 +-
 drivers/gpu/drm/drm_fb_helper.c               | 27 +++----------------
 drivers/gpu/drm/exynos/exynos_drm_fbdev.c     |  2 +-
 .../gpu/drm/hisilicon/hibmc/hibmc_drm_fbdev.c |  2 +-
 drivers/gpu/drm/i915/display/intel_fbdev.c    |  2 +-
 drivers/gpu/drm/msm/msm_fbdev.c               |  2 +-
 drivers/gpu/drm/nouveau/nouveau_fbcon.c       |  4 +--
 drivers/gpu/drm/omapdrm/omap_fbdev.c          |  2 +-
 drivers/gpu/drm/radeon/radeon_fb.c            |  2 +-
 drivers/gpu/drm/rockchip/rockchip_drm_fbdev.c |  2 +-
 drivers/gpu/drm/tegra/fb.c                    |  2 +-
 drivers/gpu/drm/vmwgfx/vmwgfx_fb.c            |  2 +-
 drivers/hid/hid-picolcd_fb.c                  |  3 +--
 drivers/media/pci/ivtv/ivtvfb.c               |  3 +--
 drivers/media/platform/vivid/vivid-osd.c      |  3 +--
 drivers/video/fbdev/68328fb.c                 |  2 +-
 drivers/video/fbdev/acornfb.c                 |  2 +-
 drivers/video/fbdev/amba-clcd.c               |  2 +-
 drivers/video/fbdev/amifb.c                   |  2 +-
 drivers/video/fbdev/arcfb.c                   |  2 +-
 drivers/video/fbdev/arkfb.c                   |  2 +-
 drivers/video/fbdev/asiliantfb.c              |  2 +-
 drivers/video/fbdev/atmel_lcdfb.c             |  2 +-
 drivers/video/fbdev/aty/aty128fb.c            |  2 +-
 drivers/video/fbdev/aty/atyfb_base.c          |  2 +-
 drivers/video/fbdev/aty/radeon_base.c         |  2 +-
 drivers/video/fbdev/au1100fb.c                |  2 +-
 drivers/video/fbdev/au1200fb.c                |  2 +-
 drivers/video/fbdev/broadsheetfb.c            |  2 +-
 drivers/video/fbdev/bw2.c                     |  2 +-
 drivers/video/fbdev/carminefb.c               |  2 +-
 drivers/video/fbdev/cg14.c                    |  2 +-
 drivers/video/fbdev/cg3.c                     |  2 +-
 drivers/video/fbdev/cg6.c                     |  2 +-
 drivers/video/fbdev/chipsfb.c                 |  2 +-
 drivers/video/fbdev/cirrusfb.c                |  2 +-
 drivers/video/fbdev/clps711x-fb.c             |  2 +-
 drivers/video/fbdev/cobalt_lcdfb.c            |  2 +-
 drivers/video/fbdev/controlfb.c               |  2 +-
 drivers/video/fbdev/core/fb_defio.c           |  3 ---
 drivers/video/fbdev/core/fbmem.c              | 19 ++++++++-----
 drivers/video/fbdev/cyber2000fb.c             |  2 +-
 drivers/video/fbdev/da8xx-fb.c                |  2 +-
 drivers/video/fbdev/dnfb.c                    |  2 +-
 drivers/video/fbdev/efifb.c                   |  2 +-
 drivers/video/fbdev/ep93xx-fb.c               |  2 +-
 drivers/video/fbdev/fb-puv3.c                 |  2 +-
 drivers/video/fbdev/ffb.c                     |  2 +-
 drivers/video/fbdev/fm2fb.c                   |  2 +-
 drivers/video/fbdev/fsl-diu-fb.c              |  2 +-
 drivers/video/fbdev/g364fb.c                  |  2 +-
 drivers/video/fbdev/gbefb.c                   |  2 +-
 drivers/video/fbdev/geode/gx1fb_core.c        |  2 +-
 drivers/video/fbdev/geode/gxfb_core.c         |  2 +-
 drivers/video/fbdev/geode/lxfb_core.c         |  2 +-
 drivers/video/fbdev/goldfishfb.c              |  2 +-
 drivers/video/fbdev/grvga.c                   |  2 +-
 drivers/video/fbdev/gxt4500.c                 |  2 +-
 drivers/video/fbdev/hecubafb.c                |  2 +-
 drivers/video/fbdev/hgafb.c                   |  2 +-
 drivers/video/fbdev/hitfb.c                   |  2 +-
 drivers/video/fbdev/hpfb.c                    |  2 +-
 drivers/video/fbdev/hyperv_fb.c               |  2 +-
 drivers/video/fbdev/i740fb.c                  |  2 +-
 drivers/video/fbdev/imsttfb.c                 |  2 +-
 drivers/video/fbdev/imxfb.c                   |  2 +-
 drivers/video/fbdev/intelfb/intelfbdrv.c      |  2 +-
 drivers/video/fbdev/kyro/fbdev.c              |  2 +-
 drivers/video/fbdev/leo.c                     |  2 +-
 drivers/video/fbdev/macfb.c                   |  2 +-
 drivers/video/fbdev/matrox/matroxfb_crtc2.c   |  2 +-
 drivers/video/fbdev/maxinefb.c                |  2 +-
 drivers/video/fbdev/mb862xx/mb862xxfbdrv.c    |  2 +-
 drivers/video/fbdev/mbx/mbxfb.c               |  2 +-
 drivers/video/fbdev/metronomefb.c             |  2 +-
 drivers/video/fbdev/mmp/fb/mmpfb.c            |  2 +-
 drivers/video/fbdev/mx3fb.c                   |  5 ++--
 drivers/video/fbdev/neofb.c                   |  2 +-
 drivers/video/fbdev/nvidia/nvidia.c           |  2 +-
 drivers/video/fbdev/ocfb.c                    |  2 +-
 drivers/video/fbdev/offb.c                    |  2 +-
 drivers/video/fbdev/omap/omapfb_main.c        |  2 +-
 .../video/fbdev/omap2/omapfb/omapfb-main.c    |  2 +-
 drivers/video/fbdev/p9100.c                   |  2 +-
 drivers/video/fbdev/platinumfb.c              |  2 +-
 drivers/video/fbdev/pm2fb.c                   |  2 +-
 drivers/video/fbdev/pm3fb.c                   |  2 +-
 drivers/video/fbdev/pmag-aa-fb.c              |  2 +-
 drivers/video/fbdev/pmag-ba-fb.c              |  2 +-
 drivers/video/fbdev/pmagb-b-fb.c              |  2 +-
 drivers/video/fbdev/ps3fb.c                   |  2 +-
 drivers/video/fbdev/pvr2fb.c                  |  2 +-
 drivers/video/fbdev/pxa168fb.c                |  2 +-
 drivers/video/fbdev/pxafb.c                   |  4 +--
 drivers/video/fbdev/q40fb.c                   |  2 +-
 drivers/video/fbdev/riva/fbdev.c              |  2 +-
 drivers/video/fbdev/s3c-fb.c                  |  2 +-
 drivers/video/fbdev/s3c2410fb.c               |  2 +-
 drivers/video/fbdev/s3fb.c                    |  2 +-
 drivers/video/fbdev/sa1100fb.c                |  2 +-
 drivers/video/fbdev/savage/savagefb_driver.c  |  2 +-
 drivers/video/fbdev/sh7760fb.c                |  2 +-
 drivers/video/fbdev/sh_mobile_lcdcfb.c        |  4 +--
 drivers/video/fbdev/simplefb.c                |  2 +-
 drivers/video/fbdev/sis/sis_main.c            |  2 +-
 drivers/video/fbdev/skeletonfb.c              |  2 +-
 drivers/video/fbdev/sm712fb.c                 |  2 +-
 drivers/video/fbdev/smscufx.c                 |  3 +--
 drivers/video/fbdev/ssd1307fb.c               |  2 +-
 drivers/video/fbdev/sstfb.c                   |  2 +-
 drivers/video/fbdev/stifb.c                   |  2 +-
 drivers/video/fbdev/sunxvr1000.c              |  2 +-
 drivers/video/fbdev/sunxvr2500.c              |  2 +-
 drivers/video/fbdev/sunxvr500.c               |  2 +-
 drivers/video/fbdev/tcx.c                     |  2 +-
 drivers/video/fbdev/tdfxfb.c                  |  2 +-
 drivers/video/fbdev/tgafb.c                   |  2 +-
 drivers/video/fbdev/tmiofb.c                  |  2 +-
 drivers/video/fbdev/tridentfb.c               |  2 +-
 drivers/video/fbdev/udlfb.c                   |  1 -
 drivers/video/fbdev/uvesafb.c                 |  2 +-
 drivers/video/fbdev/valkyriefb.c              |  2 +-
 drivers/video/fbdev/vesafb.c                  |  6 ++---
 drivers/video/fbdev/vfb.c                     |  2 +-
 drivers/video/fbdev/vga16fb.c                 |  2 +-
 drivers/video/fbdev/vt8500lcdfb.c             |  2 +-
 drivers/video/fbdev/vt8623fb.c                |  2 +-
 drivers/video/fbdev/w100fb.c                  |  2 +-
 drivers/video/fbdev/wm8505fb.c                |  2 +-
 drivers/video/fbdev/xen-fbfront.c             |  2 +-
 drivers/video/fbdev/xilinxfb.c                |  2 +-
 include/linux/fb.h                            |  2 +-
 samples/vfio-mdev/mdpy-fb.c                   |  2 +-
 136 files changed, 156 insertions(+), 175 deletions(-)

-- 
2.20.1


^ permalink raw reply	[flat|nested] 5+ messages in thread

* [PATCH v2 11/14] HID: picoLCD: constify fb ops
  2019-11-29 10:29 [PATCH v2 00/14] video, drm, etc: constify fbops in struct fb_info Jani Nikula
@ 2019-11-29 10:29 ` Jani Nikula
  2019-12-02  8:40   ` Bruno Prémont
  2019-11-29 15:40 ` [PATCH v2 00/14] video, drm, etc: constify fbops in struct fb_info Daniel Vetter
  1 sibling, 1 reply; 5+ messages in thread
From: Jani Nikula @ 2019-11-29 10:29 UTC (permalink / raw)
  To: dri-devel, linux-fbdev
  Cc: intel-gfx, jani.nikula, ville.syrjala, Bruno Prémont,
	linux-input, Daniel Vetter

Now that the fbops member of struct fb_info is const, we can start
making the ops const as well.

v2: fix	typo (Christophe de Dinechin)

Cc: Bruno Prémont <bonbons@linux-vserver.org>
Cc: linux-input@vger.kernel.org
Reviewed-by: Daniel Vetter <daniel.vetter@ffwll.ch>
Signed-off-by: Jani Nikula <jani.nikula@intel.com>
---
 drivers/hid/hid-picolcd_fb.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/hid/hid-picolcd_fb.c b/drivers/hid/hid-picolcd_fb.c
index e162a668fb7e..a549c42e8c90 100644
--- a/drivers/hid/hid-picolcd_fb.c
+++ b/drivers/hid/hid-picolcd_fb.c
@@ -417,8 +417,7 @@ static int picolcd_set_par(struct fb_info *info)
 	return 0;
 }
 
-/* Note this can't be const because of struct fb_info definition */
-static struct fb_ops picolcdfb_ops = {
+static const struct fb_ops picolcdfb_ops = {
 	.owner        = THIS_MODULE,
 	.fb_destroy   = picolcd_fb_destroy,
 	.fb_read      = fb_sys_read,
-- 
2.20.1


^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH v2 00/14] video, drm, etc: constify fbops in struct fb_info
  2019-11-29 10:29 [PATCH v2 00/14] video, drm, etc: constify fbops in struct fb_info Jani Nikula
  2019-11-29 10:29 ` [PATCH v2 11/14] HID: picoLCD: constify fb ops Jani Nikula
@ 2019-11-29 15:40 ` Daniel Vetter
  1 sibling, 0 replies; 5+ messages in thread
From: Daniel Vetter @ 2019-11-29 15:40 UTC (permalink / raw)
  To: Jani Nikula
  Cc: dri-devel, linux-fbdev, intel-gfx, ville.syrjala, Andy Walls,
	Bernie Thompson, Bruno Prémont, Daniel Vetter, Hans Verkuil,
	Jaya Kumar, Kirti Wankhede, Miguel Ojeda Sandonis,
	Noralf Trønnes, Robin van der Gracht, Steve Glendinning,
	ivtv-devel, kvm, linux-input, linux-media, linux-omap

On Fri, Nov 29, 2019 at 12:29:30PM +0200, Jani Nikula wrote:
> This is v2 of https://patchwork.freedesktop.org/series/70119/
> 
> I wanted to make our struct fb_ops const because we don't modify
> it... and this is what I ended up with to fix it and a bunch of others.
> 
> I would appreciate acks to merge all this via the drm-misc tree. This is
> especially important for patches 1-8 to reasonably get the job
> done. Patches 9-14 are somewhat easier to merge at leisure afterwards,
> but there really isn't much conflict potential IMO.

Only patches 11-14 need acks, drivers/video is already officially
maintained in drm-misc.

> Daniel, please double-check me adding your Reviewed-by on the later
> patches wasn't overzealous.

Yeah, looks all neat&tidy.
-Daniel

> 
> BR,
> Jani.
> 
> 
> Cc: Andy Walls <awalls@md.metrocast.net>
> Cc: Bernie Thompson <bernie@plugable.com>
> Cc: Bruno Prémont <bonbons@linux-vserver.org>
> Cc: Daniel Vetter <daniel@ffwll.ch>
> Cc: Hans Verkuil <hverkuil@xs4all.nl>
> Cc: Jaya Kumar <jayalk@intworks.biz>
> Cc: Kirti Wankhede <kwankhede@nvidia.com>
> Cc: Miguel Ojeda Sandonis <miguel.ojeda.sandonis@gmail.com>
> Cc: Noralf Trønnes <noralf@tronnes.org>
> Cc: Robin van der Gracht <robin@protonic.nl>
> Cc: Steve Glendinning <steve.glendinning@shawell.net>
> Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
> Cc: dri-devel@lists.freedesktop.org
> Cc: ivtv-devel@ivtvdriver.org
> Cc: kvm@vger.kernel.org
> Cc: linux-fbdev@vger.kernel.org
> Cc: linux-input@vger.kernel.org
> Cc: linux-media@vger.kernel.org
> Cc: linux-omap@vger.kernel.org
> 
> 
> Jani Nikula (14):
>   video: fb_defio: preserve user fb_ops
>   drm/fb-helper: don't preserve fb_ops across deferred IO use
>   video: smscufx: don't restore fb_mmap after deferred IO cleanup
>   video: udlfb: don't restore fb_mmap after deferred IO cleanup
>   video: fbdev: vesafb: modify the static fb_ops directly
>   video: fbmem: use const pointer for fb_ops
>   video: omapfb: use const pointer for fb_ops
>   video: fbdev: make fbops member of struct fb_info a const pointer
>   drm: constify fb ops across all drivers
>   video: constify fb ops across all drivers
>   HID: picoLCD: constify fb ops
>   media: constify fb ops across all drivers
>   samples: vfio-mdev: constify fb ops
>   auxdisplay: constify fb ops
> 
>  drivers/auxdisplay/cfag12864bfb.c             |  2 +-
>  drivers/auxdisplay/ht16k33.c                  |  2 +-
>  drivers/gpu/drm/amd/amdgpu/amdgpu_fb.c        |  2 +-
>  drivers/gpu/drm/armada/armada_fbdev.c         |  2 +-
>  drivers/gpu/drm/drm_fb_helper.c               | 27 +++----------------
>  drivers/gpu/drm/exynos/exynos_drm_fbdev.c     |  2 +-
>  .../gpu/drm/hisilicon/hibmc/hibmc_drm_fbdev.c |  2 +-
>  drivers/gpu/drm/i915/display/intel_fbdev.c    |  2 +-
>  drivers/gpu/drm/msm/msm_fbdev.c               |  2 +-
>  drivers/gpu/drm/nouveau/nouveau_fbcon.c       |  4 +--
>  drivers/gpu/drm/omapdrm/omap_fbdev.c          |  2 +-
>  drivers/gpu/drm/radeon/radeon_fb.c            |  2 +-
>  drivers/gpu/drm/rockchip/rockchip_drm_fbdev.c |  2 +-
>  drivers/gpu/drm/tegra/fb.c                    |  2 +-
>  drivers/gpu/drm/vmwgfx/vmwgfx_fb.c            |  2 +-
>  drivers/hid/hid-picolcd_fb.c                  |  3 +--
>  drivers/media/pci/ivtv/ivtvfb.c               |  3 +--
>  drivers/media/platform/vivid/vivid-osd.c      |  3 +--
>  drivers/video/fbdev/68328fb.c                 |  2 +-
>  drivers/video/fbdev/acornfb.c                 |  2 +-
>  drivers/video/fbdev/amba-clcd.c               |  2 +-
>  drivers/video/fbdev/amifb.c                   |  2 +-
>  drivers/video/fbdev/arcfb.c                   |  2 +-
>  drivers/video/fbdev/arkfb.c                   |  2 +-
>  drivers/video/fbdev/asiliantfb.c              |  2 +-
>  drivers/video/fbdev/atmel_lcdfb.c             |  2 +-
>  drivers/video/fbdev/aty/aty128fb.c            |  2 +-
>  drivers/video/fbdev/aty/atyfb_base.c          |  2 +-
>  drivers/video/fbdev/aty/radeon_base.c         |  2 +-
>  drivers/video/fbdev/au1100fb.c                |  2 +-
>  drivers/video/fbdev/au1200fb.c                |  2 +-
>  drivers/video/fbdev/broadsheetfb.c            |  2 +-
>  drivers/video/fbdev/bw2.c                     |  2 +-
>  drivers/video/fbdev/carminefb.c               |  2 +-
>  drivers/video/fbdev/cg14.c                    |  2 +-
>  drivers/video/fbdev/cg3.c                     |  2 +-
>  drivers/video/fbdev/cg6.c                     |  2 +-
>  drivers/video/fbdev/chipsfb.c                 |  2 +-
>  drivers/video/fbdev/cirrusfb.c                |  2 +-
>  drivers/video/fbdev/clps711x-fb.c             |  2 +-
>  drivers/video/fbdev/cobalt_lcdfb.c            |  2 +-
>  drivers/video/fbdev/controlfb.c               |  2 +-
>  drivers/video/fbdev/core/fb_defio.c           |  3 ---
>  drivers/video/fbdev/core/fbmem.c              | 19 ++++++++-----
>  drivers/video/fbdev/cyber2000fb.c             |  2 +-
>  drivers/video/fbdev/da8xx-fb.c                |  2 +-
>  drivers/video/fbdev/dnfb.c                    |  2 +-
>  drivers/video/fbdev/efifb.c                   |  2 +-
>  drivers/video/fbdev/ep93xx-fb.c               |  2 +-
>  drivers/video/fbdev/fb-puv3.c                 |  2 +-
>  drivers/video/fbdev/ffb.c                     |  2 +-
>  drivers/video/fbdev/fm2fb.c                   |  2 +-
>  drivers/video/fbdev/fsl-diu-fb.c              |  2 +-
>  drivers/video/fbdev/g364fb.c                  |  2 +-
>  drivers/video/fbdev/gbefb.c                   |  2 +-
>  drivers/video/fbdev/geode/gx1fb_core.c        |  2 +-
>  drivers/video/fbdev/geode/gxfb_core.c         |  2 +-
>  drivers/video/fbdev/geode/lxfb_core.c         |  2 +-
>  drivers/video/fbdev/goldfishfb.c              |  2 +-
>  drivers/video/fbdev/grvga.c                   |  2 +-
>  drivers/video/fbdev/gxt4500.c                 |  2 +-
>  drivers/video/fbdev/hecubafb.c                |  2 +-
>  drivers/video/fbdev/hgafb.c                   |  2 +-
>  drivers/video/fbdev/hitfb.c                   |  2 +-
>  drivers/video/fbdev/hpfb.c                    |  2 +-
>  drivers/video/fbdev/hyperv_fb.c               |  2 +-
>  drivers/video/fbdev/i740fb.c                  |  2 +-
>  drivers/video/fbdev/imsttfb.c                 |  2 +-
>  drivers/video/fbdev/imxfb.c                   |  2 +-
>  drivers/video/fbdev/intelfb/intelfbdrv.c      |  2 +-
>  drivers/video/fbdev/kyro/fbdev.c              |  2 +-
>  drivers/video/fbdev/leo.c                     |  2 +-
>  drivers/video/fbdev/macfb.c                   |  2 +-
>  drivers/video/fbdev/matrox/matroxfb_crtc2.c   |  2 +-
>  drivers/video/fbdev/maxinefb.c                |  2 +-
>  drivers/video/fbdev/mb862xx/mb862xxfbdrv.c    |  2 +-
>  drivers/video/fbdev/mbx/mbxfb.c               |  2 +-
>  drivers/video/fbdev/metronomefb.c             |  2 +-
>  drivers/video/fbdev/mmp/fb/mmpfb.c            |  2 +-
>  drivers/video/fbdev/mx3fb.c                   |  5 ++--
>  drivers/video/fbdev/neofb.c                   |  2 +-
>  drivers/video/fbdev/nvidia/nvidia.c           |  2 +-
>  drivers/video/fbdev/ocfb.c                    |  2 +-
>  drivers/video/fbdev/offb.c                    |  2 +-
>  drivers/video/fbdev/omap/omapfb_main.c        |  2 +-
>  .../video/fbdev/omap2/omapfb/omapfb-main.c    |  2 +-
>  drivers/video/fbdev/p9100.c                   |  2 +-
>  drivers/video/fbdev/platinumfb.c              |  2 +-
>  drivers/video/fbdev/pm2fb.c                   |  2 +-
>  drivers/video/fbdev/pm3fb.c                   |  2 +-
>  drivers/video/fbdev/pmag-aa-fb.c              |  2 +-
>  drivers/video/fbdev/pmag-ba-fb.c              |  2 +-
>  drivers/video/fbdev/pmagb-b-fb.c              |  2 +-
>  drivers/video/fbdev/ps3fb.c                   |  2 +-
>  drivers/video/fbdev/pvr2fb.c                  |  2 +-
>  drivers/video/fbdev/pxa168fb.c                |  2 +-
>  drivers/video/fbdev/pxafb.c                   |  4 +--
>  drivers/video/fbdev/q40fb.c                   |  2 +-
>  drivers/video/fbdev/riva/fbdev.c              |  2 +-
>  drivers/video/fbdev/s3c-fb.c                  |  2 +-
>  drivers/video/fbdev/s3c2410fb.c               |  2 +-
>  drivers/video/fbdev/s3fb.c                    |  2 +-
>  drivers/video/fbdev/sa1100fb.c                |  2 +-
>  drivers/video/fbdev/savage/savagefb_driver.c  |  2 +-
>  drivers/video/fbdev/sh7760fb.c                |  2 +-
>  drivers/video/fbdev/sh_mobile_lcdcfb.c        |  4 +--
>  drivers/video/fbdev/simplefb.c                |  2 +-
>  drivers/video/fbdev/sis/sis_main.c            |  2 +-
>  drivers/video/fbdev/skeletonfb.c              |  2 +-
>  drivers/video/fbdev/sm712fb.c                 |  2 +-
>  drivers/video/fbdev/smscufx.c                 |  3 +--
>  drivers/video/fbdev/ssd1307fb.c               |  2 +-
>  drivers/video/fbdev/sstfb.c                   |  2 +-
>  drivers/video/fbdev/stifb.c                   |  2 +-
>  drivers/video/fbdev/sunxvr1000.c              |  2 +-
>  drivers/video/fbdev/sunxvr2500.c              |  2 +-
>  drivers/video/fbdev/sunxvr500.c               |  2 +-
>  drivers/video/fbdev/tcx.c                     |  2 +-
>  drivers/video/fbdev/tdfxfb.c                  |  2 +-
>  drivers/video/fbdev/tgafb.c                   |  2 +-
>  drivers/video/fbdev/tmiofb.c                  |  2 +-
>  drivers/video/fbdev/tridentfb.c               |  2 +-
>  drivers/video/fbdev/udlfb.c                   |  1 -
>  drivers/video/fbdev/uvesafb.c                 |  2 +-
>  drivers/video/fbdev/valkyriefb.c              |  2 +-
>  drivers/video/fbdev/vesafb.c                  |  6 ++---
>  drivers/video/fbdev/vfb.c                     |  2 +-
>  drivers/video/fbdev/vga16fb.c                 |  2 +-
>  drivers/video/fbdev/vt8500lcdfb.c             |  2 +-
>  drivers/video/fbdev/vt8623fb.c                |  2 +-
>  drivers/video/fbdev/w100fb.c                  |  2 +-
>  drivers/video/fbdev/wm8505fb.c                |  2 +-
>  drivers/video/fbdev/xen-fbfront.c             |  2 +-
>  drivers/video/fbdev/xilinxfb.c                |  2 +-
>  include/linux/fb.h                            |  2 +-
>  samples/vfio-mdev/mdpy-fb.c                   |  2 +-
>  136 files changed, 156 insertions(+), 175 deletions(-)
> 
> -- 
> 2.20.1
> 

-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH v2 11/14] HID: picoLCD: constify fb ops
  2019-11-29 10:29 ` [PATCH v2 11/14] HID: picoLCD: constify fb ops Jani Nikula
@ 2019-12-02  8:40   ` Bruno Prémont
  2019-12-05  9:38     ` Jani Nikula
  0 siblings, 1 reply; 5+ messages in thread
From: Bruno Prémont @ 2019-12-02  8:40 UTC (permalink / raw)
  To: Jani Nikula
  Cc: dri-devel, linux-fbdev, intel-gfx, ville.syrjala, linux-input,
	Daniel Vetter, Jiri Kosina

Hi Jani,

On Fri, 29 Nov 2019 12:29:41 Jani Nikula <jani.nikula@intel.com> wrote:
> Now that the fbops member of struct fb_info is const, we can start
> making the ops const as well.
>
> v2: fix	typo (Christophe de Dinechin)

Fine with me.
I don't think going through drm-misc would trigger any conflict, but
adding Jiri to CC for the case there was any preference.

Acked-by: Bruno Prémont <bonbons@linux-vserver.org>

> Cc: Bruno Prémont <bonbons@linux-vserver.org>
> Cc: linux-input@vger.kernel.org
> Reviewed-by: Daniel Vetter <daniel.vetter@ffwll.ch>
> Signed-off-by: Jani Nikula <jani.nikula@intel.com>
> ---
>  drivers/hid/hid-picolcd_fb.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/drivers/hid/hid-picolcd_fb.c b/drivers/hid/hid-picolcd_fb.c
> index e162a668fb7e..a549c42e8c90 100644
> --- a/drivers/hid/hid-picolcd_fb.c
> +++ b/drivers/hid/hid-picolcd_fb.c
> @@ -417,8 +417,7 @@ static int picolcd_set_par(struct fb_info *info)
>  	return 0;
>  }
>  
> -/* Note this can't be const because of struct fb_info definition */
> -static struct fb_ops picolcdfb_ops = {
> +static const struct fb_ops picolcdfb_ops = {
>  	.owner        = THIS_MODULE,
>  	.fb_destroy   = picolcd_fb_destroy,
>  	.fb_read      = fb_sys_read,


^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH v2 11/14] HID: picoLCD: constify fb ops
  2019-12-02  8:40   ` Bruno Prémont
@ 2019-12-05  9:38     ` Jani Nikula
  0 siblings, 0 replies; 5+ messages in thread
From: Jani Nikula @ 2019-12-05  9:38 UTC (permalink / raw)
  To: Bruno Prémont
  Cc: dri-devel, linux-fbdev, intel-gfx, ville.syrjala, linux-input,
	Daniel Vetter, Jiri Kosina

On Mon, 02 Dec 2019, Bruno Prémont <bonbons@linux-vserver.org> wrote:
> Hi Jani,
>
> On Fri, 29 Nov 2019 12:29:41 Jani Nikula <jani.nikula@intel.com> wrote:
>> Now that the fbops member of struct fb_info is const, we can start
>> making the ops const as well.
>>
>> v2: fix	typo (Christophe de Dinechin)
>
> Fine with me.
> I don't think going through drm-misc would trigger any conflict, but
> adding Jiri to CC for the case there was any preference.
>
> Acked-by: Bruno Prémont <bonbons@linux-vserver.org>

No response, may I proceed with merging this through drm-misc please?

BR,
Jani.

>
>> Cc: Bruno Prémont <bonbons@linux-vserver.org>
>> Cc: linux-input@vger.kernel.org
>> Reviewed-by: Daniel Vetter <daniel.vetter@ffwll.ch>
>> Signed-off-by: Jani Nikula <jani.nikula@intel.com>
>> ---
>>  drivers/hid/hid-picolcd_fb.c | 3 +--
>>  1 file changed, 1 insertion(+), 2 deletions(-)
>> 
>> diff --git a/drivers/hid/hid-picolcd_fb.c b/drivers/hid/hid-picolcd_fb.c
>> index e162a668fb7e..a549c42e8c90 100644
>> --- a/drivers/hid/hid-picolcd_fb.c
>> +++ b/drivers/hid/hid-picolcd_fb.c
>> @@ -417,8 +417,7 @@ static int picolcd_set_par(struct fb_info *info)
>>  	return 0;
>>  }
>>  
>> -/* Note this can't be const because of struct fb_info definition */
>> -static struct fb_ops picolcdfb_ops = {
>> +static const struct fb_ops picolcdfb_ops = {
>>  	.owner        = THIS_MODULE,
>>  	.fb_destroy   = picolcd_fb_destroy,
>>  	.fb_read      = fb_sys_read,
>

-- 
Jani Nikula, Intel Open Source Graphics Center

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, back to index

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-11-29 10:29 [PATCH v2 00/14] video, drm, etc: constify fbops in struct fb_info Jani Nikula
2019-11-29 10:29 ` [PATCH v2 11/14] HID: picoLCD: constify fb ops Jani Nikula
2019-12-02  8:40   ` Bruno Prémont
2019-12-05  9:38     ` Jani Nikula
2019-11-29 15:40 ` [PATCH v2 00/14] video, drm, etc: constify fbops in struct fb_info Daniel Vetter

Linux Input Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-input/0 linux-input/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-input linux-input/ https://lore.kernel.org/linux-input \
		linux-input@vger.kernel.org
	public-inbox-index linux-input

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-input


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git