From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CBEBBC432C0 for ; Mon, 2 Dec 2019 08:49:20 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 9994A218AC for ; Mon, 2 Dec 2019 08:49:20 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725977AbfLBItU convert rfc822-to-8bit (ORCPT ); Mon, 2 Dec 2019 03:49:20 -0500 Received: from hygieia.sysophe.eu ([138.201.91.14]:42623 "EHLO hygieia.sysophe.eu" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726106AbfLBItU (ORCPT ); Mon, 2 Dec 2019 03:49:20 -0500 X-Greylist: delayed 504 seconds by postgrey-1.27 at vger.kernel.org; Mon, 02 Dec 2019 03:49:19 EST Received: from aether.lan.sysophe.eu (unknown [IPv6:2001:a18:24b:8201:e8b:fdff:fea0:3408]) by smtp.sysophe.eu (Postfix) with ESMTPSA id B0DE6103DF1E1; Mon, 2 Dec 2019 09:35:27 +0100 (CET) Date: Mon, 2 Dec 2019 09:40:47 +0100 From: Bruno =?UTF-8?B?UHLDqW1vbnQ=?= To: Jani Nikula Cc: dri-devel@lists.freedesktop.org, linux-fbdev@vger.kernel.org, intel-gfx@lists.freedesktop.org, ville.syrjala@linux.intel.com, linux-input@vger.kernel.org, Daniel Vetter , Jiri Kosina Subject: Re: [PATCH v2 11/14] HID: picoLCD: constify fb ops Message-ID: <20191202094047.34525a7d@aether.lan.sysophe.eu> In-Reply-To: <8678a9a3566279c881bb4db944850eef35d0a4bb.1575022735.git.jani.nikula@intel.com> References: <8678a9a3566279c881bb4db944850eef35d0a4bb.1575022735.git.jani.nikula@intel.com> X-Mailer: Claws Mail 3.17.4git3 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Sender: linux-input-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-input@vger.kernel.org Hi Jani, On Fri, 29 Nov 2019 12:29:41 Jani Nikula wrote: > Now that the fbops member of struct fb_info is const, we can start > making the ops const as well. > > v2: fix typo (Christophe de Dinechin) Fine with me. I don't think going through drm-misc would trigger any conflict, but adding Jiri to CC for the case there was any preference. Acked-by: Bruno Prémont > Cc: Bruno Prémont > Cc: linux-input@vger.kernel.org > Reviewed-by: Daniel Vetter > Signed-off-by: Jani Nikula > --- > drivers/hid/hid-picolcd_fb.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/hid/hid-picolcd_fb.c b/drivers/hid/hid-picolcd_fb.c > index e162a668fb7e..a549c42e8c90 100644 > --- a/drivers/hid/hid-picolcd_fb.c > +++ b/drivers/hid/hid-picolcd_fb.c > @@ -417,8 +417,7 @@ static int picolcd_set_par(struct fb_info *info) > return 0; > } > > -/* Note this can't be const because of struct fb_info definition */ > -static struct fb_ops picolcdfb_ops = { > +static const struct fb_ops picolcdfb_ops = { > .owner = THIS_MODULE, > .fb_destroy = picolcd_fb_destroy, > .fb_read = fb_sys_read,