Linux Input Archive on lore.kernel.org
 help / color / Atom feed
* [PATCH] input: misc: Kconfig: use select instead of depends on KEYBOARD_GPIO
@ 2019-11-21 13:20 Enrico Weigelt, metux IT consult
  2019-11-22 19:58 ` Dmitry Torokhov
  0 siblings, 1 reply; 4+ messages in thread
From: Enrico Weigelt, metux IT consult @ 2019-11-21 13:20 UTC (permalink / raw)
  To: linux-kernel; +Cc: dmitry.torokhov, linux-input

From: Enrico Weigelt <info@metux.net>

Make selection of the driver a bit easier by replacing depends on
KEYBOARD_GPIO by select, so we don't need to enable KEYBOARD_GPIO
before being able to enable INPUT_SOC_BUTTON_ARRAY.

Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
---
 drivers/input/misc/Kconfig | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/input/misc/Kconfig b/drivers/input/misc/Kconfig
index 7d9ae394e597..99d263177d8d 100644
--- a/drivers/input/misc/Kconfig
+++ b/drivers/input/misc/Kconfig
@@ -813,7 +813,8 @@ config INPUT_IDEAPAD_SLIDEBAR
 
 config INPUT_SOC_BUTTON_ARRAY
 	tristate "Windows-compatible SoC Button Array"
-	depends on KEYBOARD_GPIO && ACPI
+	depends on ACPI
+	select KEYBOARD_GPIO
 	help
 	  Say Y here if you have a SoC-based tablet that originally runs
 	  Windows 8 or a Microsoft Surface Book 2, Pro 5, Laptop 1 or later.
-- 
2.11.0


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] input: misc: Kconfig: use select instead of depends on KEYBOARD_GPIO
  2019-11-21 13:20 [PATCH] input: misc: Kconfig: use select instead of depends on KEYBOARD_GPIO Enrico Weigelt, metux IT consult
@ 2019-11-22 19:58 ` Dmitry Torokhov
  2019-11-28 13:03   ` Enrico Weigelt, metux IT consult
  0 siblings, 1 reply; 4+ messages in thread
From: Dmitry Torokhov @ 2019-11-22 19:58 UTC (permalink / raw)
  To: Enrico Weigelt, metux IT consult; +Cc: linux-kernel, linux-input

On Thu, Nov 21, 2019 at 02:20:46PM +0100, Enrico Weigelt, metux IT consult wrote:
> From: Enrico Weigelt <info@metux.net>
> 
> Make selection of the driver a bit easier by replacing depends on
> KEYBOARD_GPIO by select, so we don't need to enable KEYBOARD_GPIO
> before being able to enable INPUT_SOC_BUTTON_ARRAY.
> 
> Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
> ---
>  drivers/input/misc/Kconfig | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/input/misc/Kconfig b/drivers/input/misc/Kconfig
> index 7d9ae394e597..99d263177d8d 100644
> --- a/drivers/input/misc/Kconfig
> +++ b/drivers/input/misc/Kconfig
> @@ -813,7 +813,8 @@ config INPUT_IDEAPAD_SLIDEBAR
>  
>  config INPUT_SOC_BUTTON_ARRAY
>  	tristate "Windows-compatible SoC Button Array"
> -	depends on KEYBOARD_GPIO && ACPI
> +	depends on ACPI
> +	select KEYBOARD_GPIO

KEYBOARD_GPIO depends on GPIOLIB and "select" does not propagate
dependencies, so you may still end up with invalid configs...

Thanks.

-- 
Dmitry

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] input: misc: Kconfig: use select instead of depends on KEYBOARD_GPIO
  2019-11-22 19:58 ` Dmitry Torokhov
@ 2019-11-28 13:03   ` Enrico Weigelt, metux IT consult
  2019-12-02 18:27     ` Dmitry Torokhov
  0 siblings, 1 reply; 4+ messages in thread
From: Enrico Weigelt, metux IT consult @ 2019-11-28 13:03 UTC (permalink / raw)
  To: Dmitry Torokhov, Enrico Weigelt, metux IT consult
  Cc: linux-kernel, linux-input

On 22.11.19 20:58, Dmitry Torokhov wrote:

> KEYBOARD_GPIO depends on GPIOLIB and "select" does not propagate
> dependencies, so you may still end up with invalid configs...

Sure that they don't propagate ? In this case, I've got yet
another todo ... :o


--mtx

-- 
Dringender Hinweis: aufgrund existenzieller Bedrohung durch "Emotet"
sollten Sie *niemals* MS-Office-Dokumente via E-Mail annehmen/öffenen,
selbst wenn diese von vermeintlich vertrauenswürdigen Absendern zu
stammen scheinen. Andernfalls droht Totalschaden.
---
Hinweis: unverschlüsselte E-Mails können leicht abgehört und manipuliert
werden ! Für eine vertrauliche Kommunikation senden Sie bitte ihren
GPG/PGP-Schlüssel zu.
---
Enrico Weigelt, metux IT consult
Free software and Linux embedded engineering
info@metux.net -- +49-151-27565287

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] input: misc: Kconfig: use select instead of depends on KEYBOARD_GPIO
  2019-11-28 13:03   ` Enrico Weigelt, metux IT consult
@ 2019-12-02 18:27     ` Dmitry Torokhov
  0 siblings, 0 replies; 4+ messages in thread
From: Dmitry Torokhov @ 2019-12-02 18:27 UTC (permalink / raw)
  To: Enrico Weigelt, metux IT consult
  Cc: Enrico Weigelt, metux IT consult, linux-kernel, linux-input

On Thu, Nov 28, 2019 at 02:03:40PM +0100, Enrico Weigelt, metux IT consult wrote:
> On 22.11.19 20:58, Dmitry Torokhov wrote:
> 
> > KEYBOARD_GPIO depends on GPIOLIB and "select" does not propagate
> > dependencies, so you may still end up with invalid configs...
> 
> Sure that they don't propagate ? In this case, I've got yet
> another todo ... :o

Yes, I am sure.

-- 
Dmitry

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, back to index

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-11-21 13:20 [PATCH] input: misc: Kconfig: use select instead of depends on KEYBOARD_GPIO Enrico Weigelt, metux IT consult
2019-11-22 19:58 ` Dmitry Torokhov
2019-11-28 13:03   ` Enrico Weigelt, metux IT consult
2019-12-02 18:27     ` Dmitry Torokhov

Linux Input Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-input/0 linux-input/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-input linux-input/ https://lore.kernel.org/linux-input \
		linux-input@vger.kernel.org
	public-inbox-index linux-input

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-input


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git