From: Stephan Gerhold <stephan@gerhold.net>
To: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: Andi Shyti <andi@etezian.org>,
Linux Input <linux-input@vger.kernel.org>,
Seung-Woo Kim <sw0312.kim@samsung.com>,
Joonyoung Shim <jy0922.shim@samsung.com>
Subject: Re: [PATCH v2 1/2] Input: mms114 - use smbus functions whenever possible
Date: Wed, 4 Dec 2019 17:47:37 +0100 [thread overview]
Message-ID: <20191204164737.GA2426@gerhold.net> (raw)
In-Reply-To: <20191118133229.GA182934@gerhold.net>
Hi Dmitry,
On Mon, Nov 18, 2019 at 02:32:36PM +0100, Stephan Gerhold wrote:
> Hi Dmitry,
>
> On Tue, Oct 22, 2019 at 02:18:39PM +0300, Andi Shyti wrote:
> > Hi Dmitry,
> >
> > > If regmap is too much work then as a stop gap we could maybe only
> > > convert write functions and mention why read needs to be custom.
> >
> > regmap is not too much work but I don't have the device with me,
> > I might get one at some point, but can't do anything right now.
> >
> > Perhaps, for now you can take Stephan's patches and I would
> > update everything once I get the device. They are not mutually
> > exclusive, anyway.
>
> What do you think about this?
>
> My patches for MMS345L keep behavior for MMS114 and MMS152 as-is,
> so we can be sure that there are no regressions for them.
>
> Cleaning up the driver to use SMBUS and/or regmap instead of the custom
> read/write methods is definitely something we should attempt to do
> at some point, but only when we can properly test them on MMS114.
>
> Until we have a MMS114 test device available, I would say that
> applying my patches is the least intrusive way to make MMS345L work.
>
I would really like to find a solution for this.
If it helps, I can re-send my patches for MMS345L (although they still
apply cleanly...). Let me know what you would prefer!
Thanks,
Stephan
next prev parent reply other threads:[~2019-12-04 16:50 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-20 20:28 [PATCH v2 0/2] Use smbus functions to communicate through i2c Andi Shyti
2019-10-20 20:28 ` [PATCH v2 1/2] Input: mms114 - use smbus functions whenever possible Andi Shyti
2019-10-21 9:34 ` Stephan Gerhold
2019-10-21 15:41 ` Andi Shyti
2019-10-21 16:26 ` Stephan Gerhold
2019-10-21 16:39 ` Andi Shyti
2019-10-22 3:21 ` Dmitry Torokhov
2019-10-22 11:18 ` Andi Shyti
2019-11-18 13:32 ` Stephan Gerhold
2019-12-04 16:47 ` Stephan Gerhold [this message]
2019-10-20 20:28 ` [PATCH v2 2/2] Input: mms114 - get read of custm i2c read/write functions Andi Shyti
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191204164737.GA2426@gerhold.net \
--to=stephan@gerhold.net \
--cc=andi@etezian.org \
--cc=dmitry.torokhov@gmail.com \
--cc=jy0922.shim@samsung.com \
--cc=linux-input@vger.kernel.org \
--cc=sw0312.kim@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).