From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_2 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9C782C33C8C for ; Sun, 5 Jan 2020 10:36:32 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 6E9F6217F4 for ; Sun, 5 Jan 2020 10:36:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1578220592; bh=+/iStnPwhP542628pOw3mMn8MnVqED4tQzXbzXKLjX0=; h=Date:From:To:Cc:Subject:In-Reply-To:References:List-ID:From; b=kflu+MbMk8S0vGnz4dUF0ZAXrpHmkq/tM6ynKG5f+ywjQisgtl00oV/Y2UmIC/M+P E60+fp3ixnt7f0A55cgIW+eeCodHqEzGwLUoTTfb+90Nrsm7ZdiBUhfkid+hmlKwLv 8ejQ2doZicnwdKQagZB2jtBLtOUNNT5U3DRgLCJw= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725938AbgAEKgb (ORCPT ); Sun, 5 Jan 2020 05:36:31 -0500 Received: from mail.kernel.org ([198.145.29.99]:40718 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725897AbgAEKgb (ORCPT ); Sun, 5 Jan 2020 05:36:31 -0500 Received: from archlinux (cpc149474-cmbg20-2-0-cust94.5-4.cable.virginm.net [82.4.196.95]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 9FCD520866; Sun, 5 Jan 2020 10:36:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1578220590; bh=+/iStnPwhP542628pOw3mMn8MnVqED4tQzXbzXKLjX0=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=jgdrO4luZGTN4hh/Bi100t2Ifh8xx+Dfu9snipBpGBvIvFPoD0jqTHFFrmD69mjyN oghPX5cKXINRXRzZi++u6fnogFn8k18nEvesM/YIo6oNZ8tHaJC8VrOFMWRhgk/PnD TG9Jw6rjP60YdIsHGQr7N+JAxul5X7yXoCZHflVQ= Date: Sun, 5 Jan 2020 10:36:24 +0000 From: Jonathan Cameron To: Dmitry Torokhov Cc: Linus Walleij , linux-iio@vger.kernel.org, Hartmut Knaack , Lars-Peter Clausen , Peter Meerwald-Stadler , linux-input@vger.kernel.org, Stephan Gerhold , Donggeun Kim , Minkyu Kang , =?UTF-8?B?UGF3ZcWC?= Chmiel , Jonathan Bakker , Oskar Andero Subject: Re: [PATCH 2/2 v1] iio: light: Add a driver for Sharp GP2AP002x00F Message-ID: <20200105103624.07b3820c@archlinux> In-Reply-To: <20200102221533.GC8314@dtor-ws> References: <20191228201109.13635-1-linus.walleij@linaro.org> <20191228201109.13635-2-linus.walleij@linaro.org> <20191230173919.373f4e8a@archlinux> <20200102221533.GC8314@dtor-ws> X-Mailer: Claws Mail 3.17.4 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-input-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-input@vger.kernel.org On Thu, 2 Jan 2020 14:15:33 -0800 Dmitry Torokhov wrote: > Hi Jonathan, > > On Mon, Dec 30, 2019 at 05:39:19PM +0000, Jonathan Cameron wrote: > > On Sat, 28 Dec 2019 21:11:09 +0100 > > Linus Walleij wrote: > > > > > + /* Enable chip and IRQ, disable analog sleep */ > > > + ret = regmap_write(gp2ap002->map, GP2AP002_OPMOD, > > > + OPMOD_SSD_OPERATING | OPMOD_VCON_IRQ); > > > + if (ret < 0) { > > > + dev_err(gp2ap002->dev, "error setting up operation mode\n"); > > > + return ret; > > > + } > > > + > > > + /* Interrupt on VOUT enabled */ > > > + ret = regmap_write(gp2ap002->map, GP2AP002_CON, CON_OCON_ENABLE); > > > + if (ret < 0) { > > > + dev_err(gp2ap002->dev, "error setting up VOUT control\n"); > > > + return ret; > > > > drop this return ret out of the brackets as it's either 0 or negative anyway. > > Not my subsystem, but $0.02 anyways: I like calling the temp as "error" > and explicitly return 0 in the success path even if it could be > collapsed, as you can easily add more initialization without needing > to go and alter previous blocks. That's a perfectly valid method as long as ret is only ever an error (or good). We've tended to go with ret in IIO, so better to carry on with that. I'm not that fussed about dropping the return ret; out, but definitely prefer explicit if (ret) to make it clear ret is never positive in the good path though. Thanks, Jonathan > > Thanks. >