From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B2EDCC282DD for ; Fri, 10 Jan 2020 01:02:25 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 7D3442077B for ; Fri, 10 Jan 2020 01:02:25 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="IFJX/VWV" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730392AbgAJBCY (ORCPT ); Thu, 9 Jan 2020 20:02:24 -0500 Received: from mail-pg1-f182.google.com ([209.85.215.182]:38154 "EHLO mail-pg1-f182.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730301AbgAJBCY (ORCPT ); Thu, 9 Jan 2020 20:02:24 -0500 Received: by mail-pg1-f182.google.com with SMTP id a33so153144pgm.5 for ; Thu, 09 Jan 2020 17:02:24 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=YZr4NhFK9VRmzHURoHp19dmXt5FyLGLjyf944Yq+Z50=; b=IFJX/VWVGtOfrf6yqgxmEyEXjpeEVtlQDfv86Q3vm6EHmZYRl86713MBA9t0Fz/vkx ahRCdXctreMYIt6oTJodRsVupKmRwapM7FEDMMtZJCjPjMZDahLrYVgeU8DFsa3gOj6E YE1X7JkhkamDbom+J3LKvj4YbjesmpkKa0UdN4hhlaqBFVbiaAAeS0aqNTsvq65FhzGg 8LOaGnNFYhNbTipd+npuzUPp5FQhygq9aAV8te6U++cLBsV/uIXKQImUfKNuUhBGX5PD SlY3n7/3498Ddbqx3XhfEoF0kOs9iecdThZJ1QcUs1ky3YSMDHc9/g/M+Mb4bflVFn2D tiVg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=YZr4NhFK9VRmzHURoHp19dmXt5FyLGLjyf944Yq+Z50=; b=aVrN/T+6FTj3l+mQV0csxNslYAvTT8zc05IQHiAYQ0c6sXAh9lngu5USbKSgjtZVZy SeElRiF7Z6s60uceyEurO9aIcoB9/Il+Ol19cbvF49cCtNJmDDdNn4LNpFvOLr6Neqjj 0dLoUT7KHCm6Wsq3Qn6CwuCKvkd+g2u6APBVMjrYr92CQWckciT88I8+oW8ercO+Nwlg x2iNScuNJagdCL02z7Bzv4/Gx6qu7JSL33qF1ObvVNtC1MUW6xjiKVz+GXHUJ/5BDtLF BA0B91daU5XlsrtYYcBErAo/2NI9nX2gcd2idtLFleMwPe8Cl/uoZuChEcIqTzFeZZxu 6emQ== X-Gm-Message-State: APjAAAXwWCVSSIDI3oF29FebFfdxx9AqMzlgCJLWxtSBXu982WEXYBIK uAmOxuejdrH17w6DGuXBhTUcogxh X-Google-Smtp-Source: APXvYqy9okAQk92oqjROXPKk6uXi4XVSOxErDvVdfGNCsEyp0UiI5mmverQYOLIvOFMh/RTHaOl7uA== X-Received: by 2002:a63:4c4f:: with SMTP id m15mr993497pgl.346.1578618143724; Thu, 09 Jan 2020 17:02:23 -0800 (PST) Received: from dtor-ws ([2620:15c:202:201:3adc:b08c:7acc:b325]) by smtp.gmail.com with ESMTPSA id 100sm237954pjo.17.2020.01.09.17.02.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 09 Jan 2020 17:02:23 -0800 (PST) Date: Thu, 9 Jan 2020 17:02:21 -0800 From: Dmitry Torokhov To: Will Tipton Cc: linux-input@vger.kernel.org Subject: Re: config option to change key soft autorepeat behavior Message-ID: <20200110010221.GJ8314@dtor-ws> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-input-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-input@vger.kernel.org Hi Will, On Wed, Jan 08, 2020 at 01:08:54PM -0800, Will Tipton wrote: > Hello, > > I'd like to add an option to the input subsystem to change the behavior of > key repeat. Essentially, when two keyboard keys 'a' and 'b' are held down > simultaneously, I'd like to get 'abababab...' rather than 'abbbbbbbb...'. > Another example of a request for this feature is here > > . > > Re: implementation -- I think this is a relatively minor change in > input.h/.c > . > When this kernel option is enabled, the timer and repeat_key > > members of input_dev are replaced by a container of (timer, key) tuples. > There's one entry in this container for each currently-pressed key, and > each entry is basically managed the same way the singular timer and > repeat_key are managed currently. > > I'm curious whether: > - a patch adding this feature is likely to be accepted. > - the implementation strategy I mentioned is the best approach. Given that most environments (X, Wayland) ignore kernel autorepeat and implement it themselves (since autorepeat parameters are really more of a user preferences rather than hardware/system properties), I do not think we should leave the kernel as is. Thanks. -- Dmitry