From: Marco Felsch <m.felsch@pengutronix.de>
To: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: robh+dt@kernel.org, andriy.shevchenko@linux.intel.com,
bparrot@ti.com, andy.shevchenko@gmail.com,
simon.budig@kernelconcepts.de, hdegoede@redhat.com,
fcooper@ti.com, mripard@kernel.org,
alexandre.belloni@bootlin.com, shawnguo@kernel.org,
devicetree@vger.kernel.org, kernel@pengutronix.de,
linux-input@vger.kernel.org
Subject: Re: [PATCH v3 6/6] Input: edt-ft5x06 - improve power management operations
Date: Fri, 10 Jan 2020 08:16:06 +0100 [thread overview]
Message-ID: <20200110071606.g42csvhgtriddqj4@pengutronix.de> (raw)
In-Reply-To: <20200110010957.GP8314@dtor-ws>
Hi Dmitry,
On 20-01-09 17:09, Dmitry Torokhov wrote:
> Hi Marco,
>
> On Wed, Jan 08, 2020 at 12:10:50PM +0100, Marco Felsch wrote:
> > +static int __maybe_unused edt_ft5x06_ts_resume(struct device *dev)
> > +{
> > + struct i2c_client *client = to_i2c_client(dev);
> > + struct edt_ft5x06_ts_data *tsdata = i2c_get_clientdata(client);
> > + int ret;
> > +
> > + if (device_may_wakeup(dev))
> > + return 0;
> > +
> > + ret = regulator_enable(tsdata->vcc);
> > + if (ret)
> > + dev_warn(dev, "Failed to enable vcc\n");
>
> I wonder if we should not return error here instead of continuing. If
> device is not powered up properly we'll have hard time communicating
> with it.
That's a reasonable point.
> The same is for suspend: maybe we should abort if we can't switch off
> regulator or write to the device.
I have no strong opinion about that case but IMHO it's okay to go further
if we can't switch it off. Instead we should print a warning.
Regards,
Marco
> Thanks.
>
> --
> Dmitry
>
--
Pengutronix e.K. | |
Steuerwalder Str. 21 | http://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
next prev parent reply other threads:[~2020-01-10 7:16 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-08 11:10 [PATCH v3 0/6] EDT-FT5x06 improvements Marco Felsch
2020-01-08 11:10 ` [PATCH v3 1/6] Input: edt-ft5x06: work around first register access error Marco Felsch
2020-01-10 1:06 ` Dmitry Torokhov
2020-01-08 11:10 ` [PATCH v3 2/6] Input: edt-ft5x06 - alphabetical include reorder Marco Felsch
2020-01-10 1:06 ` Dmitry Torokhov
2020-01-08 11:10 ` [PATCH v3 3/6] dt-bindings: Input: edt-ft5x06 - document wakeup-source capability Marco Felsch
2020-01-10 1:07 ` Dmitry Torokhov
2020-01-08 11:10 ` [PATCH v3 4/6] Input: edt-ft5x06 - make wakeup-source switchable Marco Felsch
2020-01-10 1:07 ` Dmitry Torokhov
2020-01-08 11:10 ` [PATCH v3 5/6] Input: edt-ft5x06 - use pm core to enable/disable the wake irq Marco Felsch
2020-01-10 1:07 ` Dmitry Torokhov
2020-01-08 11:10 ` [PATCH v3 6/6] Input: edt-ft5x06 - improve power management operations Marco Felsch
2020-01-10 1:09 ` Dmitry Torokhov
2020-01-10 7:16 ` Marco Felsch [this message]
2020-01-10 7:18 ` Marco Felsch
2020-01-16 13:32 ` Marco Felsch
2020-01-22 6:00 ` Dmitry Torokhov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200110071606.g42csvhgtriddqj4@pengutronix.de \
--to=m.felsch@pengutronix.de \
--cc=alexandre.belloni@bootlin.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=andy.shevchenko@gmail.com \
--cc=bparrot@ti.com \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.torokhov@gmail.com \
--cc=fcooper@ti.com \
--cc=hdegoede@redhat.com \
--cc=kernel@pengutronix.de \
--cc=linux-input@vger.kernel.org \
--cc=mripard@kernel.org \
--cc=robh+dt@kernel.org \
--cc=shawnguo@kernel.org \
--cc=simon.budig@kernelconcepts.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).