From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 94D52C33CA9 for ; Mon, 13 Jan 2020 18:26:20 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 75FE82075B for ; Mon, 13 Jan 2020 18:26:19 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728913AbgAMS0P (ORCPT ); Mon, 13 Jan 2020 13:26:15 -0500 Received: from mail.kernel.org ([198.145.29.99]:50464 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728682AbgAMS0P (ORCPT ); Mon, 13 Jan 2020 13:26:15 -0500 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 88FFD2075B; Mon, 13 Jan 2020 18:26:14 +0000 (UTC) Date: Mon, 13 Jan 2020 19:26:12 +0100 From: Greg KH To: Johan Hovold Cc: Dmitry Torokhov , linux-input@vger.kernel.org, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, stable Subject: Re: [PATCH] Input: keyspan-remote: fix control-message timeouts Message-ID: <20200113182612.GH411698@kroah.com> References: <20200113171715.30621-1-johan@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200113171715.30621-1-johan@kernel.org> Sender: linux-input-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-input@vger.kernel.org On Mon, Jan 13, 2020 at 06:17:15PM +0100, Johan Hovold wrote: > The driver was issuing synchronous uninterruptible control requests > without using a timeout. This could lead to the driver hanging on probe > due to a malfunctioning (or malicious) device until the device is > physically disconnected. While sleeping in probe the driver prevents > other devices connected to the same hub from being added to (or removed > from) the bus. > > The USB upper limit of five seconds per request should be more than > enough. > > Fixes: 99f83c9c9ac9 ("[PATCH] USB: add driver for Keyspan Digital Remote") > Cc: stable # 2.6.13 > Signed-off-by: Johan Hovold > --- > drivers/input/misc/keyspan_remote.c | 9 ++++++--- > 1 file changed, 6 insertions(+), 3 deletions(-) > Reviewed-by: Greg Kroah-Hartman