From: kbuild test robot <lkp@intel.com>
To: Samuel Holland <samuel@sholland.org>
Cc: kbuild-all@lists.01.org,
Dmitry Torokhov <dmitry.torokhov@gmail.com>,
Chen-Yu Tsai <wens@csie.org>, Hans de Goede <hdegoede@redhat.com>,
linux-input@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-sunxi@googlegroups.com,
Samuel Holland <samuel@sholland.org>
Subject: Re: [PATCH 2/3] Input: axp20x-pek - Respect userspace wakeup configuration
Date: Tue, 14 Jan 2020 12:50:42 +0800 [thread overview]
Message-ID: <202001141238.93tNmL0W%lkp@intel.com> (raw)
In-Reply-To: <20200113032032.38709-2-samuel@sholland.org>
[-- Attachment #1: Type: text/plain, Size: 3716 bytes --]
Hi Samuel,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on input/next]
[also build test WARNING on v5.5-rc6 next-20200110]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system. BTW, we also suggest to use '--base' option to specify the
base tree in git format-patch, please see https://stackoverflow.com/a/37406982]
url: https://github.com/0day-ci/linux/commits/Samuel-Holland/Input-axp20x-pek-Remove-unique-wakeup-event-handling/20200113-112123
base: https://git.kernel.org/pub/scm/linux/kernel/git/dtor/input.git next
config: x86_64-randconfig-a001-20200112 (attached as .config)
compiler: gcc-5 (Ubuntu 5.5.0-12ubuntu1) 5.5.0 20171010
reproduce:
# save the attached .config to linux build tree
make ARCH=x86_64
If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <lkp@intel.com>
All warnings (new ones prefixed by >>):
>> drivers/input/misc/axp20x-pek.c:356:5: warning: "CONFIG_PM_SLEEP" is not defined [-Wundef]
#if CONFIG_PM_SLEEP
^
Cyclomatic Complexity 1 arch/x86/include/asm/bitops.h:ffs
Cyclomatic Complexity 1 include/linux/pm_wakeup.h:device_set_wakeup_capable
Cyclomatic Complexity 1 include/linux/pm_wakeup.h:device_set_wakeup_enable
Cyclomatic Complexity 1 include/linux/pm_wakeup.h:device_init_wakeup
Cyclomatic Complexity 1 include/linux/device.h:dev_get_drvdata
Cyclomatic Complexity 1 include/linux/device.h:dev_set_drvdata
Cyclomatic Complexity 1 include/linux/input.h:input_get_drvdata
Cyclomatic Complexity 1 include/linux/input.h:input_set_drvdata
Cyclomatic Complexity 1 include/linux/platform_device.h:platform_set_drvdata
Cyclomatic Complexity 1 drivers/input/misc/axp20x-pek.c:axp20x_pek_should_register_input
Cyclomatic Complexity 1 drivers/input/misc/axp20x-pek.c:axp20x_pek_driver_init
Cyclomatic Complexity 22 drivers/input/misc/axp20x-pek.c:axp20x_store_attr
Cyclomatic Complexity 1 drivers/input/misc/axp20x-pek.c:axp20x_store_attr_shutdown
Cyclomatic Complexity 1 drivers/input/misc/axp20x-pek.c:axp20x_store_attr_startup
Cyclomatic Complexity 8 drivers/input/misc/axp20x-pek.c:axp20x_show_attr
Cyclomatic Complexity 1 drivers/input/misc/axp20x-pek.c:axp20x_show_attr_shutdown
Cyclomatic Complexity 1 drivers/input/misc/axp20x-pek.c:axp20x_show_attr_startup
Cyclomatic Complexity 1 include/linux/device.h:devm_kzalloc
Cyclomatic Complexity 22 drivers/input/misc/axp20x-pek.c:axp20x_pek_probe_input_device
Cyclomatic Complexity 12 drivers/input/misc/axp20x-pek.c:axp20x_pek_probe
Cyclomatic Complexity 1 include/linux/input.h:input_report_key
Cyclomatic Complexity 1 include/linux/input.h:input_sync
Cyclomatic Complexity 7 drivers/input/misc/axp20x-pek.c:axp20x_pek_irq
Cyclomatic Complexity 1 drivers/input/misc/axp20x-pek.c:axp20x_pek_driver_exit
vim +/CONFIG_PM_SLEEP +356 drivers/input/misc/axp20x-pek.c
355
> 356 #if CONFIG_PM_SLEEP
357 static int axp20x_pek_suspend(struct device *dev)
358 {
359 struct axp20x_pek *axp20x_pek = dev_get_drvdata(dev);
360
361 /*
362 * Nested threaded interrupts are not automatically
363 * disabled, so we must do it explicitly.
364 */
365 if (device_may_wakeup(dev)) {
366 enable_irq_wake(axp20x_pek->irq_dbf);
367 enable_irq_wake(axp20x_pek->irq_dbr);
368 } else {
369 disable_irq(axp20x_pek->irq_dbf);
370 disable_irq(axp20x_pek->irq_dbr);
371 }
372
373 return 0;
374 }
375
---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org Intel Corporation
[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 32888 bytes --]
next prev parent reply other threads:[~2020-01-14 4:51 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-13 3:20 [PATCH 1/3] Input: axp20x-pek - Remove unique wakeup event handling Samuel Holland
2020-01-13 3:20 ` [PATCH 2/3] Input: axp20x-pek - Respect userspace wakeup configuration Samuel Holland
2020-01-13 4:47 ` kbuild test robot
2020-01-13 10:48 ` Hans de Goede
2020-01-13 21:38 ` Dmitry Torokhov
2020-01-14 4:50 ` kbuild test robot [this message]
2020-01-13 3:20 ` [PATCH 3/3] Input: axp20x-pek - Enable wakeup for all AXP variants Samuel Holland
2020-01-13 10:48 ` Hans de Goede
2020-01-13 21:26 ` Dmitry Torokhov
2020-01-14 9:07 ` Hans de Goede
2020-01-15 4:45 ` Samuel Holland
2020-01-13 10:41 ` [PATCH 1/3] Input: axp20x-pek - Remove unique wakeup event handling Hans de Goede
2020-01-13 10:58 ` Hans de Goede
2020-01-15 4:29 ` [linux-sunxi] " Samuel Holland
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202001141238.93tNmL0W%lkp@intel.com \
--to=lkp@intel.com \
--cc=dmitry.torokhov@gmail.com \
--cc=hdegoede@redhat.com \
--cc=kbuild-all@lists.01.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sunxi@googlegroups.com \
--cc=samuel@sholland.org \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).