From: Hans de Goede <hdegoede@redhat.com> To: Ard Biesheuvel <ardb@kernel.org>, Darren Hart <dvhart@infradead.org>, Andy Shevchenko <andy@infradead.org>, Luis Chamberlain <mcgrof@kernel.org>, Greg Kroah-Hartman <gregkh@linuxfoundation.org>, "Rafael J . Wysocki" <rafael@kernel.org>, Thomas Gleixner <tglx@linutronix.de>, Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>, "H . Peter Anvin" <hpa@zytor.com>, Jonathan Corbet <corbet@lwn.net>, Dmitry Torokhov <dmitry.torokhov@gmail.com> Cc: Hans de Goede <hdegoede@redhat.com>, Peter Jones <pjones@redhat.com>, Dave Olsthoorn <dave@bewaar.me>, x86@kernel.org, platform-driver-x86@vger.kernel.org, linux-efi@vger.kernel.org, linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, linux-input@vger.kernel.org Subject: [PATCH v12 07/10] Input: silead - Switch to firmware_request_platform for retreiving the fw Date: Wed, 15 Jan 2020 17:35:51 +0100 Message-ID: <20200115163554.101315-8-hdegoede@redhat.com> (raw) In-Reply-To: <20200115163554.101315-1-hdegoede@redhat.com> Unfortunately sofar we have been unable to get permission to redistribute Silead touchscreen firmwares in linux-firmware. This means that people need to find and install the firmware themselves before the touchscreen will work Some UEFI/x86 tablets with a Silead touchscreen have a copy of the fw embedded in their UEFI boot-services code. This commit makes the silead driver use the new firmware_request_platform function, which will fallback to looking for such an embedded copy when direct filesystem lookup fails. This will make the touchscreen work OOTB on devices where there is a fw copy embedded in the UEFI code. Acked-by: Dmitry Torokhov <dmitry.torokhov@gmail.com> Signed-off-by: Hans de Goede <hdegoede@redhat.com> --- drivers/input/touchscreen/silead.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/input/touchscreen/silead.c b/drivers/input/touchscreen/silead.c index ad8b6a2bfd36..8fa2f3b7cfd8 100644 --- a/drivers/input/touchscreen/silead.c +++ b/drivers/input/touchscreen/silead.c @@ -288,7 +288,7 @@ static int silead_ts_load_fw(struct i2c_client *client) dev_dbg(dev, "Firmware file name: %s", data->fw_name); - error = request_firmware(&fw, data->fw_name, dev); + error = firmware_request_platform(&fw, data->fw_name, dev); if (error) { dev_err(dev, "Firmware request error %d\n", error); return error; -- 2.24.1
next prev parent reply index Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-01-15 16:35 [PATCH v12 00/10] efi/firmware/platform-x86: Add EFI embedded fw support Hans de Goede 2020-01-15 16:35 ` [PATCH v12 01/10] efi: Export boot-services code and data as debugfs-blobs Hans de Goede 2020-01-15 16:35 ` [PATCH v12 02/10] efi: Add embedded peripheral firmware support Hans de Goede 2020-01-15 16:35 ` [PATCH v12 03/10] firmware: Rename FW_OPT_NOFALLBACK to FW_OPT_NOFALLBACK_SYSFS Hans de Goede 2020-01-24 8:57 ` Greg Kroah-Hartman 2020-01-24 9:16 ` Hans de Goede 2020-03-18 13:27 ` Greg Kroah-Hartman 2020-03-18 13:56 ` Hans de Goede 2020-03-20 14:02 ` Greg Kroah-Hartman 2020-03-20 16:41 ` Hans de Goede 2020-01-15 16:35 ` [PATCH v12 04/10] firmware: Add new platform fallback mechanism and firmware_request_platform() Hans de Goede 2020-01-15 16:35 ` [PATCH v12 05/10] test_firmware: add support for firmware_request_platform Hans de Goede 2020-01-15 16:41 ` Luis Chamberlain 2020-01-15 16:35 ` [PATCH v12 06/10] selftests: firmware: Add firmware_request_platform tests Hans de Goede 2020-01-15 16:41 ` Luis Chamberlain 2020-01-15 16:35 ` Hans de Goede [this message] 2020-01-15 16:35 ` [PATCH v12 08/10] Input: icn8505 - Switch to firmware_request_platform for retreiving the fw Hans de Goede 2020-01-15 16:35 ` [PATCH v12 09/10] platform/x86: touchscreen_dmi: Add EFI embedded firmware info support Hans de Goede 2020-01-15 16:35 ` [PATCH v12 10/10] platform/x86: touchscreen_dmi: Add info for the Chuwi Vi8 Plus tablet Hans de Goede
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20200115163554.101315-8-hdegoede@redhat.com \ --to=hdegoede@redhat.com \ --cc=andy@infradead.org \ --cc=ardb@kernel.org \ --cc=bp@alien8.de \ --cc=corbet@lwn.net \ --cc=dave@bewaar.me \ --cc=dmitry.torokhov@gmail.com \ --cc=dvhart@infradead.org \ --cc=gregkh@linuxfoundation.org \ --cc=hpa@zytor.com \ --cc=linux-doc@vger.kernel.org \ --cc=linux-efi@vger.kernel.org \ --cc=linux-input@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=mcgrof@kernel.org \ --cc=mingo@redhat.com \ --cc=pjones@redhat.com \ --cc=platform-driver-x86@vger.kernel.org \ --cc=rafael@kernel.org \ --cc=tglx@linutronix.de \ --cc=x86@kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
Linux Input Archive on lore.kernel.org Archives are clonable: git clone --mirror https://lore.kernel.org/linux-input/0 linux-input/git/0.git # If you have public-inbox 1.1+ installed, you may # initialize and index your mirror using the following commands: public-inbox-init -V2 linux-input linux-input/ https://lore.kernel.org/linux-input \ linux-input@vger.kernel.org public-inbox-index linux-input Example config snippet for mirrors Newsgroup available over NNTP: nntp://nntp.lore.kernel.org/org.kernel.vger.linux-input AGPL code for this site: git clone https://public-inbox.org/public-inbox.git