From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 57DE4C33C9E for ; Fri, 17 Jan 2020 04:24:14 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 2A94820842 for ; Fri, 17 Jan 2020 04:24:14 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="cIVbgfHF" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726925AbgAQEYN (ORCPT ); Thu, 16 Jan 2020 23:24:13 -0500 Received: from mail-pj1-f67.google.com ([209.85.216.67]:51344 "EHLO mail-pj1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726566AbgAQEYN (ORCPT ); Thu, 16 Jan 2020 23:24:13 -0500 Received: by mail-pj1-f67.google.com with SMTP id d15so2583414pjw.1; Thu, 16 Jan 2020 20:24:12 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to :user-agent; bh=ANpzFmgjjuaZgNEEBDm5PaG+F+Suwy/uIclI0OaRnP4=; b=cIVbgfHFRatkQnOmtGISxJXOYHYBnXKXuk/8gi0JxX7/6LqD7P28IGHSgERryqKAp3 qR4KGBZ2DCGcmtX+wZMFcOIuyjoxC2zW2YUI4XlgN+ao4SvFQXmcrv09ev3cGvkFj47s q5RiJCo5xsqJ9Lf2XQEoaXMXFyJ4nKsj7/lQNoX/tkhFnTLE0kqF7wzs2Wmo9Ox5jhgJ uiYY/5jaadyzv5m64cGex4Rc33tZ6Cl+oQWe0T2P7lmJnQogFAKZluEcG/0sP6gZu1J9 X9ZMQepYdPVTNRcTyR9mWXpoPukvLzVaAeuopMyYLoHgnJEv/OfYNVnfWtLtAFrEgnLA LWDg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to:user-agent; bh=ANpzFmgjjuaZgNEEBDm5PaG+F+Suwy/uIclI0OaRnP4=; b=eCFW+pTG3wHAnVrnLfA8wDnaArkXK0dixsjfRPp/Etr0AfnAAvVJ+E4hXDN8IoAnYO SzGr60YNKPBmEhFelPPeXDPoE+ovTpKwnM9jyHWpNKjPVzLNCe9pqjhrUsPChojF7UCZ YqMxtXxThj4DRjUWGFSujLAUBADAumYRduEZw238bBeqIZ/dfLg3I936BfugJ+rhbOIo GdrQLCSo0NNTt3vv1IvKZxa9MMBVmQQJCBIka9CxJRKNjJbUtxuNwFgDDSbGB6IpAOGk Ozcf6xGtBredW6jtSvGnKMkJTYXz6LY3n/iQUk6qaqB5G+ikTroJSpf5gV21GT8CCwvp qgAA== X-Gm-Message-State: APjAAAUPqvD9nEXZslvwiILJJ+dySYdB1QcpyEKRpbCP4Q6wGfn1UExW 5RFdMXnaZZ/OG/b5stIlEH4= X-Google-Smtp-Source: APXvYqwE05jpaDTRqD3BU1fHu6zE7cC/ZX1k2DsUR0/fW/MOvfolBW34Hl0kZoAtkbRKjImpQRTWzQ== X-Received: by 2002:a17:902:b48e:: with SMTP id y14mr36241040plr.260.1579235052436; Thu, 16 Jan 2020 20:24:12 -0800 (PST) Received: from dtor-ws ([2620:15c:202:201:3adc:b08c:7acc:b325]) by smtp.gmail.com with ESMTPSA id j125sm26799062pfg.160.2020.01.16.20.24.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 16 Jan 2020 20:24:11 -0800 (PST) Date: Thu, 16 Jan 2020 20:24:09 -0800 From: Dmitry Torokhov To: Bartosz Golaszewski Cc: Linux Kernel Mailing List , Linux Input , Bartosz Golaszewski Subject: Re: [PATCH] input: max77650-onkey: add of_match table Message-ID: <20200117042409.GE47797@dtor-ws> References: <20191210100753.11090-1-brgl@bgdev.pl> <20200110182841.GT8314@dtor-ws> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-input-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-input@vger.kernel.org On Sat, Jan 11, 2020 at 11:22:55AM +0100, Bartosz Golaszewski wrote: > pt., 10 sty 2020 o 19:28 Dmitry Torokhov napisał(a): > > > > On Tue, Dec 10, 2019 at 11:07:53AM +0100, Bartosz Golaszewski wrote: > > > From: Bartosz Golaszewski > > > > > > We need the of_match table if we want to use the compatible string in > > > the pmic's child node and get the onkey driver loaded automatically. > > > > Do we really need of_match table or adding > > > > Not really. Technically not anyway but we merged bindings that define > it (at the time I didn't know any better) and seems we're stuck with > it. Please see the discussion below a similar patch for regulator > subsystem[1]. > > > MODULE_ALIAS("platform:max77650-onkey"); > > > > This is already in there, but if someone defines the compatible in the > device tree as per bindings, the module won't be loaded despite the > MODULE_ALIAS() definition. I see. Applied, thank you. -- Dmitry