From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Arnd Bergmann <arnd@arndb.de>
Cc: Oleksandr Natalenko <oleksandr@redhat.com>,
Richard Fontana <rfontana@redhat.com>,
linux-input@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] input: appletouch: shut up -Wmaybe-uninitialized warning
Date: Fri, 17 Jan 2020 13:45:35 -0800 [thread overview]
Message-ID: <20200117214535.GG47797@dtor-ws> (raw)
In-Reply-To: <20200107204300.1365789-1-arnd@arndb.de>
Hi Arnd,
On Tue, Jan 07, 2020 at 09:42:45PM +0100, Arnd Bergmann wrote:
> Building with -O3 introduces a false-positive warning in this file:
>
> In file included from include/linux/compiler_types.h:68,
> from <command-line>:
> drivers/input/mouse/appletouch.c: In function 'atp_complete_geyser_3_4':
> include/linux/compiler-gcc.h:71:45: error: 'x_z' may be used uninitialized in this function [-Werror=maybe-uninitialized]
> #define __UNIQUE_ID(prefix) __PASTE(__PASTE(__UNIQUE_ID_, prefix), __COUNTER__)
> ^~~~~~~~~~~~
> drivers/input/mouse/appletouch.c:657:12: note: 'x_z' was declared here
> int x, y, x_z, y_z, x_f, y_f;
> ^~~
> In file included from include/linux/compiler_types.h:68,
> from <command-line>:
> drivers/input/mouse/appletouch.c: In function 'atp_complete_geyser_1_2':
> include/linux/compiler-gcc.h:71:45: error: 'x_z' may be used uninitialized in this function [-Werror=maybe-uninitialized]
> #define __UNIQUE_ID(prefix) __PASTE(__PASTE(__UNIQUE_ID_, prefix), __COUNTER__)
> ^~~~~~~~~~~~
> drivers/input/mouse/appletouch.c:517:12: note: 'x_z' was declared here
> int x, y, x_z, y_z, x_f, y_f;
> ^~~
>
> The variables are not actually used here since the only usage
> happens when both 'x' and 'y' are non-zero, but this is something
> that gcc fails to track.
>
> Fixes: mmtom ("init/Kconfig: enable -O3 for all arches")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
> drivers/input/mouse/appletouch.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/input/mouse/appletouch.c b/drivers/input/mouse/appletouch.c
> index 3f06e8a495d8..ec2139c43fcd 100644
> --- a/drivers/input/mouse/appletouch.c
> +++ b/drivers/input/mouse/appletouch.c
> @@ -330,7 +330,7 @@ static void atp_reinit(struct work_struct *work)
> retval);
> }
>
> -static int atp_calculate_abs(struct atp *dev, int offset, int nb_sensors,
> +static noinline int atp_calculate_abs(struct atp *dev, int offset, int nb_sensors,
> int fact, int *z, int *fingers)
I wonder if instead of nolinine we can have "*fingers = *z = 0;" in this
function...
I feel noinline has to be reserved for exceptional cases...
Thanks.
--
Dmitry
prev parent reply other threads:[~2020-01-17 21:45 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-07 20:42 [PATCH] input: appletouch: shut up -Wmaybe-uninitialized warning Arnd Bergmann
2020-01-17 21:45 ` Dmitry Torokhov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200117214535.GG47797@dtor-ws \
--to=dmitry.torokhov@gmail.com \
--cc=arnd@arndb.de \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=oleksandr@redhat.com \
--cc=rfontana@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).