From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Jonathan Cameron <jic23@jic23.retrosnub.co.uk>
Cc: Artur Rojek <contact@artur-rojek.eu>,
Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Jonathan Cameron <Jonathan.Cameron@huawei.com>,
Paul Cercueil <paul@crapouillou.net>,
linux-input@vger.kernel.org, devicetree@vger.kernel.org,
linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 5/5] input: joystick: Add ADC attached joystick driver.
Date: Mon, 20 Jan 2020 11:39:02 -0800 [thread overview]
Message-ID: <20200120193902.GH47797@dtor-ws> (raw)
In-Reply-To: <20200111115440.35f6cbfd@archlinux>
On Sat, Jan 11, 2020 at 11:54:40AM +0000, Jonathan Cameron wrote:
> On Sun, 5 Jan 2020 01:16:39 +0100
> Artur Rojek <contact@artur-rojek.eu> wrote:
>
> > Add a driver for joystick devices connected to ADC controllers
> > supporting the Industrial I/O subsystem.
> >
> > Signed-off-by: Artur Rojek <contact@artur-rojek.eu>
> > Tested-by: Paul Cercueil <paul@crapouillou.net>
>
> Looks pretty good, but I'd like to see a little more sanity checking
> on probe that the channels are in a format this driver can actually
> handle. Given we can check channel size and consistency etc early
> it would be better to fail to probe than just report error data later.
Artur,
From my POV it looks decent so as soon as you address Jonathan requests
you can add
Acked-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
assuming you want it to be perged through IIO tree.
Thanks.
--
Dmitry
prev parent reply other threads:[~2020-01-20 19:39 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-05 0:16 [PATCH 1/5] IIO: Ingenic JZ47xx: Add xlate cb to retrieve correct channel idx Artur Rojek
2020-01-05 0:16 ` [PATCH 2/5] dt-bindings: iio/adc: Add touchscreen idx for JZ47xx SoC ADC Artur Rojek
2020-01-08 16:59 ` Rob Herring
2020-01-05 0:16 ` [PATCH 3/5] IIO: Ingenic JZ47xx: Add touchscreen mode Artur Rojek
2020-01-11 11:46 ` Jonathan Cameron
2020-01-13 14:59 ` Paul Cercueil
2020-01-17 17:17 ` Jonathan Cameron
2020-01-18 11:15 ` Jonathan Cameron
2020-01-05 0:16 ` [PATCH 4/5] dt-bindings: input: Add docs for ADC driven joystick Artur Rojek
2020-01-08 20:12 ` Rob Herring
2020-01-05 0:16 ` [PATCH 5/5] input: joystick: Add ADC attached joystick driver Artur Rojek
2020-01-11 11:54 ` Jonathan Cameron
2020-01-20 19:39 ` Dmitry Torokhov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200120193902.GH47797@dtor-ws \
--to=dmitry.torokhov@gmail.com \
--cc=Jonathan.Cameron@huawei.com \
--cc=contact@artur-rojek.eu \
--cc=devicetree@vger.kernel.org \
--cc=jic23@jic23.retrosnub.co.uk \
--cc=linux-iio@vger.kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=paul@crapouillou.net \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).