From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A3CDAC33CAF for ; Wed, 22 Jan 2020 07:02:34 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 79AC82465B for ; Wed, 22 Jan 2020 07:02:34 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725884AbgAVHCe (ORCPT ); Wed, 22 Jan 2020 02:02:34 -0500 Received: from metis.ext.pengutronix.de ([85.220.165.71]:45577 "EHLO metis.ext.pengutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725836AbgAVHCd (ORCPT ); Wed, 22 Jan 2020 02:02:33 -0500 Received: from ptx.hi.pengutronix.de ([2001:67c:670:100:1d::c0]) by metis.ext.pengutronix.de with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1iuA1w-0001M8-Db; Wed, 22 Jan 2020 08:02:24 +0100 Received: from ukl by ptx.hi.pengutronix.de with local (Exim 4.89) (envelope-from ) id 1iuA1t-0007cM-Si; Wed, 22 Jan 2020 08:02:21 +0100 Date: Wed, 22 Jan 2020 08:02:21 +0100 From: Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= To: Jeff LaBundy Cc: "lee.jones@linaro.org" , "dmitry.torokhov@gmail.com" , "thierry.reding@gmail.com" , "jic23@kernel.org" , "devicetree@vger.kernel.org" , "linux-input@vger.kernel.org" , "linux-pwm@vger.kernel.org" , "knaack.h@gmx.de" , "lars@metafoo.de" , "pmeerw@pmeerw.net" , "linux-iio@vger.kernel.org" , "robh+dt@kernel.org" , "mark.rutland@arm.com" , "kernel@pengutronix.de" Subject: Re: [PATCH v4 4/7] pwm: Add support for Azoteq IQS620A PWM generator Message-ID: <20200122070221.mq6a5lejsepnajgf@pengutronix.de> References: <1579228475-6681-1-git-send-email-jeff@labundy.com> <1579228475-6681-5-git-send-email-jeff@labundy.com> <20200117073427.ufrduwagvppeasgr@pengutronix.de> <20200119233234.GB28865@labundy.com> <20200120072739.sixr5e76uckrugvu@pengutronix.de> <20200122035608.GA1455@labundy.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20200122035608.GA1455@labundy.com> User-Agent: NeoMutt/20170113 (1.7.2) X-SA-Exim-Connect-IP: 2001:67c:670:100:1d::c0 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-input@vger.kernel.org Sender: linux-input-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-input@vger.kernel.org Hello Jeff, On Wed, Jan 22, 2020 at 03:56:14AM +0000, Jeff LaBundy wrote: > > > The only problem is that leds-pwm disables the pwm at start-up, so the end > > > result is the same anyway. Regardless of the behavior of any one consumer, > > > however, I'm slightly inclined to go with the second option as it seems to > > > be less restrictive and more maintainable. Let me know if you disagree. > > > > With > > > > default-state = "keep"; > > > > in your dt the LED shouldn't get disabled. > > I see default-state defined as a common LED property, but leds-pwm doesn't > seem to use it unfortunately. Looking through its code, brightness is just > initialized to zero unconditionally. Sounds like a bug. Best regards Uwe -- Pengutronix e.K. | Uwe Kleine-König | Industrial Linux Solutions | https://www.pengutronix.de/ |