From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Benjamin Tissoires <benjamin.tissoires@redhat.com>
Cc: "open list:HID CORE LAYER" <linux-input@vger.kernel.org>,
lkml <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] Input: synaptics - remove the LEN0049 dmi id from topbuttonpad list
Date: Thu, 13 Feb 2020 17:08:32 -0800 [thread overview]
Message-ID: <20200214010832.GE183709@dtor-ws> (raw)
In-Reply-To: <CAO-hwJK38mpMp0yL1v+4KAhhuUuwAPrTm7kSTGhXPL2JC1F-6w@mail.gmail.com>
On Wed, Feb 12, 2020 at 09:53:25AM +0100, Benjamin Tissoires wrote:
> On Wed, Jan 15, 2020 at 2:30 AM Benjamin Tissoires
> <benjamin.tissoires@redhat.com> wrote:
> >
> > The Yoga 11e is using LEN0049, but it doesn't have a trackstick.
> >
> > Thus, there is no need to create a software top buttons row.
> >
> > However, it seems that the device works under SMBus, so keep it as part
> > of the smbus_pnp_ids.
> >
> >
> > Link: https://gitlab.freedesktop.org/libinput/libinput/issues/414
> > Signed-off-by: Benjamin Tissoires <benjamin.tissoires@redhat.com>
> >
> > --
> >
> > Hi Dmitry,
> >
> > Sending the patch to the list untested (sanity only), and I'll ask
> > for the reporter to provide a little bit more testing.
> >
> > I will keep you updated when you can merge the patch.
>
> Hi Dmitry,
>
> Sergej tested the patch last week and it works well. So I think we can
> merge it now.
> Maybe we should also add a stable@ tag here...
Tagged for stable, thank you Benjamin.
>
> Cheers,
> Benjamin
>
> >
> > Cheers,
> > Benjamin
> > ---
> > drivers/input/mouse/synaptics.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/input/mouse/synaptics.c b/drivers/input/mouse/synaptics.c
> > index 1ae6f8bba9ae..7aa84f743c48 100644
> > --- a/drivers/input/mouse/synaptics.c
> > +++ b/drivers/input/mouse/synaptics.c
> > @@ -146,7 +146,6 @@ static const char * const topbuttonpad_pnp_ids[] = {
> > "LEN0042", /* Yoga */
> > "LEN0045",
> > "LEN0047",
> > - "LEN0049",
> > "LEN2000", /* S540 */
> > "LEN2001", /* Edge E431 */
> > "LEN2002", /* Edge E531 */
> > @@ -166,6 +165,7 @@ static const char * const smbus_pnp_ids[] = {
> > /* all of the topbuttonpad_pnp_ids are valid, we just add some extras */
> > "LEN0048", /* X1 Carbon 3 */
> > "LEN0046", /* X250 */
> > + "LEN0049", /* Yoga 11e */
> > "LEN004a", /* W541 */
> > "LEN005b", /* P50 */
> > "LEN005e", /* T560 */
> > --
> > 2.24.1
> >
>
--
Dmitry
prev parent reply other threads:[~2020-02-14 1:08 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-15 1:30 [PATCH] Input: synaptics - remove the LEN0049 dmi id from topbuttonpad list Benjamin Tissoires
2020-02-12 8:53 ` Benjamin Tissoires
2020-02-14 1:08 ` Dmitry Torokhov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200214010832.GE183709@dtor-ws \
--to=dmitry.torokhov@gmail.com \
--cc=benjamin.tissoires@redhat.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).