From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.4 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4F71BC3F2CD for ; Tue, 3 Mar 2020 06:03:54 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id D7555214D8 for ; Tue, 3 Mar 2020 06:03:53 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=innovation.ch header.i=@innovation.ch header.b="SF0fmxfG" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725944AbgCCGDx (ORCPT ); Tue, 3 Mar 2020 01:03:53 -0500 Received: from chill.innovation.ch ([216.218.245.220]:53750 "EHLO chill.innovation.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725879AbgCCGDw (ORCPT ); Tue, 3 Mar 2020 01:03:52 -0500 Date: Mon, 2 Mar 2020 22:03:51 -0800 DKIM-Filter: OpenDKIM Filter v2.10.3 chill.innovation.ch DC00A6412A7 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=innovation.ch; s=default; t=1583215431; bh=CoCegPxzkwOrSb2LMFv1mRjuEAk+XhXfz7ah1mwZ+iI=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=SF0fmxfG2Fs+V3rpagT9o+yvQ+7Hiy6jPkWlEq9djzzV94xtc87f0xPMMcMJQlqir QsLzFPuMvBnU8tRaglCAkLvBH0ceVKX8X0d2LcgjuCOPoml9fXdDhTOJAtw0Fd82cq i4Q+rJLaVSi/6n8JdyJHfdPS+IW+hM6BwNkwd8oTg7b9houEANYddbXvTV9HohENbl JRBoxDU50dn9HE+Z1gqf7ol7VSkcJ4j+oC5PgtCyC51IoEC96mHw3BHKAPxpFH+BDk p8NLulQGA4VRc5FqDA5r/lu1stu3K8uxrOtQ61T2dFqhRyuwLg/JhJI9Qn2uoOQRPO yDd/AVFuLnv+Q== From: "Life is hard, and then you die" To: Andy Shevchenko Cc: Sergiu Cuciurean , linux-kernel@vger.kernel.org, linux-input@vger.kernel.org, dmitry.torokhov@gmail.com, nikolas@gnu.org, gregkh@linuxfoundation.org, maowenan@huawei.com Subject: Re: [PATCH] input: keyboard: applespi: Use new structure for SPI transfer delays Message-ID: <20200303060351.GA12060@innovation.ch> References: <20200227124534.23399-1-sergiu.cuciurean@analog.com> <20200229032616.GA27264@innovation.ch> <20200302110932.GS1224808@smile.fi.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20200302110932.GS1224808@smile.fi.intel.com> User-Agent: Mutt/1.11.4 (2019-03-13) Sender: linux-input-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-input@vger.kernel.org On Mon, Mar 02, 2020 at 01:09:32PM +0200, Andy Shevchenko wrote: > On Fri, Feb 28, 2020 at 07:26:16PM -0800, Life is hard, and then you die wrote: > > On Thu, Feb 27, 2020 at 02:45:34PM +0200, Sergiu Cuciurean wrote: > > ... > > > > - wr_t->delay_usecs = SPI_RW_CHG_DELAY_US; > > > + wr_t->delay.value = SPI_RW_CHG_DELAY_US; > > > + wr_t->delay.unit = SPI_DELAY_UNIT_USECS; > > > > Looks good to me and tested to confirm things still work. > > Ronald, we have the established tags for such, like Tested-by:, Reviewed-by:. Apologies, that was sloppy of me. So: Tested-by: Ronald Tschalär Reviewed-by: Ronald Tschalär Cheers, Ronald