From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Andrew Duggan <aduggan@synaptics.com>
Cc: Paul Hollinsky <phollinsky@holtechnik.com>,
Christopher Heiny <Cheiny@synaptics.com>,
Lucas Stach <l.stach@pengutronix.de>,
"linux-input@vger.kernel.org" <linux-input@vger.kernel.org>,
"kernel@pengutronix.de" <kernel@pengutronix.de>,
"patchwork-lst@pengutronix.de" <patchwork-lst@pengutronix.de>
Subject: Re: [PATCH] Input: synaptics-rmi4 - switch to reduced reporting mode
Date: Sat, 7 Mar 2020 14:34:21 -0800 [thread overview]
Message-ID: <20200307223421.GS217608@dtor-ws> (raw)
In-Reply-To: <2d54859d-ee5a-97ec-fe62-79fc1f9e3122@synaptics.com>
On Thu, Feb 20, 2020 at 06:36:59PM -0800, Andrew Duggan wrote:
>
> On 2/18/20 7:01 PM, Paul Hollinsky wrote:
> >
> > Hi everyone,
> >
> > I believe there may be an issue with the reduced reporting mode, at
> > least on my machine. I have a Lenovo ThinkPad X250 with the Synaptics
> > TM3075-002 trackpad.
> >
> > With this patch, the trackpad becomes unusable. On a reboot, my control
> > register values are [38 00 19 19 00 10 90 06 ea 03 0f 01]. This
> > corresponds to a delta X/Y threshold of 25 and a palm rejection value of
> > 0. The protocol documentation mentions that the palm rejection value
> > becomes active when in reduced reporting mode, hence its inclusion here.
> >
> Hmm, it looks like the firmware was configured with non-zero Delta X/Y
> Position thresholds. But, the firmware does not enable reduced reporting
> mode by default so those thresholds have no effect. However, this patch will
> now enable reduced reporting mode since it sees the non-zero threshold which
> were read from the firmware. I did not consider the case where the firmware
> would have thresholds set, but not enabled when I reviewed this patch
> initially. Based on this new info I would suggest we change the if statement
> to check sensor->axis_align.delta_x_threshold ||
> sensor->axis_align.delta_y_threshold. Then we would only change the
> reporting mode if the driver is explicitly setting the thresholds.
Any chance I could get a patch implementing this?
Thanks.
--
Dmitry
prev parent reply other threads:[~2020-03-07 22:34 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-20 11:16 [PATCH] Input: synaptics-rmi4 - switch to reduced reporting mode Lucas Stach
2020-01-27 2:24 ` Dmitry Torokhov
2020-01-27 19:21 ` Andrew Duggan
2020-01-28 7:02 ` Christopher Heiny
2020-01-28 9:41 ` Lucas Stach
2020-01-28 17:22 ` Christopher Heiny
2020-01-31 18:28 ` Andrew Duggan
2020-02-01 1:38 ` Dmitry Torokhov
2020-02-19 3:01 ` Paul Hollinsky
2020-02-21 2:36 ` Andrew Duggan
2020-03-07 22:34 ` Dmitry Torokhov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200307223421.GS217608@dtor-ws \
--to=dmitry.torokhov@gmail.com \
--cc=Cheiny@synaptics.com \
--cc=aduggan@synaptics.com \
--cc=kernel@pengutronix.de \
--cc=l.stach@pengutronix.de \
--cc=linux-input@vger.kernel.org \
--cc=patchwork-lst@pengutronix.de \
--cc=phollinsky@holtechnik.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).