linux-input.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH v1 0/2] goodix: support of gt9147
@ 2020-03-02 10:18 Yannick Fertre
  2020-03-02 10:18 ` [PATCH v1 1/2] dt-bindings: touchscreen: " Yannick Fertre
  2020-03-02 10:18 ` [PATCH v1 2/2] Input: goodix - support gt9147 touchpanel Yannick Fertre
  0 siblings, 2 replies; 5+ messages in thread
From: Yannick Fertre @ 2020-03-02 10:18 UTC (permalink / raw)
  To: Bastien Nocera, Dmitry Torokhov, Rob Herring, Mark Rutland,
	Benjamin Gaignard, Yannick Fertre, linux-input, devicetree,
	linux-kernel

Add support of GT9147 for Goodix touchscreen.
The chip data on GT9147 is similar to GT912, like
- config data register has 0x8047 address
- config data register max len is 240
- config data checksum has 8-bit


Yannick Fertre (2):
  dt-bindings: touchscreen: goodix: support of gt9147
  Input: goodix - support gt9147 touchpanel

 Documentation/devicetree/bindings/input/touchscreen/goodix.yaml | 1 +
 drivers/input/touchscreen/goodix.c                              | 2 ++
 2 files changed, 3 insertions(+)

--
2.7.4


^ permalink raw reply	[flat|nested] 5+ messages in thread

* [PATCH v1 1/2] dt-bindings: touchscreen: goodix: support of gt9147
  2020-03-02 10:18 [PATCH v1 0/2] goodix: support of gt9147 Yannick Fertre
@ 2020-03-02 10:18 ` Yannick Fertre
  2020-03-10 19:27   ` Rob Herring
  2020-03-02 10:18 ` [PATCH v1 2/2] Input: goodix - support gt9147 touchpanel Yannick Fertre
  1 sibling, 1 reply; 5+ messages in thread
From: Yannick Fertre @ 2020-03-02 10:18 UTC (permalink / raw)
  To: Bastien Nocera, Dmitry Torokhov, Rob Herring, Mark Rutland,
	Benjamin Gaignard, Yannick Fertre, linux-input, devicetree,
	linux-kernel

Add support for it by adding compatible.
The chip data on GT9147 is similar to GT912, like
- config data register has 0x8047 address
- config data register max len is 240
- config data checksum has 8-bit

Signed-off-by: Yannick Fertre <yannick.fertre@st.com>
---
 Documentation/devicetree/bindings/input/touchscreen/goodix.yaml | 1 +
 1 file changed, 1 insertion(+)

diff --git a/Documentation/devicetree/bindings/input/touchscreen/goodix.yaml b/Documentation/devicetree/bindings/input/touchscreen/goodix.yaml
index d7c3262..9f65d67 100644
--- a/Documentation/devicetree/bindings/input/touchscreen/goodix.yaml
+++ b/Documentation/devicetree/bindings/input/touchscreen/goodix.yaml
@@ -21,6 +21,7 @@ properties:
       - goodix,gt911
       - goodix,gt9110
       - goodix,gt912
+      - goodix,gt9147
       - goodix,gt927
       - goodix,gt9271
       - goodix,gt928
-- 
2.7.4


^ permalink raw reply related	[flat|nested] 5+ messages in thread

* [PATCH v1 2/2] Input: goodix - support gt9147 touchpanel
  2020-03-02 10:18 [PATCH v1 0/2] goodix: support of gt9147 Yannick Fertre
  2020-03-02 10:18 ` [PATCH v1 1/2] dt-bindings: touchscreen: " Yannick Fertre
@ 2020-03-02 10:18 ` Yannick Fertre
  2020-03-02 11:00   ` Bastien Nocera
  1 sibling, 1 reply; 5+ messages in thread
From: Yannick Fertre @ 2020-03-02 10:18 UTC (permalink / raw)
  To: Bastien Nocera, Dmitry Torokhov, Rob Herring, Mark Rutland,
	Benjamin Gaignard, Yannick Fertre, linux-input, devicetree,
	linux-kernel

Add support for it by adding compatible and supported chip data
(default settings used).
The chip data on GT9147 is similar to GT912, like
- config data register has 0x8047 address
- config data register max len is 240
- config data checksum has 8-bit

Signed-off-by: Yannick Fertre <yannick.fertre@st.com>
---
 drivers/input/touchscreen/goodix.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/input/touchscreen/goodix.c b/drivers/input/touchscreen/goodix.c
index 0403102..8851a35 100644
--- a/drivers/input/touchscreen/goodix.c
+++ b/drivers/input/touchscreen/goodix.c
@@ -251,6 +251,7 @@ static const struct goodix_chip_data *goodix_get_chip_data(u16 id)
 		return &gt911_chip_data;
 
 	case 912:
+	case 9147:
 	case 967:
 		return &gt967_chip_data;
 
@@ -1054,6 +1055,7 @@ static const struct of_device_id goodix_of_match[] = {
 	{ .compatible = "goodix,gt9271" },
 	{ .compatible = "goodix,gt928" },
 	{ .compatible = "goodix,gt967" },
+	{ .compatible = "goodix,gt9147",},
 	{ }
 };
 MODULE_DEVICE_TABLE(of, goodix_of_match);
-- 
2.7.4


^ permalink raw reply related	[flat|nested] 5+ messages in thread

* Re: [PATCH v1 2/2] Input: goodix - support gt9147 touchpanel
  2020-03-02 10:18 ` [PATCH v1 2/2] Input: goodix - support gt9147 touchpanel Yannick Fertre
@ 2020-03-02 11:00   ` Bastien Nocera
  0 siblings, 0 replies; 5+ messages in thread
From: Bastien Nocera @ 2020-03-02 11:00 UTC (permalink / raw)
  To: Yannick Fertre, Dmitry Torokhov, Rob Herring, Mark Rutland,
	Benjamin Gaignard, linux-input, devicetree, linux-kernel

On Mon, 2020-03-02 at 11:18 +0100, Yannick Fertre wrote:
> Add support for it by adding compatible and supported chip data
> (default settings used).
> The chip data on GT9147 is similar to GT912, like
> - config data register has 0x8047 address
> - config data register max len is 240
> - config data checksum has 8-bit
> 
> Signed-off-by: Yannick Fertre <yannick.fertre@st.com>


Both patches:
Reviewed-by: Bastien Nocera <hadess@hadess.net>

But you'll likely need to send another update on top of the "Add
support for Goodix GT917S touch controller" patchset, which makes some
changes to goodix_get_chip_data().


^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH v1 1/2] dt-bindings: touchscreen: goodix: support of gt9147
  2020-03-02 10:18 ` [PATCH v1 1/2] dt-bindings: touchscreen: " Yannick Fertre
@ 2020-03-10 19:27   ` Rob Herring
  0 siblings, 0 replies; 5+ messages in thread
From: Rob Herring @ 2020-03-10 19:27 UTC (permalink / raw)
  To: Yannick Fertre
  Cc: Bastien Nocera, Dmitry Torokhov, Mark Rutland, Benjamin Gaignard,
	Yannick Fertre, linux-input, devicetree, linux-kernel

On Mon, 2 Mar 2020 11:18:27 +0100, Yannick Fertre wrote:
> Add support for it by adding compatible.
> The chip data on GT9147 is similar to GT912, like
> - config data register has 0x8047 address
> - config data register max len is 240
> - config data checksum has 8-bit
> 
> Signed-off-by: Yannick Fertre <yannick.fertre@st.com>
> ---
>  Documentation/devicetree/bindings/input/touchscreen/goodix.yaml | 1 +
>  1 file changed, 1 insertion(+)
> 

Acked-by: Rob Herring <robh@kernel.org>

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2020-03-10 19:27 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-03-02 10:18 [PATCH v1 0/2] goodix: support of gt9147 Yannick Fertre
2020-03-02 10:18 ` [PATCH v1 1/2] dt-bindings: touchscreen: " Yannick Fertre
2020-03-10 19:27   ` Rob Herring
2020-03-02 10:18 ` [PATCH v1 2/2] Input: goodix - support gt9147 touchpanel Yannick Fertre
2020-03-02 11:00   ` Bastien Nocera

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).