From: Dmitry Mastykin <dmastykin@astralinux.ru>
To: Hans de Goede <hdegoede@redhat.com>,
Dmitry Torokhov <dmitry.torokhov@gmail.com>,
Bastien Nocera <hadess@hadess.net>
Cc: linux-input@vger.kernel.org, Dmitry Mastykin <dmastykin@astralinux.ru>
Subject: [PATCH v2 2/2] Input: goodix - Ignore spurious interrupts
Date: Thu, 12 Mar 2020 17:50:11 +0300 [thread overview]
Message-ID: <20200312145009.27449-2-dmastykin@astralinux.ru> (raw)
In-Reply-To: <20200312145009.27449-1-dmastykin@astralinux.ru>
The goodix panel sends spurious interrupts after a 'finger up' event,
which always cause a timeout.
The timeout was reported as touch_num == 0 and caused reading of
not ready buffer and false key release event.
In this patch the timeout is reported as ENOMSG and not processed.
Signed-off-by: Dmitry Mastykin <dmastykin@astralinux.ru>
---
Changes in v2:
- Improve commit message
---
drivers/input/touchscreen/goodix.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/input/touchscreen/goodix.c b/drivers/input/touchscreen/goodix.c
index daf1781..0e14719 100644
--- a/drivers/input/touchscreen/goodix.c
+++ b/drivers/input/touchscreen/goodix.c
@@ -329,7 +329,7 @@ static int goodix_ts_read_input_report(struct goodix_ts_data *ts, u8 *data)
* The Goodix panel will send spurious interrupts after a
* 'finger up' event, which will always cause a timeout.
*/
- return 0;
+ return -ENOMSG;
}
static void goodix_ts_report_touch_8b(struct goodix_ts_data *ts, u8 *coor_data)
--
2.23.0
next prev parent reply other threads:[~2020-03-12 14:52 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-12 14:50 [PATCH v2 1/2] Input: goodix - Add support for more then one touch-key Dmitry Mastykin
2020-03-12 14:50 ` Dmitry Mastykin [this message]
2020-03-13 11:10 ` [PATCH v2 2/2] Input: goodix - Ignore spurious interrupts Hans de Goede
2020-03-13 13:28 ` Bastien Nocera
2020-03-13 14:20 ` Dmitry Mastykin
2020-03-13 11:10 ` [PATCH v2 1/2] Input: goodix - Add support for more then one touch-key Hans de Goede
2020-03-13 13:19 ` Bastien Nocera
2020-03-13 14:18 ` Dmitry Mastykin
2020-03-13 15:20 ` Bastien Nocera
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200312145009.27449-2-dmastykin@astralinux.ru \
--to=dmastykin@astralinux.ru \
--cc=dmitry.torokhov@gmail.com \
--cc=hadess@hadess.net \
--cc=hdegoede@redhat.com \
--cc=linux-input@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).