From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3C5F2C3F2CE for ; Mon, 16 Mar 2020 09:01:08 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 1D10020658 for ; Mon, 16 Mar 2020 09:01:08 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730323AbgCPJA7 (ORCPT ); Mon, 16 Mar 2020 05:00:59 -0400 Received: from relay1-d.mail.gandi.net ([217.70.183.193]:64591 "EHLO relay1-d.mail.gandi.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730317AbgCPJA7 (ORCPT ); Mon, 16 Mar 2020 05:00:59 -0400 X-Originating-IP: 86.202.105.35 Received: from localhost (lfbn-lyo-1-9-35.w86-202.abo.wanadoo.fr [86.202.105.35]) (Authenticated sender: alexandre.belloni@bootlin.com) by relay1-d.mail.gandi.net (Postfix) with ESMTPSA id B1587240004; Mon, 16 Mar 2020 09:00:53 +0000 (UTC) Date: Mon, 16 Mar 2020 10:00:53 +0100 From: Alexandre Belloni To: Anson Huang Cc: Shawn Guo , Peng Fan , "s.hauer@pengutronix.de" , "kernel@pengutronix.de" , "festevam@gmail.com" , "dmitry.torokhov@gmail.com" , "a.zummo@towertech.it" , "rui.zhang@intel.com" , "daniel.lezcano@linaro.org" , "amit.kucheria@verdurent.com" , "wim@linux-watchdog.org" , "linux@roeck-us.net" , Daniel Baluta , "gregkh@linuxfoundation.org" , "linux@rempel-privat.de" , "tglx@linutronix.de" , "m.felsch@pengutronix.de" , "andriy.shevchenko@linux.intel.com" , "arnd@arndb.de" , "ronald@innovation.ch" , "krzk@kernel.org" , "robh@kernel.org" , Leonard Crestez , Aisheng Dong , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" , "linux-input@vger.kernel.org" , "linux-rtc@vger.kernel.org" , "linux-pm@vger.kernel.org" , "linux-watchdog@vger.kernel.org" , dl-linux-imx Subject: Re: [PATCH V3 1/7] firmware: imx: Add stubs for !CONFIG_IMX_SCU case Message-ID: <20200316090053.GH4518@piout.net> References: <1583714300-19085-1-git-send-email-Anson.Huang@nxp.com> <20200316005219.GD17221@dragon> <20200316030744.GC17221@dragon> <20200316033447.GE17221@dragon> <20200316084056.GG4518@piout.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Sender: linux-input-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-input@vger.kernel.org On 16/03/2020 08:44:10+0000, Anson Huang wrote: > > > > Subject: Re: [PATCH V3 1/7] firmware: imx: Add stubs for !CONFIG_IMX_SCU > > case > > > > On 16/03/2020 08:04:17+0000, Anson Huang wrote: > > > Hi, Shawn > > > > > > > Subject: Re: [PATCH V3 1/7] firmware: imx: Add stubs for > > > > !CONFIG_IMX_SCU case > > > > > > > > On Mon, Mar 16, 2020 at 03:18:43AM +0000, Peng Fan wrote: > > > > > Just sent out. One more thing, I think all drivers depends on > > > > > IMX_SCU should not have COMPILE_TEST if we plan not to add dummy > > > > > functions. I see you picked up Anson's patch in imx/drivers branch, > > please check more. > > > > > > > > Ha, yes. COMPILE_TEST should be dropped for IMX_SCU_PD in Anson's > > patch. > > > > Thanks for reminding. > > > > > > I still NOT quite understand why we won't support COMPILE_TEST for SCU > > > drivers, with whose stubs, the build should be OK, if there is any > > > build error, we should try to fix it, NOT just remove the COMPILE_TEST > > support, any special reason? > > > > > > > COMPILE_TEST is supported as long as IMX_SCU is selected like is it for any > > driver depending on any bus. > > But without having " || COMPILE_TEST " in kconfig, COMPILE_TEST will NOT be supported, > I think as long as we have stubs for those SCU APIs, all drivers depending on IMX_SCU can > support COMPILE_TEST independently. > Why do you absolutely need to compile them independently? From a code coverage point of view, having: COMPILE_TEST=y CONFIG_IMX_SCU=y is enough to select and compile the remaining drivers. -- Alexandre Belloni, Bootlin Embedded Linux and Kernel engineering https://bootlin.com