Linux Input Archive on lore.kernel.org
 help / color / Atom feed
* [PATCH 0/1] Input: goodix - Try to reset the controller if the i2c-test fails
@ 2020-03-11 19:10 Hans de Goede
  2020-03-11 19:10 ` [PATCH] " Hans de Goede
  0 siblings, 1 reply; 3+ messages in thread
From: Hans de Goede @ 2020-03-11 19:10 UTC (permalink / raw)
  To: Dmitry Torokhov, Bastien Nocera
  Cc: Hans de Goede, Dmitry Mastykin, linux-input

Hi,

Here is a small patch fixing the goodix touchscreen driver failing at
probe due to what I consider a BIOS bug on Dmitry's Mastykin's tablet.

This patch applies on top of my earlier series starting with:
[PATCH v3 01/11] Input: goodix - Refactor IRQ pin GPIO accesses

Regards,

Hans


^ permalink raw reply	[flat|nested] 3+ messages in thread

* [PATCH] Input: goodix - Try to reset the controller if the i2c-test fails
  2020-03-11 19:10 [PATCH 0/1] Input: goodix - Try to reset the controller if the i2c-test fails Hans de Goede
@ 2020-03-11 19:10 ` " Hans de Goede
  2020-03-24 18:52   ` Dmitry Torokhov
  0 siblings, 1 reply; 3+ messages in thread
From: Hans de Goede @ 2020-03-11 19:10 UTC (permalink / raw)
  To: Dmitry Torokhov, Bastien Nocera
  Cc: Hans de Goede, Dmitry Mastykin, linux-input

On some ACPI/x86 devices (where we use one of the ACPI IRQ pin access
methods) the firmware is buggy, it does not properly reset the controller
at boot, and we cannot communicate with it.

Normally on ACPI/x86 devices we do not want to reset the controller at
probe time since in some cases this causes the controller to loose its
configuration and this is loaded into it by the system's firmware.
So on these systems we leave the reset_controller_at_probe flag unset,
even though we have a access to both the IRQ and reset pins and thus
could reset it.

In the case of the buggy firmware we have to reset the controller to
actually be able to talk to it.

This commit adds a special case for this, if the goodix_i2c_test() fails,
and we have not reset the controller yet; and we do have a way to reset
the controller then retry the i2c-test after resetting the controller.

This fixes the driver failing at probe on ACPI/x86 systems with this
firmware bug.

Reported-and-tested-by: Dmitry Mastykin <dmastykin@astralinux.ru>
Signed-off-by: Hans de Goede <hdegoede@redhat.com>
---
 drivers/input/touchscreen/goodix.c | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/drivers/input/touchscreen/goodix.c b/drivers/input/touchscreen/goodix.c
index 2f135ac9484e..816d6ade89a9 100644
--- a/drivers/input/touchscreen/goodix.c
+++ b/drivers/input/touchscreen/goodix.c
@@ -1165,6 +1165,7 @@ static int goodix_ts_probe(struct i2c_client *client,
 	if (error)
 		return error;
 
+reset:
 	if (ts->reset_controller_at_probe) {
 		/* reset the controller */
 		error = goodix_reset(ts);
@@ -1176,6 +1177,12 @@ static int goodix_ts_probe(struct i2c_client *client,
 
 	error = goodix_i2c_test(client);
 	if (error) {
+		if (!ts->reset_controller_at_probe &&
+		    ts->irq_pin_access_method != IRQ_PIN_ACCESS_NONE) {
+			/* Retry after a controller reset */
+			ts->reset_controller_at_probe = true;
+			goto reset;
+		}
 		dev_err(&client->dev, "I2C communication failure: %d\n", error);
 		return error;
 	}
-- 
2.25.1


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] Input: goodix - Try to reset the controller if the i2c-test fails
  2020-03-11 19:10 ` [PATCH] " Hans de Goede
@ 2020-03-24 18:52   ` Dmitry Torokhov
  0 siblings, 0 replies; 3+ messages in thread
From: Dmitry Torokhov @ 2020-03-24 18:52 UTC (permalink / raw)
  To: Hans de Goede; +Cc: Bastien Nocera, Dmitry Mastykin, linux-input

On Wed, Mar 11, 2020 at 08:10:13PM +0100, Hans de Goede wrote:
> On some ACPI/x86 devices (where we use one of the ACPI IRQ pin access
> methods) the firmware is buggy, it does not properly reset the controller
> at boot, and we cannot communicate with it.
> 
> Normally on ACPI/x86 devices we do not want to reset the controller at
> probe time since in some cases this causes the controller to loose its
> configuration and this is loaded into it by the system's firmware.
> So on these systems we leave the reset_controller_at_probe flag unset,
> even though we have a access to both the IRQ and reset pins and thus
> could reset it.
> 
> In the case of the buggy firmware we have to reset the controller to
> actually be able to talk to it.
> 
> This commit adds a special case for this, if the goodix_i2c_test() fails,
> and we have not reset the controller yet; and we do have a way to reset
> the controller then retry the i2c-test after resetting the controller.
> 
> This fixes the driver failing at probe on ACPI/x86 systems with this
> firmware bug.
> 
> Reported-and-tested-by: Dmitry Mastykin <dmastykin@astralinux.ru>
> Signed-off-by: Hans de Goede <hdegoede@redhat.com>

Applied, thank you.

> ---
>  drivers/input/touchscreen/goodix.c | 7 +++++++
>  1 file changed, 7 insertions(+)
> 
> diff --git a/drivers/input/touchscreen/goodix.c b/drivers/input/touchscreen/goodix.c
> index 2f135ac9484e..816d6ade89a9 100644
> --- a/drivers/input/touchscreen/goodix.c
> +++ b/drivers/input/touchscreen/goodix.c
> @@ -1165,6 +1165,7 @@ static int goodix_ts_probe(struct i2c_client *client,
>  	if (error)
>  		return error;
>  
> +reset:
>  	if (ts->reset_controller_at_probe) {
>  		/* reset the controller */
>  		error = goodix_reset(ts);
> @@ -1176,6 +1177,12 @@ static int goodix_ts_probe(struct i2c_client *client,
>  
>  	error = goodix_i2c_test(client);
>  	if (error) {
> +		if (!ts->reset_controller_at_probe &&
> +		    ts->irq_pin_access_method != IRQ_PIN_ACCESS_NONE) {
> +			/* Retry after a controller reset */
> +			ts->reset_controller_at_probe = true;
> +			goto reset;
> +		}
>  		dev_err(&client->dev, "I2C communication failure: %d\n", error);
>  		return error;
>  	}
> -- 
> 2.25.1
> 

-- 
Dmitry

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, back to index

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-03-11 19:10 [PATCH 0/1] Input: goodix - Try to reset the controller if the i2c-test fails Hans de Goede
2020-03-11 19:10 ` [PATCH] " Hans de Goede
2020-03-24 18:52   ` Dmitry Torokhov

Linux Input Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-input/0 linux-input/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-input linux-input/ https://lore.kernel.org/linux-input \
		linux-input@vger.kernel.org
	public-inbox-index linux-input

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-input


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git