From: Lee Jones <lee.jones@linaro.org>
To: Rob Herring <robh@kernel.org>
Cc: Benjamin Gaignard <benjamin.gaignard@st.com>,
dmitry.torokhov@gmail.com, robh+dt@kernel.org,
mark.rutland@arm.com, lgirdwood@gmail.com, broonie@kernel.org,
wim@linux-watchdog.org, linux@roeck-us.net, p.paillet@st.com,
linux-input@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-watchdog@vger.kernel.org
Subject: Re: [PATCH v5] dt-bindings: mfd: Convert stpmic1 bindings to json-schema
Date: Wed, 25 Mar 2020 09:20:04 +0000 [thread overview]
Message-ID: <20200325092004.GF442973@dell> (raw)
In-Reply-To: <20200310211849.GA13562@bogus>
On Tue, 10 Mar 2020, Rob Herring wrote:
> On Wed, 4 Mar 2020 10:42:20 +0100, Benjamin Gaignard wrote:
> > Convert stpmic1 bindings to json-schema.
> >
> > Signed-off-by: Benjamin Gaignard <benjamin.gaignard@st.com>
> > ---
> > version 5:
> > - move $ref regulator.yaml under a patternProperties
> > - move remain fixed strings under properties field
> >
> > version 4:
> > - move on uppder node $ref: ../regulator/regulator.yaml
> > - move fixed strings under properties field
> > - remove unneeded () in patternProperties
> > - keep ldo3 separate from other ldo properties
> > Note:
> > - 'st,mask-reset' property stay in each subnode, I don't find
> > the syntax to avoid dupliquate it.
> > - ldo6-supply and all possible *-supply are describe by this regular
> > expression: ^(buck[1-4]|ldo[1-6]|boost|pwr_sw[1-2])-supply$":
> >
> > version 3:
> > - put $ref under allOf keyword
> > - for each regulator node add the list of supported regulator properties
> >
> > .../devicetree/bindings/input/st,stpmic1-onkey.txt | 28 --
> > .../devicetree/bindings/mfd/st,stpmic1.txt | 61 ----
> > .../devicetree/bindings/mfd/st,stpmic1.yaml | 339 +++++++++++++++++++++
> > .../bindings/regulator/st,stpmic1-regulator.txt | 64 ----
> > .../bindings/watchdog/st,stpmic1-wdt.txt | 11 -
> > 5 files changed, 339 insertions(+), 164 deletions(-)
> > delete mode 100644 Documentation/devicetree/bindings/input/st,stpmic1-onkey.txt
> > delete mode 100644 Documentation/devicetree/bindings/mfd/st,stpmic1.txt
> > create mode 100644 Documentation/devicetree/bindings/mfd/st,stpmic1.yaml
> > delete mode 100644 Documentation/devicetree/bindings/regulator/st,stpmic1-regulator.txt
> > delete mode 100644 Documentation/devicetree/bindings/watchdog/st,stpmic1-wdt.txt
> >
>
> Reviewed-by: Rob Herring <robh@kernel.org>
Can you take this please Rob?
It would save an IB and PR.
--
Lee Jones [李琼斯]
Linaro Services Technical Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
next prev parent reply other threads:[~2020-03-25 9:19 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-04 9:42 [PATCH v5] dt-bindings: mfd: Convert stpmic1 bindings to json-schema Benjamin Gaignard
2020-03-10 21:18 ` Rob Herring
2020-03-25 9:20 ` Lee Jones [this message]
2020-03-25 16:13 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200325092004.GF442973@dell \
--to=lee.jones@linaro.org \
--cc=benjamin.gaignard@st.com \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.torokhov@gmail.com \
--cc=lgirdwood@gmail.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=mark.rutland@arm.com \
--cc=p.paillet@st.com \
--cc=robh+dt@kernel.org \
--cc=robh@kernel.org \
--cc=wim@linux-watchdog.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).