From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Rajat Jain <rajatja@google.com>
Cc: dtor@google.com, Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Kate Stewart <kstewart@linuxfoundation.org>,
Enrico Weigelt <info@metux.net>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Thomas Gleixner <tglx@linutronix.de>,
Allison Randal <allison@lohutok.net>,
"Rafael J. Wysocki" <rafael.j.wysocki@intel.com>,
Stephen Boyd <swboyd@chromium.org>,
linux-input@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, furquan@google.com,
dlaurie@google.com, bleung@google.com, zentaro@google.com,
dbehr@google.com, rajatxjain@gmail.com
Subject: Re: [PATCH v2 5/5] dt-bindings: input/atkbd.txt: Add binding info for "keymap" property
Date: Thu, 26 Mar 2020 14:28:46 -0700 [thread overview]
Message-ID: <20200326212846.GK75430@dtor-ws> (raw)
In-Reply-To: <20200324123518.239768-5-rajatja@google.com>
On Tue, Mar 24, 2020 at 05:35:18AM -0700, Rajat Jain wrote:
> Add the info for keymap property that allows firmware to specify the
> mapping from physical code to linux keycode, that the kernel should use.
>
> Signed-off-by: Rajat Jain <rajatja@google.com>
> ---
> v2: Remove the Change-Id from the commit log
>
> .../devicetree/bindings/input/atkbd.txt | 27 ++++++++++++++++++-
> 1 file changed, 26 insertions(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/input/atkbd.txt b/Documentation/devicetree/bindings/input/atkbd.txt
> index 816653eb8e98d..0a0037d70adc8 100644
> --- a/Documentation/devicetree/bindings/input/atkbd.txt
> +++ b/Documentation/devicetree/bindings/input/atkbd.txt
> @@ -6,9 +6,15 @@ Optional properties:
> An ordered array of the physical codes for the function
> row keys. Arranged in order from left to right.
>
> + keymap:
This map will contain Linux specific values, so I would say
"linux,keymap". Rob?
> + An array of the u32 entries to specify mapping from the
> + keyboard physcial codes to linux keycodes. The top 16
> + bits of each entry are the physical code, and bottom
> + 16 bits are the linux keycode.
> +
> Example:
>
> - This is a sample ACPI _DSD node describing the property:
> + This is a sample ACPI _DSD node describing the properties:
>
> Name (_DSD, Package () {
> ToUUID("daffd814-6eba-4d8c-8a91-bc9bbf4aa301"),
> @@ -29,6 +35,25 @@ Example:
> 0xAE, /* T12 VOL_DOWN */
> 0xB0, /* T13 VOL_UP */
> }
> + },
> + Package () { "keymap",
> + Package () {
> + 0xEA009E, /* EA -> KEY_BACK */
> + 0xE700AD, /* E7 -> KEY_REFRESH */
> + 0x910174, /* 91 -> KEY_FULL_SCREEN */
> + 0x920078, /* 92 -> KEY_SCALE */
> + 0x930280, /* 93 -> 0x280 */
> + 0x9400E0, /* 94 -> KEY_BRIGHTNESS_DOWN*/
> + 0x9500E1, /* 95 -> KEY_BRIGHTNESS_UP */
> + 0x960279, /* 96 -> KEY_PRIVACY_SCRN_TOGGLE*/
> + 0x9700E5, /* 97 -> KEY_KBDILLUMDOWN */
> + 0x9800E6, /* 98 -> KEY_KBDILLUMUP */
> + 0xA00071, /* A0 -> KEY_MUTE */
> + 0xAE0072, /* AE -> KEY_VOLUMEDOWN */
> + 0xB00073, /* B0 -> KEY_VOLUMEUP */
> + ...
> + <snip other entries>
> + }
> }
> }
> })
> --
> 2.25.1.696.g5e7596f4ac-goog
>
Thanks.
--
Dmitry
next prev parent reply other threads:[~2020-03-26 21:28 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-24 12:35 [PATCH v2 1/5] input/serio/i8042: Attach fwnode to serio i8042 kbd device Rajat Jain
2020-03-24 12:35 ` [PATCH v2 2/5] Input: atkbd: Expose function row physical map to userspace Rajat Jain
2020-03-26 21:27 ` Dmitry Torokhov
2020-03-26 22:18 ` Rajat Jain
2020-03-24 12:35 ` [PATCH v2 3/5] dt-bindings: input/atkbd.txt: Add binding for "function-row-physmap" Rajat Jain
2020-03-24 12:35 ` [PATCH v2 4/5] Input: atkbd: Receive and use physcode->keycode mapping from FW Rajat Jain
2020-03-26 21:20 ` Dmitry Torokhov
2020-03-27 1:37 ` Rajat Jain
2020-03-24 12:35 ` [PATCH v2 5/5] dt-bindings: input/atkbd.txt: Add binding info for "keymap" property Rajat Jain
2020-03-26 21:28 ` Dmitry Torokhov [this message]
2020-03-26 21:25 ` [PATCH v2 1/5] input/serio/i8042: Attach fwnode to serio i8042 kbd device Dmitry Torokhov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200326212846.GK75430@dtor-ws \
--to=dmitry.torokhov@gmail.com \
--cc=allison@lohutok.net \
--cc=bleung@google.com \
--cc=dbehr@google.com \
--cc=devicetree@vger.kernel.org \
--cc=dlaurie@google.com \
--cc=dtor@google.com \
--cc=furquan@google.com \
--cc=gregkh@linuxfoundation.org \
--cc=info@metux.net \
--cc=kstewart@linuxfoundation.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=rafael.j.wysocki@intel.com \
--cc=rajatja@google.com \
--cc=rajatxjain@gmail.com \
--cc=robh+dt@kernel.org \
--cc=swboyd@chromium.org \
--cc=tglx@linutronix.de \
--cc=zentaro@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).