linux-input.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Andrzej Pietrasiewicz <andrzej.p@collabora.com>
To: linux-input@vger.kernel.org, linux-iio@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-samsung-soc@vger.kernel.org
Cc: Jonathan Cameron <jic23@kernel.org>,
	Hartmut Knaack <knaack.h@gmx.de>,
	Lars-Peter Clausen <lars@metafoo.de>,
	Peter Meerwald-Stadler <pmeerw@pmeerw.net>,
	Kukjin Kim <kgene@kernel.org>,
	Krzysztof Kozlowski <krzk@kernel.org>,
	Andrzej Pietrasiewicz <andrzej.p@collabora.com>,
	kernel@collabora.com
Subject: [PATCHv2 4/7] iio: adc: exynos: Use input_device_enabled()
Date: Fri, 15 May 2020 18:52:10 +0200	[thread overview]
Message-ID: <20200515165210.28813-1-andrzej.p@collabora.com> (raw)
In-Reply-To: <20200515164943.28480-1-andrzej.p@collabora.com>

A new helper is available, so use it. Inspecting 'users' member of
input_dev requires taking device's mutex.

Signed-off-by: Andrzej Pietrasiewicz <andrzej.p@collabora.com>
---
 drivers/iio/adc/exynos_adc.c | 11 +++++++++--
 1 file changed, 9 insertions(+), 2 deletions(-)

diff --git a/drivers/iio/adc/exynos_adc.c b/drivers/iio/adc/exynos_adc.c
index 22131a677445..1253d94089a7 100644
--- a/drivers/iio/adc/exynos_adc.c
+++ b/drivers/iio/adc/exynos_adc.c
@@ -630,10 +630,13 @@ static irqreturn_t exynos_ts_isr(int irq, void *dev_id)
 	struct exynos_adc *info = dev_id;
 	struct iio_dev *dev = dev_get_drvdata(info->dev);
 	u32 x, y;
-	bool pressed;
+	bool pressed, cont;
 	int ret;
 
-	while (info->input->users) {
+	mutex_lock(&info->input);
+	cont = input_device_enabled(info->input);
+	mutex_unlock(&info->input);
+	while (cont) {
 		ret = exynos_read_s3c64xx_ts(dev, &x, &y);
 		if (ret == -ETIMEDOUT)
 			break;
@@ -651,6 +654,10 @@ static irqreturn_t exynos_ts_isr(int irq, void *dev_id)
 		input_sync(info->input);
 
 		usleep_range(1000, 1100);
+
+		mutex_lock(&info->input);
+		cont = input_device_enabled(info->input);
+		mutex_unlock(&info->input);
 	}
 
 	writel(0, ADC_V1_CLRINTPNDNUP(info->regs));
-- 
2.17.1


  parent reply	other threads:[~2020-05-15 16:52 UTC|newest]

Thread overview: 101+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-04-30 16:16 [PATCH 0/2] Support inhibiting input devices Andrzej Pietrasiewicz
2020-04-30 16:16 ` [PATCH 1/2] Input: Add "inhibited" property Andrzej Pietrasiewicz
2020-05-06  0:27   ` Dmitry Torokhov
2020-05-15 16:49     ` [PATCHv2 0/7] Support inhibiting input devices Andrzej Pietrasiewicz
2020-05-15 16:51       ` [PATCHv2 1/7] Input: add input_device_enabled() Andrzej Pietrasiewicz
2020-05-15 16:51       ` [PATCHv2 2/7] Input: use input_device_enabled() Andrzej Pietrasiewicz
2020-05-15 16:52       ` Andrzej Pietrasiewicz [this message]
2020-05-15 16:52       ` [PATCHv2 5/7] platform/x86: thinkpad_acpi: Use input_device_enabled() Andrzej Pietrasiewicz
2020-05-15 17:02         ` Henrique de Moraes Holschuh
2020-05-15 16:52       ` [PATCHv2 6/7] Input: Add "inhibited" property Andrzej Pietrasiewicz
2020-05-15 16:52       ` [PATCHv2 7/7] Input: elan_i2c: Support inhibiting Andrzej Pietrasiewicz
2020-05-15 16:53       ` [PATCHv2 3/7] ACPI: button: Use input_device_enabled() helper Andrzej Pietrasiewicz
2020-05-18 12:40         ` Rafael J. Wysocki
2020-05-15 18:19       ` [PATCHv2 0/7] Support inhibiting input devices Hans de Goede
2020-05-17 22:55         ` Peter Hutterer
2020-05-18  2:40           ` Dmitry Torokhov
2020-05-18  7:36             ` Hans de Goede
2020-05-22 15:35             ` Andrzej Pietrasiewicz
2020-05-27  6:13               ` Peter Hutterer
2020-05-18 10:48         ` Andrzej Pietrasiewicz
2020-05-18 12:24           ` Hans de Goede
2020-05-18 13:49             ` Andrzej Pietrasiewicz
2020-05-18 14:23               ` Hans de Goede
2020-05-19  9:02                 ` Andrzej Pietrasiewicz
2020-05-19  9:36                   ` Hans de Goede
2020-05-27  6:34                     ` Dmitry Torokhov
2020-06-02 16:56                       ` Andrzej Pietrasiewicz
2020-06-02 17:52                         ` Dmitry Torokhov
2020-06-02 18:50                           ` Andrzej Pietrasiewicz
2020-06-02 20:19                             ` Hans de Goede
2020-06-03 13:07                               ` Andrzej Pietrasiewicz
2020-06-03 17:38                                 ` Hans de Goede
2020-06-03 17:54                                   ` Andrzej Pietrasiewicz
2020-06-03 19:37                                     ` Hans de Goede
2020-06-04  7:28                                       ` Dmitry Torokhov
2020-06-05 17:33                                         ` [PATCH v3 " Andrzej Pietrasiewicz
2020-06-05 17:33                                           ` [PATCH v3 1/7] Input: add input_device_enabled() Andrzej Pietrasiewicz
2020-06-05 17:33                                           ` [PATCH v3 2/7] Input: use input_device_enabled() Andrzej Pietrasiewicz
2020-06-05 17:33                                           ` [PATCH v3 3/7] ACPI: button: Access input device's users under appropriate mutex Andrzej Pietrasiewicz
2020-06-05 17:33                                           ` [PATCH v3 4/7] ACPI: button: Use input_device_enabled() helper Andrzej Pietrasiewicz
2020-06-05 17:33                                           ` [PATCH v3 5/7] iio: adc: exynos: Use input_device_enabled() Andrzej Pietrasiewicz
2020-06-05 19:49                                             ` Michał Mirosław
2020-06-05 17:33                                           ` [PATCH v3 6/7] platform/x86: thinkpad_acpi: " Andrzej Pietrasiewicz
2020-06-05 17:33                                           ` [PATCH v3 7/7] Input: Add "inhibited" property Andrzej Pietrasiewicz
2020-06-05 17:41                                             ` Hans de Goede
2020-06-08 11:22                                               ` [PATCH v4 0/7] Support inhibiting input devices Andrzej Pietrasiewicz
2020-06-08 11:22                                                 ` [PATCH v4 1/7] Input: add input_device_enabled() Andrzej Pietrasiewicz
2020-12-03  6:25                                                   ` Dmitry Torokhov
2020-06-08 11:22                                                 ` [PATCH v4 2/7] Input: use input_device_enabled() Andrzej Pietrasiewicz
2020-12-03  6:26                                                   ` Dmitry Torokhov
     [not found]                                                   ` <CGME20201207133237eucas1p26f8484944760a14e51dc7353ed33cd28@eucas1p2.samsung.com>
2020-12-07 13:32                                                     ` Marek Szyprowski
2020-12-07 15:50                                                       ` Andrzej Pietrasiewicz
2020-12-08 10:05                                                         ` Marek Szyprowski
2020-12-09  6:37                                                           ` Dmitry Torokhov
2020-12-11  7:09                                                             ` [PATCH] Input: cyapa - do not call input_device_enabled from power mode handler Dmitry Torokhov
2020-12-11  8:22                                                               ` Marek Szyprowski
2020-12-11  8:31                                                                 ` Dmitry Torokhov
2020-06-08 11:22                                                 ` [PATCH v4 3/7] ACPI: button: Access input device's users under appropriate mutex Andrzej Pietrasiewicz
2020-06-24 15:00                                                   ` Rafael J. Wysocki
2020-06-25  5:23                                                     ` Dmitry Torokhov
2020-06-25 10:55                                                       ` Rafael J. Wysocki
2020-10-05  5:08                                                         ` Dmitry Torokhov
2020-06-08 11:22                                                 ` [PATCH v4 4/7] ACPI: button: Use input_device_enabled() helper Andrzej Pietrasiewicz
2020-06-25  5:24                                                   ` Dmitry Torokhov
2020-10-05  5:06                                                     ` Dmitry Torokhov
2020-06-08 11:22                                                 ` [PATCH v4 5/7] iio: adc: exynos: Use input_device_enabled() Andrzej Pietrasiewicz
2020-06-10  1:28                                                   ` Michał Mirosław
2020-06-10  7:52                                                     ` [FIXED PATCH " Andrzej Pietrasiewicz
2020-06-08 11:22                                                 ` [PATCH v4 6/7] platform/x86: thinkpad_acpi: " Andrzej Pietrasiewicz
2020-06-08 11:22                                                 ` [PATCH v4 7/7] Input: Add "inhibited" property Andrzej Pietrasiewicz
2020-10-05 18:10                                                   ` Dmitry Torokhov
2020-10-06 13:04                                                     ` Andrzej Pietrasiewicz
2020-10-07  1:11                                                       ` Dmitry Torokhov
2020-10-07  1:12                                                         ` Dmitry Torokhov
2020-12-03  6:26                                                           ` Dmitry Torokhov
2020-06-10  9:49                                                 ` [PATCH v4 0/7] Support inhibiting input devices Hans de Goede
2020-06-10 10:38                                                   ` Rafael J. Wysocki
2020-06-10 13:12                                                     ` Andrzej Pietrasiewicz
2020-06-10 13:21                                                       ` Hans de Goede
2020-06-10 13:41                                                         ` Andrzej Pietrasiewicz
2020-06-12  8:30                                                           ` Hans de Goede
2020-06-12  8:47                                                             ` Andrzej Pietrasiewicz
2020-06-16 17:29                                                             ` [PATCH] Input: document inhibiting Andrzej Pietrasiewicz
2020-06-16 17:38                                                               ` Randy Dunlap
2020-06-17  7:44                                                               ` Hans de Goede
2020-06-17 10:18                                                                 ` [PATCH v2] " Andrzej Pietrasiewicz
2020-06-17 10:21                                                                   ` Hans de Goede
2020-06-17 16:52                                                                   ` Randy Dunlap
2020-06-23 13:35                                                                   ` Pavel Machek
2020-12-03  6:27                                                                   ` Dmitry Torokhov
2020-06-10 14:01                                                         ` [PATCH v4 0/7] Support inhibiting input devices Rafael J. Wysocki
2020-06-10 13:52                                                     ` Hans de Goede
2020-06-10 18:28                                                     ` Dmitry Torokhov
2020-06-12  8:14                                                       ` Hans de Goede
2020-06-12  8:17                                                 ` Hans de Goede
2020-08-03 14:40                                                   ` Andrzej Pietrasiewicz
2020-06-07 20:24                                           ` [PATCH v3 " Pavel Machek
2020-06-08  5:37                                             ` Dmitry Torokhov
2020-06-08  9:28                                               ` Andrzej Pietrasiewicz
2020-04-30 16:16 ` [PATCH 2/2] Input: elan_i2c: Support inhibiting Andrzej Pietrasiewicz
2020-12-03  6:29   ` Dmitry Torokhov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200515165210.28813-1-andrzej.p@collabora.com \
    --to=andrzej.p@collabora.com \
    --cc=jic23@kernel.org \
    --cc=kernel@collabora.com \
    --cc=kgene@kernel.org \
    --cc=knaack.h@gmx.de \
    --cc=krzk@kernel.org \
    --cc=lars@metafoo.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-input@vger.kernel.org \
    --cc=linux-samsung-soc@vger.kernel.org \
    --cc=pmeerw@pmeerw.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).