Linux Input Archive on lore.kernel.org
 help / color / Atom feed
From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Randy Dunlap <rdunlap@infradead.org>
Cc: Jeff LaBundy <jeff@labundy.com>,
	Stephen Rothwell <sfr@canb.auug.org.au>,
	Linux Next Mailing List <linux-next@vger.kernel.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	"linux-input@vger.kernel.org" <linux-input@vger.kernel.org>,
	Mark Brown <broonie@kernel.org>
Subject: Re: linux-next: Tree for May 18 (input/misc/iqs269a.c & regmap)
Date: Fri, 22 May 2020 14:49:35 -0700
Message-ID: <20200522214935.GB89269@dtor-ws> (raw)
In-Reply-To: <e6a56505-b99c-6b22-c35a-3596857fa421@infradead.org>

On Fri, May 22, 2020 at 11:22:39AM -0700, Randy Dunlap wrote:
> On 5/18/20 9:20 AM, Jeff LaBundy wrote:
> > Hi Randy et al,
> > 
> > On Mon, May 18, 2020 at 08:42:43AM -0700, Randy Dunlap wrote:
> >> On 5/18/20 3:57 AM, Stephen Rothwell wrote:
> >>> Hi all,
> >>>
> >>> Changes since 20200515:
> >>>
> >>
> >> on i386:
> >>
> >>
> >> CONFIG_REGMAP_I2C=y
> >> CONFIG_I2C=m
> >>
> >> WARNING: unmet direct dependencies detected for REGMAP_I2C
> >>   Depends on [m]: I2C [=m]
> >>   Selected by [y]:
> >>   - INPUT_IQS269A [=y] && !UML && INPUT [=y] && INPUT_MISC [=y]
> >>
> >>
> >> ld: drivers/base/regmap/regmap-i2c.o: in function `regmap_smbus_byte_reg_read':
> >> regmap-i2c.c:(.text+0x192): undefined reference to `i2c_smbus_read_byte_data'
> >> ld: drivers/base/regmap/regmap-i2c.o: in function `regmap_smbus_byte_reg_write':
> >> regmap-i2c.c:(.text+0x1d7): undefined reference to `i2c_smbus_write_byte_data'
> >> ld: drivers/base/regmap/regmap-i2c.o: in function `regmap_smbus_word_reg_read':
> >> regmap-i2c.c:(.text+0x202): undefined reference to `i2c_smbus_read_word_data'
> >> ld: drivers/base/regmap/regmap-i2c.o: in function `regmap_smbus_word_read_swapped':
> >> regmap-i2c.c:(.text+0x242): undefined reference to `i2c_smbus_read_word_data'
> >> ld: drivers/base/regmap/regmap-i2c.o: in function `regmap_smbus_word_write_swapped':
> >> regmap-i2c.c:(.text+0x2a1): undefined reference to `i2c_smbus_write_word_data'
> >> ld: drivers/base/regmap/regmap-i2c.o: in function `regmap_smbus_word_reg_write':
> >> regmap-i2c.c:(.text+0x2d7): undefined reference to `i2c_smbus_write_word_data'
> >> ld: drivers/base/regmap/regmap-i2c.o: in function `regmap_i2c_smbus_i2c_read_reg16':
> >> regmap-i2c.c:(.text+0x310): undefined reference to `i2c_smbus_write_byte_data'
> >> ld: regmap-i2c.c:(.text+0x323): undefined reference to `i2c_smbus_read_byte'
> >> ld: drivers/base/regmap/regmap-i2c.o: in function `regmap_i2c_smbus_i2c_write_reg16':
> >> regmap-i2c.c:(.text+0x39c): undefined reference to `i2c_smbus_write_i2c_block_data'
> >> ld: drivers/base/regmap/regmap-i2c.o: in function `regmap_i2c_smbus_i2c_write':
> >> regmap-i2c.c:(.text+0x3db): undefined reference to `i2c_smbus_write_i2c_block_data'
> >> ld: drivers/base/regmap/regmap-i2c.o: in function `regmap_i2c_smbus_i2c_read':
> >> regmap-i2c.c:(.text+0x427): undefined reference to `i2c_smbus_read_i2c_block_data'
> >> ld: drivers/base/regmap/regmap-i2c.o: in function `regmap_i2c_read':
> >> regmap-i2c.c:(.text+0x49f): undefined reference to `i2c_transfer'
> >> ld: drivers/base/regmap/regmap-i2c.o: in function `regmap_i2c_gather_write':
> >> regmap-i2c.c:(.text+0x524): undefined reference to `i2c_transfer'
> >> ld: drivers/base/regmap/regmap-i2c.o: in function `regmap_i2c_write':
> >> regmap-i2c.c:(.text+0x56c): undefined reference to `i2c_transfer_buffer_flags'
> >> ld: drivers/input/misc/iqs269a.o: in function `iqs269_i2c_driver_init':
> >> iqs269a.c:(.init.text+0xb): undefined reference to `i2c_register_driver'
> >> ld: drivers/input/misc/iqs269a.o: in function `iqs269_i2c_driver_exit':
> >> iqs269a.c:(.exit.text+0x9): undefined reference to `i2c_del_driver'
> >>
> >>
> >>
> >> Full randconfig file is attached.
> > 
> > A complete oversight on my part; during my testing I did not realize
> > another module was selecting I2C for me. Valuable lesson learned :)
> > 
> > The kbuild test robot set off the alarm bells earlier today and I've
> > sent a patch [1] already. Many apologies for all of the noise.
> > 
> >>
> >> -- 
> >> ~Randy
> >> Reported-by: Randy Dunlap <rdunlap@infradead.org>
> > 
> > [1] https://patchwork.kernel.org/patch/11555469/
> > 
> > Kind regards,
> > Jeff LaBundy
> 
> 
> Acked-by: Randy Dunlap <rdunlap@infradead.org> # build-tested
> 
> 
> This build error still happens in linux-next 20200522.
> Perhaps we can have this patch merged & pushed out so that
> linux-next can pick it up, please?

Sorry, I applied it when Jeff posted it, but forgot to push out.

Thanks.

-- 
Dmitry

      reply index

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20200518205725.72eb3148@canb.auug.org.au>
     [not found] ` <60dadc36-daec-2c48-a317-843ce52ae4f5@infradead.org>
2020-05-18 16:20   ` Jeff LaBundy
2020-05-22 18:22     ` Randy Dunlap
2020-05-22 21:49       ` Dmitry Torokhov [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200522214935.GB89269@dtor-ws \
    --to=dmitry.torokhov@gmail.com \
    --cc=broonie@kernel.org \
    --cc=jeff@labundy.com \
    --cc=linux-input@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-next@vger.kernel.org \
    --cc=rdunlap@infradead.org \
    --cc=sfr@canb.auug.org.au \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Linux Input Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-input/0 linux-input/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-input linux-input/ https://lore.kernel.org/linux-input \
		linux-input@vger.kernel.org
	public-inbox-index linux-input

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-input


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git