From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Marco Felsch <m.felsch@pengutronix.de>
Cc: Fengping Yu <fengping.yu@mediatek.com>,
Dmitry Torokhov <dmitry.torokhov@gmail.com>,
linux-input@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org
Subject: Re: [PATCH v9 2/3] drivers: input: keyboard: Add mtk keypad driver
Date: Wed, 27 May 2020 12:50:50 +0300 [thread overview]
Message-ID: <20200527095050.GJ1634618@smile.fi.intel.com> (raw)
In-Reply-To: <20200527090048.wawdb5qkkhroyjtf@pengutronix.de>
On Wed, May 27, 2020 at 11:00:48AM +0200, Marco Felsch wrote:
> On 20-05-27 16:31, Fengping Yu wrote:
> > + irqnr = platform_get_irq(pdev, 0);
> > + if (irqnr < 0)
> > + return -irqnr;
> ^
> irqnr is already negative
>
> > + ret = devm_request_threaded_irq(&pdev->dev, irqnr,
> > + NULL, kpd_irq_handler, 0,
> > + MTK_KPD_NAME, keypad);
> > + if (ret) {
> > + dev_err(&pdev->dev, "Failed to request IRQ#%d:%d\n",
> > + irqnr, ret);
>
> Still not alligned.
>
> > + return ret;
> > + }
And on top, can't we use irq instead of irqnr?
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2020-05-27 9:50 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-27 8:31 [PATCH v9] Add matrix keypad driver support for Mediatek SoCs Fengping Yu
[not found] ` <20200527083137.56566-3-fengping.yu@mediatek.com>
2020-05-27 9:00 ` [PATCH v9 2/3] drivers: input: keyboard: Add mtk keypad driver Marco Felsch
2020-05-27 9:50 ` Andy Shevchenko [this message]
2020-05-27 9:09 ` Marco Felsch
[not found] ` <20200527083137.56566-4-fengping.yu@mediatek.com>
2020-05-27 9:02 ` [PATCH v9 3/3] configs: defconfig: Add CONFIG_KEYBOARD_MTK_KPD=m Marco Felsch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200527095050.GJ1634618@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=dmitry.torokhov@gmail.com \
--cc=fengping.yu@mediatek.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=m.felsch@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).