From: Johan Hovold <johan@kernel.org>
To: Alexandru Ardelean <alexandru.ardelean@analog.com>
Cc: bcm-kernel-feedback-list@broadcom.com, linux-iio@vger.kernel.org,
linux-kernel@vger.kernel.org,
linux-stm32@st-md-mailman.stormreply.com,
linux-arm-kernel@lists.infradead.org,
linux-input@vger.kernel.org, linux-aspeed@lists.ozlabs.org,
linux-samsung-soc@vger.kernel.org,
linux-amlogic@lists.infradead.org,
linux-mediatek@lists.infradead.org,
linux-arm-msm@vger.kernel.org,
linux-rockchip@lists.infradead.org, linux-pm@vger.kernel.org,
platform-driver-x86@vger.kernel.org, devel@driverdev.osuosl.org,
vilhelm.gray@gmail.com, syednwaris@gmail.com,
fabrice.gasnier@st.com, mcoquelin.stm32@gmail.com,
alexandre.torgue@st.com, jic23@kernel.org, dan@dlrobertson.com,
jikos@kernel.org, srinivas.pandruvada@linux.intel.com,
linus.walleij@linaro.org, wens@csie.org, hdegoede@redhat.com,
rjui@broadcom.com, sbranden@broadcom.com, peda@axentia.se,
kgene@kernel.org, krzk@kernel.org, shawnguo@kernel.org,
s.hauer@pengutronix.de, ak@it-klinger.de, paul@crapouillou.net,
milo.kim@ti.com, vz@mleia.com, slemieux.tyco@gmail.com,
khilman@baylibre.com, matthias.bgg@gmail.com, agross@kernel.org,
bjorn.andersson@linaro.org, heiko@sntech.de, orsonzhai@gmail.com,
baolin.wang7@gmail.com, zhang.lyra@gmail.com, mripard@kernel.org,
tduszyns@gmail.com, rmfrfs@gmail.com,
lorenzo.bianconi83@gmail.com, ktsai@capellamicro.com,
songqiang1304521@gmail.com, tomislav.denis@avl.com,
eajames@linux.ibm.com, dmitry.torokhov@gmail.com,
coproscefalo@gmail.com
Subject: Re: [PATCH 4/5] iio: light: lm3533-als: remove explicit parent assignment
Date: Fri, 29 May 2020 12:16:08 +0200 [thread overview]
Message-ID: <20200529101608.GC19480@localhost> (raw)
In-Reply-To: <20200522082208.383631-4-alexandru.ardelean@analog.com>
On Fri, May 22, 2020 at 11:22:07AM +0300, Alexandru Ardelean wrote:
> This assignment is the more peculiar of the bunch as it assigns the parent
> of the platform-device's device (i.e. pdev->dev.parent) as the IIO device's
> parent.
>
> It's unclear whether this is intentional or not.
> Hence it is in it's own patch.
Yeah, we have a few mfd drivers whose child drivers registers their
class devices directly under the parent mfd device rather than the
corresponding child platform device.
Since it's done consistently I think you need to update them all if you
really want to change this.
And it may not be worth it since at least in theory someone could now be
relying on this topology.
> Signed-off-by: Alexandru Ardelean <alexandru.ardelean@analog.com>
> ---
> drivers/iio/light/lm3533-als.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/iio/light/lm3533-als.c b/drivers/iio/light/lm3533-als.c
> index bc196c212881..0f380ec8d30c 100644
> --- a/drivers/iio/light/lm3533-als.c
> +++ b/drivers/iio/light/lm3533-als.c
> @@ -852,7 +852,6 @@ static int lm3533_als_probe(struct platform_device *pdev)
> indio_dev->channels = lm3533_als_channels;
> indio_dev->num_channels = ARRAY_SIZE(lm3533_als_channels);
> indio_dev->name = dev_name(&pdev->dev);
> - indio_dev->dev.parent = pdev->dev.parent;
> indio_dev->modes = INDIO_DIRECT_MODE;
>
> als = iio_priv(indio_dev);
Johan
next prev parent reply other threads:[~2020-05-29 10:16 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-22 8:22 [PATCH 1/5] iio: core: pass parent device as parameter during allocation Alexandru Ardelean
2020-05-22 8:22 ` [PATCH 3/5] iio: remove left-over comments about parent assignment Alexandru Ardelean
2020-05-22 8:22 ` [PATCH 4/5] iio: light: lm3533-als: remove explicit " Alexandru Ardelean
2020-05-29 10:16 ` Johan Hovold [this message]
2020-05-22 8:22 ` [PATCH 5/5] iio: remove left-over parent assignments Alexandru Ardelean
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200529101608.GC19480@localhost \
--to=johan@kernel.org \
--cc=agross@kernel.org \
--cc=ak@it-klinger.de \
--cc=alexandre.torgue@st.com \
--cc=alexandru.ardelean@analog.com \
--cc=baolin.wang7@gmail.com \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=bjorn.andersson@linaro.org \
--cc=coproscefalo@gmail.com \
--cc=dan@dlrobertson.com \
--cc=devel@driverdev.osuosl.org \
--cc=dmitry.torokhov@gmail.com \
--cc=eajames@linux.ibm.com \
--cc=fabrice.gasnier@st.com \
--cc=hdegoede@redhat.com \
--cc=heiko@sntech.de \
--cc=jic23@kernel.org \
--cc=jikos@kernel.org \
--cc=kgene@kernel.org \
--cc=khilman@baylibre.com \
--cc=krzk@kernel.org \
--cc=ktsai@capellamicro.com \
--cc=linus.walleij@linaro.org \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-aspeed@lists.ozlabs.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=lorenzo.bianconi83@gmail.com \
--cc=matthias.bgg@gmail.com \
--cc=mcoquelin.stm32@gmail.com \
--cc=milo.kim@ti.com \
--cc=mripard@kernel.org \
--cc=orsonzhai@gmail.com \
--cc=paul@crapouillou.net \
--cc=peda@axentia.se \
--cc=platform-driver-x86@vger.kernel.org \
--cc=rjui@broadcom.com \
--cc=rmfrfs@gmail.com \
--cc=s.hauer@pengutronix.de \
--cc=sbranden@broadcom.com \
--cc=shawnguo@kernel.org \
--cc=slemieux.tyco@gmail.com \
--cc=songqiang1304521@gmail.com \
--cc=srinivas.pandruvada@linux.intel.com \
--cc=syednwaris@gmail.com \
--cc=tduszyns@gmail.com \
--cc=tomislav.denis@avl.com \
--cc=vilhelm.gray@gmail.com \
--cc=vz@mleia.com \
--cc=wens@csie.org \
--cc=zhang.lyra@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).